[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Daniel Beck edited a comment on JENKINS-24171 BFA is blindly adding text to gzipped log Makes sense. Probably needs to throw on 0 returned from gz.skip(int) unless the parameter is also 0. However this seems to be a separate issue (robustness in the face of invalid input) and should be filed separately, as the solutions are independent (i.e. fixing BFA does not seem to depend on core fixes or something like that). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Daniel Beck commented on JENKINS-24171 BFA is blindly adding text to gzipped log Makes sense. Probably needs to throw on 0 returned from gz.skip(int) unless the parameter is also 0. However this seems to be a separate issue (robustness in the face of invalid input) and should be filed separately. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner commented on JENKINS-24171 BFA is blindly adding text to gzipped log Daniel, I don't really know how this "feature" it is implemented, but I smell it is problem on both sides BFA should not append plaintext to compressed stream Jenkins should not hang when displaying gzipped log with trailing garbage at the end. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Daniel Beck updated JENKINS-24171 BFA is blindly adding text to gzipped log Assuming to be an issue with BFA opening log file non-gzipped until proven otherwise. Change By: Daniel Beck (11/Aug/14 10:27 AM) Component/s: core This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner edited a comment on JENKINS-24171 BFA is blindly adding text to gzipped log We are just using gzip on the log files. As written in the https://issues.jenkins-ci.org/browse/JENKINS-2551. Something like # gzip /var/lib/jenkins/jobs/sync-images-rhel-7v0/builds/25/log This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner
commented on JENKINS-24171
BFA is blindly adding text to gzipped log
We are just using gzip on the log files. As written in the https://issues.jenkins-ci.org/browse/JENKINS-2551. Something like
{{
gzip /var/lib/jenkins/jobs/sync-images-rhel-7v0/builds/25/log
}}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Daniel Beck commented on JENKINS-24171 BFA is blindly adding text to gzipped log Could you explain how you ended up with a gzipped build log? Or in general, how this issue can be reproduced? From a superficial BFA source code reading, it seems to do everything right. While the log file could be gzipped, it's safe to assume TaskListener.getLogger() (a PrintStream) is handling this transparently. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner updated JENKINS-24171 BFA is blindly adding text to gzipped log Change By: Jaroslav Henner (08/Aug/14 11:02 AM) Description: Jenkins has ability to diplay gunzip gzipped logs on the fly (https://issues.jenkins-ci.org/browse/JENKINS-2551) but it though doesn't natively compress the logs. The BFA doesn't expect that the logs can be compressed and appends the a plaintext to the end log:# diff <(hexdump -C /var/lib/jenkins/jobs/sync-images-rhel-7v0/builds/25/log.gz.previous) <(hexdump -C /var/lib/jenkins/jobs/sync-images-rhel-7v0/builds/25/log.gz)2800,2801c2800,2805< aef0 07 81 6b fd bf f2 2a 01 00 |..k...*..|< aef9---> aef0 07 81 6b fd bf f2 2a 01 00 5b 42 46 41 5d 20 53 |..k...*..[BFA] S|> af00 63 61 6e 6e 69 6e 67 20 62 75 69 6c 64 20 66 6f |canning build fo|> af10 72 20 6b 6e 6f 77 6e 20 63 61 75 73 65 73 2e 2e |r known causes..|> af20 2e 0a 2e 2e 0a 5b 42 46 41 5d 20 44 6f 6e 65 2e |.[BFA] Done.|> af30 20 32 73 0a | 2s.|> af34This then breaks the displaying of the logs in the sense that every GET results in one core continuously loaded in endless loop."Handling GET /job/sync-images-rhel-7v0/24/console : RequestHandlerThread[#10]" daemon prio=10 tid=0x7f55c400b000 nid=0x3b4e runnable [0x7f56077f8000] java.lang.Thread.State: RUNNABLEat org.kohsuke.stapler.framework.io.LargeText$GzipAwareSession.skip(LargeText.java:437)at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:211)at hudson.console.AnnotatedLargeText.writeHtmlTo(AnnotatedLargeText.java:156)at hudson.model.Run.writeLogTo(Run.java:1351)at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)at java.lang.reflect.Method.invoke(Method.java:606)at org.apache.commons.jexl.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:258)at org.apache.commons.jexl.parser.ASTMethod.execute(ASTMethod.java:104)at org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83)at org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57)at org.apache.commons.jexl.parser.ASTReferenceExpression.value(ASTReferenceExpression.java:51)at org.apache.commons.jexl.ExpressionImpl.evaluate(ExpressionImpl.java:80)at hudson.ExpressionFactory2$JexlExpression.evaluate(ExpressionFactory2.java:74)at org.apache.commons.jelly.parser.EscapingExpression.evaluate(EscapingExpression.java:24)at org.apache.commons.jelly.impl.ExpressionScript.run(ExpressionScript.java:66)at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:161)at org.apache.commons.jelly.tags.core.WhitespaceTag.doTag(WhitespaceTag.java:48)at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269)at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)at org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:99)at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:161)at org.apache.commons.jelly.tags.core.OtherwiseTag.doTag(OtherwiseTag.java:41)at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269)at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:161)at org.apache.commons.jelly.tags.core.ChooseTag.doTag(ChooseTag.java:38)at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269)at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)at org.kohsuke.stapler.jelly.CallTagLibScript$1.run(CallTagLibScript.java:99)at org.apache.commons.jelly.tags.define.InvokeBodyTag.doTag(InvokeBodyTag.java:91)at org.apache.commons.jelly.impl.TagScript.ru
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner updated JENKINS-24171 BFA is blindly adding text to gzipped log Change By: Jaroslav Henner (08/Aug/14 10:59 AM) Component/s: core Component/s: logging This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner updated JENKINS-24171 BFA is blindly adding text to gzipped log Change By: Jaroslav Henner (08/Aug/14 10:57 AM) Component/s: logging This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [build-failure-analyzer] (JENKINS-24171) BFA is blindly adding text to gzipped log
Jaroslav Henner created JENKINS-24171 BFA is blindly adding text to gzipped log Issue Type: Bug Affects Versions: current Assignee: Tomas Westling Components: build-failure-analyzer Created: 08/Aug/14 10:50 AM Description: Jenkins has ability to diplay gunzip gzipped logs on the fly (https://issues.jenkins-ci.org/browse/JENKINS-2551) but it doesn't natively compress the logs. The BFA doesn't expect that and appends the plaintext to the log: diff <(hexdump -C /var/lib/jenkins/jobs/sync-images-rhel-7v0/builds/25/log.gz.previous) <(hexdump -C /var/lib/jenkins/jobs/sync-images-rhel-7v0/builds/25/log.gz) 2800,2801c2800,2805 < aef0 07 81 6b fd bf f2 2a 01 00 |..k...*..| < aef9 — > aef0 07 81 6b fd bf f2 2a 01 00 5b 42 46 41 5d 20 53 |..k...*..[BFA] S| > af00 63 61 6e 6e 69 6e 67 20 62 75 69 6c 64 20 66 6f |canning build fo| > af10 72 20 6b 6e 6f 77 6e 20 63 61 75 73 65 73 2e 2e |r known causes..| > af20 2e 0a 2e 2e 0a 5b 42 46 41 5d 20 44 6f 6e 65 2e |.[BFA] Done.| > af30 20 32 73 0a | 2s.| > af34 This then breaks the displaying of the logs in the sense that every GET results in one core continuously loaded in endless loop. "Handling GET /job/sync-images-rhel-7v0/24/console : RequestHandlerThread10" daemon prio=10 tid=0x7f55c400b000 nid=0x3b4e runnable [0x7f56077f8000] java.lang.Thread.State: RUNNABLE at org.kohsuke.stapler.framework.io.LargeText$GzipAwareSession.skip(LargeText.java:437) at org.kohsuke.stapler.framework.io.LargeText.writeLogTo(LargeText.java:211) at hudson.console.AnnotatedLargeText.writeHtmlTo(AnnotatedLargeText.java:156) at hudson.model.Run.writeLogTo(Run.java:1351) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.commons.jexl.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:258) at org.apache.commons.jexl.parser.ASTMethod.execute(ASTMethod.java:104) at org.apache.commons.jexl.parser.ASTReference.execute(ASTReference.java:83) at org.apache.commons.jexl.parser.ASTReference.value(ASTReference.java:57) at org.apache.commons.jexl.parser.ASTReferenceExpression.value(ASTReferenceExpression.java:51) at org.apache.commons.jexl.ExpressionImpl.evaluate(ExpressionImpl.java:80) at hudson.ExpressionFactory2$JexlExpression.evaluate(ExpressionFactory2.java:74) at org.apache.commons.jelly.parser.EscapingExpression.evaluate(EscapingExpression.java:24) at org.apache.commons.jelly.impl.ExpressionScript.run(ExpressionScript.java:66) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:161) at org.apache.commons.jelly.tags.core.WhitespaceTag.doTag(WhitespaceTag.java:48) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) at org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:99) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:161) at org.apache.commons.jelly.tags.core.OtherwiseTag.doTag(OtherwiseTag.java:41) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269) at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95) at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:161) at org.apache.commons.jelly.tags.core.ChooseTag.doTag(ChooseTag.java:38) at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:269) at org.apache.comm
