[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
Martin dAnjou commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Asking "Are you sure" tells nothing to the user about the consequences. Instead, these kinds of confirmation boxes should tell the user what will happen and what to expect before asking the user if they are sure. Telling the use "it's expensive" is not informative either. Telling the use "you will lose all in-flight builds and all pending builds" is informative. I have "by accident" reloaded configuration from disk, and I would have liked to known the consequences (they were bad). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
Martin dAnjou edited a comment on JENKINS-15340 Add Are you sure on Reload configuration from disk Asking "Are you sure" tells nothing to the user about the consequences. Instead, these kinds of confirmation boxes should tell the user what will happen and what to expect before asking the user if they are sure. Telling the use "it's expensive" is not informative either. Telling the user "you will lose all in-flight builds and all pending builds" is informative. I have "by accident" reloaded configuration from disk, and I would have liked to know the consequences (they were bad). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
Daniel Beck commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Martin: Recent Jenkins versions (1.507+) are considered to no longer lose information on running builds when reloading, see JENKINS-3265. This warning (now) exists primarily to prevent accidental reloads that make the Jenkins UI unavailable for several minutes (especially with larger instances). I experienced some build data loss in combination with 'Cloudbees Restart Aborted Builds Plugin' (Jenkins Enterprise) but without that plugin, have repeatedly and successfully reloaded configuration from disk without losing in-progress build information. If you're on a recent Jenkins version and lost data, you should probably file a new issue and provide more information about your environment. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
SCM/JIRA link daemon commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/ManagementLink.java core/src/main/java/jenkins/management/ReloadLink.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java core/src/main/resources/jenkins/model/Jenkins/manage.jelly core/src/main/resources/jenkins/model/Jenkins/manage.properties core/src/main/resources/lib/layout/breadcrumbs.js core/src/main/resources/lib/layout/confirmationLink.jelly core/src/main/resources/lib/layout/task.jelly http://jenkins-ci.org/commit/jenkins/e3f905fa5347e3265a9919fd8112902ed53d9fd9 Log: FIXED JENKINS-15340 Ask for confirmation before reloading config from disk, as it may be expensive. First of all, /reload should require POST (also prevents XSS DoS attacks). Adding l:confirmationLink to encapsulate a link that requires confirmation upon clicking. Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown. Enhancing l:task to support confirmation as well, and honoring this in context menu items.(cherry picked from commit 9eb69772a505890a9767375b7c2a78e278895ef9) Conflicts: changelog.html This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
SCM/JIRA link daemon commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/model/ManagementLinkTest.java http://jenkins-ci.org/commit/jenkins/d7f7a4a7df01a7b3b57c27a095cc70496476a817 Log: JENKINS-15340 Do not try to click on links with onclick attributes as these require confirmation.(cherry picked from commit e1f070bbef425fcbc9376eb99190a9b7bf3c4e5e) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
SCM/JIRA link daemon resolved JENKINS-15340 as Fixed Add Are you sure on Reload configuration from disk Change By: SCM/JIRA link daemon (10/Apr/13 3:30 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
SCM/JIRA link daemon commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/ManagementLink.java core/src/main/java/jenkins/management/ReloadLink.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java core/src/main/resources/jenkins/model/Jenkins/manage.jelly core/src/main/resources/jenkins/model/Jenkins/manage.properties core/src/main/resources/lib/layout/breadcrumbs.js core/src/main/resources/lib/layout/confirmationLink.jelly core/src/main/resources/lib/layout/task.jelly http://jenkins-ci.org/commit/jenkins/9eb69772a505890a9767375b7c2a78e278895ef9 Log: FIXED JENKINS-15340 Ask for confirmation before reloading config from disk, as it may be expensive. First of all, /reload should require POST (also prevents XSS DoS attacks). Adding l:confirmationLink to encapsulate a link that requires confirmation upon clicking. Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown. Enhancing l:task to support confirmation as well, and honoring this in context menu items. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
SCM/JIRA link daemon commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Code changed in jenkins User: Jesse Glick Path: test/src/test/java/hudson/model/ManagementLinkTest.java http://jenkins-ci.org/commit/jenkins/e1f070bbef425fcbc9376eb99190a9b7bf3c4e5e Log: JENKINS-15340 Do not try to click on links with onclick attributes as these require confirmation. Compare: https://github.com/jenkinsci/jenkins/compare/9eb69772a505...e1f070bbef42 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-15340) Add 'Are you sure' on Reload configuration from disk
dogfood commented on JENKINS-15340 Add Are you sure on Reload configuration from disk Integrated in jenkins_main_trunk #2450 JENKINS-15340 Do not try to click on links with onclick attributes as these require confirmation. (Revision e1f070bbef425fcbc9376eb99190a9b7bf3c4e5e) Result = UNSTABLE Jesse Glick : e1f070bbef425fcbc9376eb99190a9b7bf3c4e5e Files : test/src/test/java/hudson/model/ManagementLinkTest.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
