[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Baptiste Mathus commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Caused JENKINS-23096 too seems like. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Ulli Hafner commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Caused JENKINS-24436. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Daniel Beck updated JENKINS-19310 Incorrect links in build history when view is defined inside a folder Change By: Daniel Beck (08/Aug/14 11:50 PM) Labels: 1.554.x-rejectedfolders lts-candidate This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Daniel Beck updated JENKINS-19310 Incorrect links in build history when view is defined inside a folder Change By: Daniel Beck (30/Jun/14 6:48 PM) Labels: 1.554.x-rejected folders This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
dogfood commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Integrated in jenkins_main_trunk #3451 JENKINS-19310 Unreproducible failure of DirectlyModifiableViewTest.failWebMethodForIllegalRequest, probably from a StackOverflowError. (Revision 3170a1bc153bc12c68d0ac90ae5b701e2c9ec81d) Result = SUCCESS Jesse Glick : 3170a1bc153bc12c68d0ac90ae5b701e2c9ec81d Files : core/src/main/java/hudson/model/AbstractItem.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
SCM/JIRA link daemon commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/AbstractItem.java http://jenkins-ci.org/commit/jenkins/3170a1bc153bc12c68d0ac90ae5b701e2c9ec81d Log: JENKINS-19310 Unreproducible failure of DirectlyModifiableViewTest.failWebMethodForIllegalRequest, probably from a StackOverflowError. at … at hudson.model.View.toString(View.java:514) at java.text.MessageFormat.subformat(MessageFormat.java:1246) at java.text.MessageFormat.format(MessageFormat.java:836) at java.text.Format.format(Format.java:140) at java.text.MessageFormat.format(MessageFormat.java:812) at java.util.logging.Formatter.formatMessage(Formatter.java:130) at java.util.logging.SimpleFormatter.format(SimpleFormatter.java:63) at java.util.logging.StreamHandler.publish(StreamHandler.java:179) at java.util.logging.ConsoleHandler.publish(ConsoleHandler.java:88) at java.util.logging.Logger.log(Logger.java:481) at java.util.logging.Logger.doLog(Logger.java:503) at java.util.logging.Logger.log(Logger.java:567) at hudson.model.AbstractItem.getUrl(AbstractItem.java:423) at hudson.model.View.getViewUrl(View.java:510) at hudson.model.View.toString(View.java:514) at … This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Daniel Beck edited a comment on JENKINS-19310 Incorrect links in build history when view is defined inside a folder (outdated) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
SCM/JIRA link daemon commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/ListView.java core/src/main/resources/hudson/model/View/builds.jelly test/src/test/java/jenkins/widgets/BuildListTableTest.java http://jenkins-ci.org/commit/jenkins/00ab6012b8607b5290aa0bf88fc2f55c5cd36caa Log: JENKINS-19310 Reproduced problem in test. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
dogfood commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Integrated in jenkins_main_trunk #3447 JENKINS-19310 Reproduced problem in test. (Revision 00ab6012b8607b5290aa0bf88fc2f55c5cd36caa) Result = SUCCESS Jesse Glick : 00ab6012b8607b5290aa0bf88fc2f55c5cd36caa Files : test/src/test/java/jenkins/widgets/BuildListTableTest.java core/src/main/resources/hudson/model/View/builds.jelly core/src/main/java/hudson/model/ListView.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Jesse Glick updated JENKINS-19310 Incorrect links in build history when view is defined inside a folder Fix is too risky to be an LTS candidate. Change By: Jesse Glick (09/Jun/14 7:32 PM) Labels: folders lts-candidate This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
SCM/JIRA link daemon
commented on JENKINS-19310
Incorrect links in build history when view is defined inside a folder
Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/model/AbstractItem.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/java/jenkins/util/ProgressiveRendering.java
core/src/main/resources/hudson/model/Computer/builds.jelly
core/src/main/resources/hudson/model/User/builds.jelly
core/src/main/resources/hudson/model/View/builds.jelly
core/src/main/resources/lib/hudson/buildListTable.jelly
test/src/test/java/hudson/model/MyViewTest.java
test/src/test/java/jenkins/widgets/BuildListTableTest.java
http://jenkins-ci.org/commit/jenkins/ea95434938b2111d8768528823990a78bdc58d3e
Log:
FIXED JENKINS-19310 Provide correct links for build history inside a folder.
The basic fix is to use ${rootURL} plus full model object URLs rather than relying on ${jobBaseUrl}.
This is made trickier by the fact that the model object URLs are computed inside ProgressiveRendering.compute,
and therefore will not be correct when nondefault views are in the crumb trail unless the original request information is present.
So modifying ProgressiveRendering to preserve a copy of the original request for use during computation.
(This could probably be used to simplify parts of AsynchPeople as well.)
Also improving AbstractItem.getUrl to properly construct a URL including views even when the current page is not inside the item;
it should suffice for some ancestor of the current item (or a view thereof) to be in the ancestor list of this page.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
SCM/JIRA link daemon resolved JENKINS-19310 as Fixed Incorrect links in build history when view is defined inside a folder Change By: SCM/JIRA link daemon (09/Jun/14 10:13 PM) Status: InProgress Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Jesse Glick assigned JENKINS-19310 to Jesse Glick Incorrect links in build history when view is defined inside a folder Change By: Jesse Glick (09/Jun/14 4:49 PM) Assignee: JesseGlick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Jesse Glick started work on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Change By: Jesse Glick (09/Jun/14 4:49 PM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Jesse Glick commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Could fix use of jobBaseUrl in projectView.jelly and various column.jelly, but those are not used here anyway. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
dogfood commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder Integrated in jenkins_main_trunk #3450 FIXED JENKINS-19310 Provide correct links for build history inside a folder. (Revision ea95434938b2111d8768528823990a78bdc58d3e) Result = UNSTABLE Jesse Glick : ea95434938b2111d8768528823990a78bdc58d3e Files : core/src/main/resources/lib/hudson/buildListTable.jelly core/src/main/resources/hudson/model/Computer/builds.jelly test/src/test/java/jenkins/widgets/BuildListTableTest.java core/src/main/java/jenkins/util/ProgressiveRendering.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/View/builds.jelly core/src/main/resources/hudson/model/User/builds.jelly core/src/main/java/hudson/model/AbstractItem.java changelog.html test/src/test/java/hudson/model/MyViewTest.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-19310) Incorrect links in build history when view is defined inside a folder
Jesse Glick commented on JENKINS-19310 Incorrect links in build history when view is defined inside a folder jobBaseURL is just too fragile and probably needs to go away. BuildListTable should instead produce absolute URLs. It could be given a View ancestor so that it could check whether a job is a member of the given view, and if so, link to it via that view. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
