[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/9620057a58dc07b52752683a433e200f36d4317d Log: When a server error is caught by applyErrorMessage (“ERROR” link), do not render the whole oops.jelly page. Just pick out the div id="error-description" from JENKINS-20772. Compare: https://github.com/jenkinsci/jenkins/compare/7ddc6be48716...9620057a58dc This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Daniel Beck commented on JENKINS-20772 Apply error screens dont work This wasn't backported completely to the 1.532.2 RC. My improvements are missing, so the error dialog cannot be scrolled and shows an entire Jenkins page with header, sidebar, and everything. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Jesse Glick commented on JENKINS-20772 Apply error screens dont work Right, but the most critical fix—showing something in the error dialog—was backported. I think we can live with that, unless the lack of scrolling is making it impossible to see error details. (See https://github.com/jglick/jenkins/compare/printStackTrace-JDK-6507809 for another angle on this.) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Descriptor.java http://jenkins-ci.org/commit/jenkins/5d192634bb968190cb75cb752ed97474c57dc938 Log: _javascript_ error when showing a FormException after Apply is clicked. Related to JENKINS-20772 but probably not the same. (cherry picked from commit 9f23c0bdb3a3ed6485e161ff5c57ebba64f88035) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: http://jenkins-ci.org/commit/jenkins/de78db8d6ba0a4ca1b4b839ab9606cd151d446be Log: JENKINS-17401 JENKINS-20772 Noting. (cherry picked from commit c7dcb99290548f82b39846f4db431ab2ceb326ae) Conflicts: changelog.html Compare: https://github.com/jenkinsci/jenkins/compare/9144cec099bf...de78db8d6ba0 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/eec3d65cdf865bcd19edae15d0ca6e581553db78 Log: FIXED JENKINS-20772 Properly render response in case Apply results in an error page. (cherry picked from commit 0e8195c43d744b65e46ce5d66262e29fbdb9fb35) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Jesse Glick commented on JENKINS-20772 Apply error screens dont work By the way the actual exception in this case is fixed in the 4.2 release of the Templates plugin. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Jesse Glick assigned JENKINS-20772 to Kohsuke Kawaguchi Apply error screens dont work Change By: Jesse Glick (23/Dec/13 5:48 PM) Assignee: StevenChristou KohsukeKawaguchi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Jesse Glick commented on JENKINS-20772 Apply error screens dont work The originally reported issue is actually a bug in the Templates plugin, and very similar to JENKINS-17401. Jenkins is sending a redirect and the Apply handler does not expect this. The fix is just to send a warning in that case, not a redirect. The more general issue is that if an exception is actually thrown, you get a blank error dialog. This is trivially reproduced (in Chrome at least) by configuring a freestyle project, checking Build periodically, and typing some junk into the Schedule field. In apply.js, the error-handling code using responseDialog is triggered, but it does not work. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Jesse Glick commented on JENKINS-20772 Apply error screens dont work Commenting out $(containerId).appendChild(target); fixes the problem to the extent that the error is shown in a new browser window. But then regular Apply button handling is broken. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Jesse Glick started work on JENKINS-20772 Apply error screens dont work Change By: Jesse Glick (23/Dec/13 6:21 PM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Descriptor.java http://jenkins-ci.org/commit/jenkins/9f23c0bdb3a3ed6485e161ff5c57ebba64f88035 Log: _javascript_ error when showing a FormException after Apply is clicked. Related to JENKINS-20772 but probably not the same. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/c7dcb99290548f82b39846f4db431ab2ceb326ae Log: JENKINS-17401 JENKINS-20772 Noting. Compare: https://github.com/jenkinsci/jenkins/compare/833c42326863...c7dcb9929054 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon resolved JENKINS-20772 as Fixed Apply error screens dont work Change By: SCM/JIRA link daemon (23/Dec/13 7:33 PM) Status: InProgress Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
dogfood commented on JENKINS-20772 Apply error screens dont work Integrated in jenkins_main_trunk #3133 _javascript_ error when showing a FormException after Apply is clicked. Related to JENKINS-20772 but probably not the same. (Revision 9f23c0bdb3a3ed6485e161ff5c57ebba64f88035) FIXED JENKINS-20772 Properly render response in case Apply results in an error page. (Revision 0e8195c43d744b65e46ce5d66262e29fbdb9fb35) JENKINS-17401 JENKINS-20772 Noting. (Revision c7dcb99290548f82b39846f4db431ab2ceb326ae) Result = SUCCESS Jesse Glick : 9f23c0bdb3a3ed6485e161ff5c57ebba64f88035 Files : core/src/main/java/hudson/model/Descriptor.java Jesse Glick : 0e8195c43d744b65e46ce5d66262e29fbdb9fb35 Files : core/src/main/resources/lib/form/apply/apply.js Jesse Glick : c7dcb99290548f82b39846f4db431ab2ceb326ae Files : changelog.html This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/jenkins/model/Jenkins/oops.jelly core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/f8a73006e955a15ac8491301f8d2f0a6e8e4e17c Log: Merge pull request #1076 from daniel-beck/better-apply-dialog JENKINS-20772 Only show error message in dialog Compare: https://github.com/jenkinsci/jenkins/compare/28e403ac055f...f8a73006e955 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/jenkins/model/Jenkins/oops.jelly core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/b856cc2434b33ed7fec3492223e141747369bba3 Log: JENKINS-20772 Only show error message in dialog This change removes the superfluous UI elements around the error message if possible. Otherwise, fall back to existing behavior of adding entire page to iframe. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/9b947ae8a239023482b8dcdec97d37425c42be8c Log: JENKINS-20772 Fix scrolling This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
SCM/JIRA link daemon commented on JENKINS-20772 Apply error screens dont work Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/lib/form/apply/apply.js http://jenkins-ci.org/commit/jenkins/e292366f62e511323442a03abdcf020396cbc407 Log: Merge pull request #1077 from daniel-beck/better-apply-dialog JENKINS-20772 Fix scrolling Compare: https://github.com/jenkinsci/jenkins/compare/f2e2cbeca421...e292366f62e5 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Daniel Beck created JENKINS-20772 Apply error screens dont work Issue Type: Bug Assignee: Unassigned Components: core Created: 26/Nov/13 3:00 PM Description: The error screens shown for invalid configurations after pressing 'Apply' don't work. Steps to reproduce: 1. Create a freestyle job with a unique, valid name 3. Clear the name in the config screen 4. Press 'Apply' Expected result: Error message shown Actual result: Huge, empty dialog with title 'Error' shown (error screen seems to appear, but is immediately removed) Environment: Jenkins 1.509.4 Jenkins 1.532.1 RC1 Firefox 17.0.10 ESR Project: Jenkins Labels: lts-candidate Priority: Major Reporter: Daniel Beck This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Daniel Beck commented on JENKINS-20772 Apply error screens dont work There are several issues about the errors that (don't) appear in response to some action (JENKINS-17401, JENKINS-13287, JENKINS-19037, possibly others) but none seem to cover the problem that the error screen is completely useless because it doesn't show the error (e.g. stacktrace). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Steven Christou commented on JENKINS-20772 Apply error screens dont work This is also an issue if you rename it to anything other than the original namen and click the apply button. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Steven Christou assigned JENKINS-20772 to Steven Christou Apply error screens dont work Change By: Steven Christou (26/Nov/13 9:21 PM) Assignee: StevenChristou This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-20772) 'Apply' error screens don't work
Daniel Beck updated JENKINS-20772 Apply error screens dont work My apologies for the badly selected example. I tried to make it easy to reproduce, and failed to test what happens when pressing Save instead. Note that this is not about the exception with stacktrace presented when saving, but the fact that the dialog is completely useless as an error dialog. Change By: Daniel Beck (26/Nov/13 9:27 PM) Description: TheerrorscreensshownforinvalidconfigurationsafterpressingApplydontwork.Stepstoreproduce: 0.InstallJenkinsEnterprisewithCloudbeesTemplatePlugin4. 1 1 .Createa freestyle job withaunique,validname template 3.Clearthe name intheconfigscreen attributesIDfield 4.PressApplyExpectedresult:ErrormessageshownActualresult:Huge,emptydialogwithtitleErrorshown(errorscreenseemstoappear,butisimmediatelyremoved) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
