[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
Hugo Ares commented on JENKINS-21768 @QueryParameter with doFillxyxItems is broken Robert is ok with bumping gerrit-trigger to Jenkins 1.509 so I will close this issue since the bug is in 1.480 and there is nothing to fix. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
Hugo Ares resolved JENKINS-21768 as Not A Defect @QueryParameter with doFillxyxItems is broken Change By: Hugo Ares (13/Feb/14 7:38 PM) Status: Open Resolved Resolution: Not A Defect This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
Hugo Ares commented on JENKINS-21768 @QueryParameter with doFillxyxItems is broken You are right, the only reason I wanted to support 1.480 is because the gerrit-trigger is compiled against it. I already discussed with Robert Sandell(maintainer) to compile it against 1.509(ore more recent) but he is not ready yet to deploy latest LTS in their production environment. I will try again to see if we could release version 2.12.0 of gerrit-trigger with a dependency on jenkins 1.509 as you suggest. Otherwise, you gave me an idea, I could enable this feature only if running in a jenkins version of 1.509 and above. Thanks Hugo This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
stephenconnolly commented on JENKINS-21768 @QueryParameter with doFillxyxItems is broken well 1.509 is getting quite old. Perhaps you could drop support for versions older than 1.509? Currently, based on Jan 2014's stats of Jenkins installations 55% are 1.532+ 80% are 1.509+ 90% are 1.480+ 93% are 1.466+ 97% are 1.447+ 99% are 1.424+ Given that this seems to be a bug in older versions of Jenkins (i.e. where they were finding the wrong form element and ignoring the relative path) I think pushing a final release that requires 1.480 followed by pushing a release that requires 1.509 and has the fix is the way I would tackle this issue. An additional data point is that the oldest version of Jenkins that you can get commercial support for is, as far as I know, based off of 1.509... This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
Hugo Ares
commented on JENKINS-21768
@QueryParameter with doFillxyxItems is broken
Thanks for your input.
I changed the form to use field attribute instead of name/value attributes and the problem is the same:
In 1.480, it's working by using only the @QueryParameter("name").
In 1.509 and above: it's not working with only @QueryParameter("name"). It's working using combination of @QueryParameter("name") and @RelativePath("../..") but this is not working in 1.480.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
stephenconnolly
commented on JENKINS-21768
@QueryParameter with doFillxyxItems is broken
I actually think it is a problem with your form.
You are nesting things, so that the drop down is at a deeper level than the required field.
If you fix up the form structure so that you don't need to use the name and value attributes but can instead rely on the field attribute to do the right thing then you should end up with a cross-version fix
Note that a fixed up form will probably require a relative path, eg
@QueryParameter("../name")
The number of ../ that you need will fall out of the nesting structure
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
Hugo Ares commented on JENKINS-21768 @QueryParameter with doFillxyxItems is broken This commit is changing the behavior of the select to be executed after the rowset name/nameRef fixup(which has priority set to 43) by setting its priority to 1000. I tested by setting different priority to the select behavior and I get the javascritpt error as soon as I put the select behavior priority right after the name/nameRef one. I did not create a pull request because I would have ended up reverting kk's commit. I do not know how to fix this issue without reintroducing the problem that this commit was fixing. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [core] (JENKINS-21768) @QueryParameter with doFillxyxItems is broken
Hugo Ares
created JENKINS-21768
@QueryParameter with doFillxyxItems is broken
Issue Type:
Bug
Assignee:
Unassigned
Components:
core
Created:
11/Feb/14 7:24 PM
Description:
In the gerrit-trigger plugin, we have a Describable. In the form, there is a select that gets populated using the doFillDefaultSlaveIdItems method but it requires the name of server so I used @QueryParameter("name"). I tested this new section against jenkins 1.480.3 since the plugin is compiling against that version and it works fine.
When I tested against the latest lts (1.532.1) the serverName parameter of the doFillDefaultSlaveIdItems is always null. In the _javascript_ console, there is the following error:
"Unable to find nearby name" in hudson-behavior.js.
I isolated that the problem was introduced by this commit(1.526):
commit bbaeade5231ca4116047fbd32b2f909a16a59b8d
Author: Kohsuke Kawaguchi
Date: Tue Jul 16 12:30:14 2013 -0700
this needs to happen at least after the rowset name/nameRef fixup happens.
Since I don't think any other scripts depend on this one, I'm just giving it a low enough priority.
The code is not in the gerrit-trigger master yet so but let me know if you need it, I could push it to my fork.
Here is a sample of its jelly file:
"post" action="" class="code-quote">"configSubmit" name="config">
...
"${%Name}">
"name" value="${it.name}"/>
...
"${%Replication Events}">
"enableReplication" title="${%Enable Triggering On Replication}" checked="${it.config.replicationConfig.enableReplication}">
...
"enableSlaveSelectionInJobs" title="${%Allow Slave Selection in Job Configurations}" checked="${it.config.replicationConfig.enableSlaveSelectionInJobs}">
"${%Choose a default slave}" field="defaultSlaveId">
Here the method defined in the Descriptor:
public ListBoxModel doFillDefaultSlaveIdItems(@QueryParameter("name") final String serverName) {
ListBoxModel items = new ListBoxModel();
...
}
Project:
Jenkins
Labels:
regression
Priority:
Major
Reporter:
Hugo Ares
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
