[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-04-13 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Code changed in jenkins
User: Stephen Connolly
Path:
 core/src/main/java/hudson/PluginManager.java
http://jenkins-ci.org/commit/jenkins/94fd5977d651412b08dd5398737b286e3d50e81b
Log:
  [FIXED JENKINS-22080] NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

(cherry picked from commit f9b0f348d0ff674fe058eb1aa4d609c6e3e962e5)





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-04-13 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Code changed in jenkins
User: Stephen Connolly
Path:
 core/src/main/java/hudson/PluginManager.java
http://jenkins-ci.org/commit/jenkins/18e5415478ee0d037ef36ecf7040d8004cd41c0a
Log:
  [FIXED JENKINS-22080] Braindead logic in author of original fix... corrected by same author

(cherry picked from commit 483181c0a1a0fdb1cb435164d8a8bbfd76084016)





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread dogf...@java.net (JIRA)














































dogfood
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Integrated in  jenkins_main_trunk #3209
 [FIXED JENKINS-22080] NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name (Revision f9b0f348d0ff674fe058eb1aa4d609c6e3e962e5)
[FIXED JENKINS-22080] Braindead logic in author of original fix... corrected by same author (Revision 483181c0a1a0fdb1cb435164d8a8bbfd76084016)

 Result = SUCCESS
Stephen Connolly : f9b0f348d0ff674fe058eb1aa4d609c6e3e962e5
Files : 

	core/src/main/java/hudson/PluginManager.java



Stephen Connolly : 483181c0a1a0fdb1cb435164d8a8bbfd76084016
Files : 

	core/src/main/java/hudson/PluginManager.java





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Code changed in jenkins
User: Stephen Connolly
Path:
 core/src/main/java/hudson/PluginManager.java
http://jenkins-ci.org/commit/jenkins/5a6cf8ec047435867ee18269058a5d9e08ca3d1e
Log:
  Merge pull request #1151 from stephenc/master

[FIXED JENKINS-22080] Braindead logic in author of original fix... corre...


Compare: https://github.com/jenkinsci/jenkins/compare/067acbf6979f...5a6cf8ec0474




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Code changed in jenkins
User: Stephen Connolly
Path:
 core/src/main/java/hudson/PluginManager.java
http://jenkins-ci.org/commit/jenkins/483181c0a1a0fdb1cb435164d8a8bbfd76084016
Log:
  [FIXED JENKINS-22080] Braindead logic in author of original fix... corrected by same author





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Code changed in jenkins
User: Stephen Connolly
Path:
 core/src/main/java/hudson/PluginManager.java
http://jenkins-ci.org/commit/jenkins/067acbf6979fb57dbafdfe66aeb471d4d4875c2f
Log:
  Merge pull request #1150 from stephenc/master

[FIXED JENKINS-22080] NPE if trying to install a plugin from the update ...


Compare: https://github.com/jenkinsci/jenkins/compare/21016fcbefda...067acbf6979f




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Code changed in jenkins
User: Stephen Connolly
Path:
 core/src/main/java/hudson/PluginManager.java
http://jenkins-ci.org/commit/jenkins/f9b0f348d0ff674fe058eb1aa4d609c6e3e962e5
Log:
  [FIXED JENKINS-22080] NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-22080 as Fixed


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name
















Change By:


SCM/JIRA link daemon
(07/Mar/14 3:27 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-22080) NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name

2014-03-07 Thread stephenconno...@java.net (JIRA)














































stephenconnolly
 created  JENKINS-22080


NPE if trying to install a plugin from the update center and either the update source or the plugin contains a '.' in its name















Issue Type:


Bug



Assignee:


Unassigned


Components:


core



Created:


07/Mar/14 9:42 AM



Description:


There is an implicit assumption in the code that neither plugin names nor update center ids contain a period. See https://github.com/jenkinsci/jenkins/blob/jenkins-1.553/core/src/main/java/hudson/PluginManager.java#L687

Sample stack trace:

Status Code: 500
Exception: java.lang.NullPointerException
Stacktrace:

javax.servlet.ServletException: java.lang.NullPointerException
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:735)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:799)
	at org.kohsuke.stapler.MetaClass$3.doDispatch(MetaClass.java:173)
	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:685)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:799)
	at org.kohsuke.stapler.Stapler.invoke(Stapler.java:587)
	at org.kohsuke.stapler.Stapler.service(Stapler.java:218)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:95)
	at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:208)
	at net.bull.javamelody.MonitoringFilter.doFilter(MonitoringFilter.java:181)
	at net.bull.javamelody.PluginMonitoringFilter.doFilter(PluginMonitoringFilter.java:86)
	at org.jvnet.hudson.plugins.monitoring.HudsonMonitoringFilter.doFilter(HudsonMonitoringFilter.java:84)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:98)
	at com.cloudbees.jenkins.support.SupportMetricsFilter.doFilter(SupportMetricsFilter.java:80)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:98)
	at hudson.plugins.greenballs.GreenBallFilter.doFilter(GreenBallFilter.java:58)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:98)
	at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:98)
	at org.jenkinsci.plugins.suppress_stack_trace.SuppressionFilter.doFilter(SuppressionFilter.java:33)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:98)
	at com.cloudbees.jenkins.ha.HAHealthCheckFilter.doFilter(HAHealthCheckFilter.java:44)
	at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:98)
	at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:87)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:48)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
	at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:124)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.u