[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-26 Thread dshvedche...@gmail.com (JIRA)














































Denis Shvedchenko
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Hi, I've found that some plugin ( config-file-provider ) , starts suffering from similar trouble ( rendering icons by \jenkins\core\src\main\resources\lib\layout\layout.jelly in main-panel-content ). if you can classify it for jenkins issue , or plugin issue, please, it would be nice



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-26 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Denis Shvedchenko: If this occurs in 1.576, we don't care since there was a fix since. If it occurs in 1.577, please file a new issue against core and the plugin it occurs in as components, we'll sort it out. Make sure to use the label "user-experience".



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-25 Thread dogf...@java.net (JIRA)














































dogfood
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Integrated in  jenkins_main_trunk #3646
 FIXED JENKINS-24316 Fixed unknown task icon src path construction (Revision 830a5e7f618a53a4ff3d1cad1127efc5fcc47601)
Readd static resource path for task icons JENKINS-24316 (Revision 5b805fa16e240e3657a7f263eeef11281a393efa)

 Result = SUCCESS
Jesse Glick : 830a5e7f618a53a4ff3d1cad1127efc5fcc47601
Files : 

	test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
	test/src/test/java/lib/layout/IconTest.java
	core/src/main/resources/lib/layout/task.jelly
	test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly



Jesse Glick : 5b805fa16e240e3657a7f263eeef11281a393efa
Files : 

	core/src/main/resources/lib/layout/task.jelly





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread tom.fenne...@gmail.com (JIRA)














































Tom FENNELLY
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















@Denis Duh... you are totally right.  Sorry about that.  That just goes to prove that it's not a good idea making changes late at night... better to rest the brain   Thanks for covering me Denis !!!  I'll fix it ASAP.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Code changed in jenkins
User: tfennelly
Path:
 core/src/main/resources/lib/layout/task.jelly
http://jenkins-ci.org/commit/jenkins/3daa6a97b02635d672e7646e83edb93abf50db06
Log:
  Readd static resource path for task icons JENKINS-24316

Missed this in previous commit - bad idea making even small changes late at night 





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread xghostkill...@gmx.net (JIRA)














































Tim Brust
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Looks good at my Jenkins again 
Thanks for the quick fix.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread dogf...@java.net (JIRA)














































dogfood
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Integrated in  jenkins_main_trunk #3638
 Readd static resource path for task icons JENKINS-24316 (Revision 3daa6a97b02635d672e7646e83edb93abf50db06)

 Result = SUCCESS
tom.fennelly : 3daa6a97b02635d672e7646e83edb93abf50db06
Files : 

	core/src/main/resources/lib/layout/task.jelly





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread oldel...@java.net (JIRA)














































Richard Mortimer
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Tested with latest git and the images are now properly displayed including the /static/ prefix to help with caching.

Thanks.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread shannonck...@gmail.com (JIRA)














































Shannon Kerr
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















I can confirm the same.  My sandbox Jenkins is now functioning normally.  Thanks for the quick fix implementation Tom FENNELLY.  We all succumb to late night work bugs every once in a while. 



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread theta...@java.net (JIRA)














































thetaphi
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Hi,
replaced my WAR from the Ubuntu/Debian package in /usr/share/jenkins by the latest snapshot build - works fine!
Thanks!



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Code changed in jenkins
User: tfennelly
Path:
 core/src/main/resources/lib/layout/task.jelly
 test/src/test/java/lib/layout/IconTest.java
 test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly
 test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
http://jenkins-ci.org/commit/jenkins/830a5e7f618a53a4ff3d1cad1127efc5fcc47601
Log:
  FIXED JENKINS-24316 Fixed unknown task icon src path construction

(cherry picked from commit 286337ea39c0db6e056af61e616736bafc5f0581)





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Code changed in jenkins
User: tfennelly
Path:
 core/src/main/resources/lib/layout/task.jelly
http://jenkins-ci.org/commit/jenkins/5b805fa16e240e3657a7f263eeef11281a393efa
Log:
  Readd static resource path for task icons JENKINS-24316

Missed this in previous commit - bad idea making even small changes late at night 

(cherry picked from commit 3daa6a97b02635d672e7646e83edb93abf50db06)


Compare: https://github.com/jenkinsci/jenkins/compare/bce92ec53dde...5b805fa16e24




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Code changed in jenkins
User: Daniel Beck
Path:
 changelog.html
http://jenkins-ci.org/commit/jenkins/4c0cfe40c9ebbea81bf2b8a6931cda3513be1bfe
Log:
  Noting RC merge of JENKINS-24316, JENKINS-24317





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-21 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















The fix will be in 1.577, scheduled to be released this weekend or so.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread xghostkill...@gmx.net (JIRA)














































Tim Brust
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Same issue here!
Hope this gets fixed soon



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread joncrookesi...@gmail.com (JIRA)














































Jonathan Crooke
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Seeing this for plugins myself, as well

http://i.imgur.com/wkTMPEA.png



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread joncrookesi...@gmail.com (JIRA)












































 
Jonathan Crooke
 edited a comment on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Seeing this for plugins myself, as well. 1.576 on OS X 10.9.4

http://i.imgur.com/wkTMPEA.png



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread theta...@java.net (JIRA)














































thetaphi
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















This is not only visually annoying: At least Google Chrome does not respond to clicking links in the UI. You always have to click on browser's "Stop" button and then click on build's liks like "Artifacts", "Console". I think the reason for this behavior is maybe some _javascript_ onbly executed after the whole page loaded.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread lava...@gmail.com (JIRA)














































Taylor Mansfield
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Got this same issue. I actually had ALL of my images stop working, then I reinstalled Jenkins (via apt-get) and now only the plugin images are not working. Although it seems that the Cloudbees Folder Plugin's "move" icon works just fine.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread tom.fenne...@gmail.com (JIRA)














































Tom FENNELLY
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Ah ok sorry guys... I'll get this fixed ASAP.  Thanks for the pointers Daniel.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread dshvedche...@gmail.com (JIRA)














































Denis Shvedchenko
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















If it will help:

When contextPath is not empty urls looks like /jenkins//plugin/jobConfigHistory/img/confighistory.png ( it just fools browsers )
but url should look like : /jenkins/static/c582a0ff/plugin/jobConfigHistory/img/confighistory.png

for some reason plugins icons path is not striped from leading slash and is ignored by task.jelly

  j:set var="icon" value="${rootURL}${icon.startsWith('images/') || icon.startsWith('plugin/') ? h.resourcePath : ''}/${icon}"/



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Code changed in jenkins
User: tfennelly
Path:
 core/src/main/resources/lib/layout/task.jelly
 test/src/test/java/lib/layout/IconTest.java
 test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly
 test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
http://jenkins-ci.org/commit/jenkins/286337ea39c0db6e056af61e616736bafc5f0581
Log:
  FIXED JENKINS-24316 Fixed unknown task icon src path construction





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-24316 as Fixed


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Change By:


SCM/JIRA link daemon
(20/Aug/14 11:12 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread dogf...@java.net (JIRA)














































dogfood
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Integrated in  jenkins_main_trunk #3637
 FIXED JENKINS-24316 Fixed unknown task icon src path construction (Revision 286337ea39c0db6e056af61e616736bafc5f0581)

 Result = SUCCESS
tom.fennelly : 286337ea39c0db6e056af61e616736bafc5f0581
Files : 

	test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
	core/src/main/resources/lib/layout/task.jelly
	test/src/test/java/lib/layout/IconTest.java
	test/src/test/resources/lib/layout/IconTest/01_testIcons.jelly





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-20 Thread dshvedche...@gmail.com (JIRA)














































Denis Shvedchenko
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















with last commit for task.jelly

  j:if test="${!icon.startsWith('/')}"
j:set var="icon" value="/${icon}"/
  /j:if
  j:set var="icon" value="${rootURL}${icon.startsWith('images/') || icon.startsWith('plugin/') ? h.resourcePath : ''}${icon}"/

icon always will startsWith / , and h.resourcePath will not be inserted in icon path. may be last row should look like ???

  j:set var="icon" value="${rootURL}${icon.startsWith('/images/') || icon.startsWith('/plugin/') ? h.resourcePath : ''}${icon}"/



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread theta...@java.net (JIRA)














































thetaphi
 created  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Issue Type:


Bug



Affects Versions:


current



Assignee:


Unassigned


Components:


core, ui-changes



Created:


19/Aug/14 9:39 AM



Description:


Since the update to 1.576, the icons generated by plugins on the left navigation bar no longer display. This is throughout the whole userinterface: homepage, job page,... (everywhere).

The reason is that the image src URL is generated as "//plugin/...", which makes the browser resolve "plugin" as hostname. URLs starting with "//" mean "same protocol".




Project:


Jenkins



Priority:


Major



Reporter:


thetaphi

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread theta...@java.net (JIRA)














































thetaphi
 updated  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Change By:


thetaphi
(19/Aug/14 9:46 AM)




Attachment:


jenkins-screenshot.png



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread shannonck...@gmail.com (JIRA)














































Shannon Kerr
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















I see the same, but after rebooting the host I'm now no longer able to even login to Jenkins (we use AD authentication).  Going to have to roll back to 1.575.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread shannonck...@gmail.com (JIRA)














































Shannon Kerr
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















My login issue is different.  It's because I checked the remember me button at login.  This appears to be a new issue as well.  I'll raise a ticket.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 updated  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Probably was never tested with empty context path...





Change By:


Daniel Beck
(19/Aug/14 2:03 PM)




Assignee:


TomFENNELLY



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Shannon: Did you already report the login issue? I cannot find it.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread shannonck...@gmail.com (JIRA)














































Shannon Kerr
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Daniel, it's Jenkins-24317.  The summary line of that ticket doesn't mention login, but after you read through it you realize that is what they are talking about.  I originally raised ticket Jenkins-24321, but I closed it.  Incidentally, if you can dup it to 24317, I would appreciate it.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Thank you, I wasn't sure as it's also about log output. BTW JIRA creates a link when you use the project name correctly (i.e. allcaps): JENKINS-24317.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread tom.fenne...@gmail.com (JIRA)














































Tom FENNELLY
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















I think this might already be fixed (probably by JENKINS-24181).  I installed these plugins against the latest and the icons appear fine.  I'll attach a screenshot.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread tom.fenne...@gmail.com (JIRA)














































Tom FENNELLY
 updated  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Change By:


Tom FENNELLY
(19/Aug/14 6:37 PM)




Attachment:


Screenshot2014-08-1919.33.40.png



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread oldel...@java.net (JIRA)














































Richard Mortimer
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















I'm running a private build based off of commit 3efe07f563d30a3 (dated 14/August)

Jenkins ver. 1.577-SNAPSHOT (private-08/19/2014 17:48 GMT-laptop)


and still see the problem. I have confirmed and it does include commit 6f87e61ebe6ecd that mentions a fix for JENKINS-24181

I see the problem with both disk-usage-plugin 0.24 and safe-restart-plugin 0.3



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread dan...@beckweb.net (JIRA)














































Daniel Beck
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Tom: Make sure you run as java -jar jenkins.war and not mvn hpi:run to get rid of the context path /jenkins.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread shannonck...@gmail.com (JIRA)












































 
Shannon Kerr
 edited a comment on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Daniel, it's JENKINS-24317.  The summary line of that ticket doesn't mention login, but after you read through it you realize that is what they are talking about.  I originally raised ticket Jenkins-24321, but I closed it.  Incidentally, if you can dup it to 24317, I would appreciate it.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread shannonck...@gmail.com (JIRA)












































 
Shannon Kerr
 edited a comment on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Daniel, it's JENKINS-24317.  The summary line of that ticket doesn't mention login, but after you read through it you realize that is what they are talking about.  I originally raised ticket JENKINS-24321, but I closed it.  Incidentally, if you can dup it to JENKINS-24317, I would appreciate it.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread shannonck...@gmail.com (JIRA)














































Shannon Kerr
 commented on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL















Thanks Daniel Beck.  Will get that right going forward.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-24316) Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL

2014-08-19 Thread dan...@beckweb.net (JIRA)












































 
Daniel Beck
 edited a comment on  JENKINS-24316


Plugin icons do not show in left navigation: duplicate slash before plugin path in image URL
















Tom: Make sure you run as java -jar jenkins.war and not mvn hpi:run to get rid of the context path /jenkins.

Update: I checked, with empty context path, custom images don't show up. I.e. Jenkins at http://localhost:8080/jenkins works correctly, Jenkins at http://localhost:8080 does not.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.