[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-29 Thread dogf...@java.net (JIRA)














































dogfood
 commented on  JENKINS-26201


Unreleased workspace locks after SCM polling















Integrated in  jenkins_main_trunk #3899
 [FIXED JENKINS-26201] Noting 47fa17b, misattributed to an unrelated issue. (Revision 568f906964bb3aaa09d6e7d2fb054256b75262cd)

 Result = UNSTABLE
jesse glick : 568f906964bb3aaa09d6e7d2fb054256b75262cd
Files : 

	changelog.html





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-29 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 updated  JENKINS-26201


Unreleased workspace locks after SCM polling
















Change By:


Jesse Glick
(29/Dec/14 4:56 PM)




Labels:


lock
 lts-candidate
 polling robustness workspace



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-29 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 updated  JENKINS-26201


Unreleased workspace locks after SCM polling
















Change By:


Jesse Glick
(29/Dec/14 4:56 PM)




Description:


A user reports many builds stuck waiting for a lock on the project's primary workspace (not {{@2}}, etc.), which should only be possible if some code has acquired a "quick" lease on the workspace but then failed to ever release it. There are no threads shown holding the workspace lock. Several threads in {{AbstractProject.pollWithWorkspace}} and elsewhere are waiting for it, in some cases for days.https://github.com/jenkinsci/jenkins/blob/jenkins-1.580.1/core/src/main/java/hudson/model/AbstractProject.java#L1442-1445 shows a potential window of vulnerability: if {{getBuiltOn}}, {{createLauncher}}, {{decorateByEnv}}, or {{getEnvironment}} threw an exception, and it went
 reported
 unreported
 or was somehow lost in the logs, the lease could be left locked indefinitely.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-29 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-26201 as Fixed


Unreleased workspace locks after SCM polling
















Change By:


SCM/JIRA link daemon
(29/Dec/14 4:56 PM)




Status:


In Progress
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-29 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-26201


Unreleased workspace locks after SCM polling















Code changed in jenkins
User: Jesse Glick
Path:
 changelog.html
http://jenkins-ci.org/commit/jenkins/568f906964bb3aaa09d6e7d2fb054256b75262cd
Log:
  [FIXED JENKINS-26201] Noting 47fa17b, misattributed to an unrelated issue.





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-22 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 commented on  JENKINS-26201


Unreleased workspace locks after SCM polling















http://repo.jenkins-ci.org/public/org/jenkins-ci/main/jenkins-war/1.580.1.JENKINS-26201-workspace-lock-1/jenkins-war-1.580.1.JENKINS-26201-workspace-lock-1.war may be used to test a backport of this.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-22 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 started work on  JENKINS-26201


Unreleased workspace locks after SCM polling
















Change By:


Jesse Glick
(22/Dec/14 8:05 PM)




Status:


Open
In Progress



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [core] (JENKINS-26201) Unreleased workspace locks after SCM polling

2014-12-22 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 created  JENKINS-26201


Unreleased workspace locks after SCM polling















Issue Type:


Bug



Assignee:


Jesse Glick



Components:


core



Created:


22/Dec/14 8:04 PM



Description:


A user reports many builds stuck waiting for a lock on the project's primary workspace (not @2, etc.), which should only be possible if some code has acquired a "quick" lease on the workspace but then failed to ever release it. There are no threads shown holding the workspace lock. Several threads in AbstractProject.pollWithWorkspace and elsewhere are waiting for it, in some cases for days.

https://github.com/jenkinsci/jenkins/blob/jenkins-1.580.1/core/src/main/java/hudson/model/AbstractProject.java#L1442-1445 shows a potential window of vulnerability: if getBuiltOn, createLauncher, decorateByEnv, or getEnvironment threw an exception, and it went reported or was somehow lost in the logs, the lease could be left locked indefinitely.




Project:


Jenkins



Labels:


workspace
lock
robustness
polling




Priority:


Major



Reporter:


Jesse Glick

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.