[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title James Nord commented on JENKINS-28781 Re: bytecode-compatibility-transformer transforming methods/fields it should not be transforming https://github.com/jenkinsci/bytecode-compatibility-transformer/pull/2 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-28781 bytecode-compatibility-transformer transforming methods/fields it should not be transforming Change By: Tom FENNELLY Inthecasewhereweseethisissue,an[@AdaptFieldannotationonQueue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762]wascausing atransformation transformations in adifferentclass otherclassesnotintendedfortransformation (inourcase,inanelasticsearchclass).TheresultofthistransformationwasaStackMapFrameverifiererror.Sotheremayactuallybe2or3bugsthatneedtobespunoutfromthis:#Thebytecodetransformeristransformingmethods/fieldsthatitshouldnotbetransforming.#Andoneorbothofthefollowing:#*JenkinscoreuseofthebytecodetransformerisnotspecifyingtoupdateStackMapFrameaftertransformations/rewrites.#*bytecodetransformerisnotperformingStackMapFrameupdatesaftertransformations/rewrites. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-28781 bytecode-compatibility-transformer transforming methods/fields it should not be transforming Change By: Tom FENNELLY Inthecasewhereweseethisissue,an[@AdaptFieldannotationonQueue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762]wascausingtransformationsinotherclassesnotintendedfortransformation(inourcase,inanelasticsearchclass).TheresultofthistransformationwasaStackMapFrameverifiererror.Sotheremayactuallybe2or3bugsthatneedtobespunoutfromthis:#Thebytecodetransformeristransformingmethods/fieldsthatitshouldnotbetransforming.#Andoneorbothofthefollowing:#* Jenkinscoreuseofthe bytecode -compatibility- transformer isnotspecifyingtoupdateStackMapFrame doesn'tsupportupdatingofStackMapFrames after transformations/rewrites manipulation .#*bytecode -compatibility- transformer doessupportupdatingofStackMapFramesaftermanipulation,butJenkinscore isnot performingStackMapFrameupdatesaftertransformations/rewrites usingthatproperly . Itdoeslookasthoughbytecode-compatibility-transformerhassomesupportforStackMapFrames. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title Tom FENNELLY updated an issue Jenkins / JENKINS-28781 bytecode-compatibility-transformer transforming methods/fields it should not be transforming Change By: Tom FENNELLY Inthecasewhereweseethisissue,an[@AdaptFieldannotationonQueue.Item|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1753-L1762]wascausingtransformationsinotherclassesnotintendedfortransformation(inourcase,inanelasticsearchclass).TheresultofthistransformationwasaStackMapFrameverifiererror.Sotheremayactuallybe2or3bugsthatneedtobespunoutfromthis:#Thebytecodetransformeristransformingmethods/fieldsthatitshouldnotbetransforming.#Andoneorbothofthefollowing:#*bytecode-compatibility-transformerdoesn't properly supportupdatingofStackMapFramesaftermanipulation.#*bytecode-compatibility-transformerdoessupportupdatingofStackMapFramesaftermanipulation,butJenkinscoreisnotusingthatproperly.Itdoeslookasthoughbytecode-compatibility-transformerhassomesupportforStackMapFrames. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title James Nord assigned an issue to James Nord Jenkins / JENKINS-28781 bytecode-compatibility-transformer transforming methods/fields it should not be transforming Change By: James Nord Assignee: KohsukeKawaguchi JamesNord Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title Tom FENNELLY commented on JENKINS-28781 Re: bytecode-compatibility-transformer transforming methods/fields it should not be transforming Root cause seems to be the same as with JENKINS-19383 i.e. rewriting methods/fields that should not be rewritten. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title James Nord commented on JENKINS-28781 Re: bytecode-compatibility-transformer transforming methods/fields it should not be transforming unfortunately the binaries for this are not available (unreleased version). Caused by: java.lang.VerifyError: Expecting a stackmap frame at branch target 20 Exception Details: Location: org/elasticsearch/common/settings/ImmutableSettings$Builder.get(Ljava/lang/String;)Ljava/lang/String; @15: ifnull Reason: Expected stackmap frame at this location. Bytecode: 0x000: 2ab4 002a 2bb9 003a 0200 c000 354d 2cc6 0x010: 0005 2cb0 2ab4 002a 2bb8 003f b900 3a02 0x020: 00c0 0035 b0 at org.elasticsearch.common.settings.ImmutableSettings.clinit(ImmutableSettings.java:57) at com.cloudbees.opscenter.elasticsearch.embedded.EmbeddedNode.start(EmbeddedNode.java:94) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title James Nord commented on JENKINS-28781 Re: bytecode-compatibility-transformer transforming methods/fields it should not be transforming There are 2 issues that are seemingly at play here. 1) the affected class does not use any of the Jenkins API and should not have been transformed. 2) the transformer is producing a class that is broken. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-28781) bytecode-compatibility-transformer transforming methods/fields it should not be transforming
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-28781 bytecode-compatibility-transformer transforming methods/fields it should not be transforming Issue Type: Bug Assignee: Kohsuke Kawaguchi Components: core Created: 06/Jun/15 9:11 AM Labels: bytecode-compatibility-transformer Priority: Major Reporter: Tom FENNELLY In the case where we see this issue, an @AdaptField annotation on Queue.Item was causing a transformation in a different class (in our case, in an elasticsearch class). The result of this transformation was a StackMapFrame verifier error. So there may actually be 2 or 3 bugs that need to be spun out from this: The bytecode transformer is transforming methods/fields that it should not be transforming. And one or both of the following: Jenkins core use of the bytecode transformer is not specifying to update StackMapFrame after
