[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/ClassicPluginStrategy.java core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/_entryForm.jelly war/src/main/js/api/plugins.js war/src/main/js/pluginSetupWizardGui.js http://jenkins-ci.org/commit/jenkins/449719ca8aaad1a177f81dbb6a35df76ca82d012 Log: Merge pull request #2122 from kzantow/2.0 JENKINS-33296 - plugin dependency issues during install Compare: https://github.com/jenkinsci/jenkins/compare/f4817411c403...449719ca8aaa Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Daniel Beck resolved as Fixed Jenkins / JENKINS-33296 Initial plugin setup needs to consider implied dependencies Change By: Daniel Beck Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Code changed in jenkins User: kzantow Path: core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/_entryForm.jelly war/src/main/js/api/plugins.js war/src/main/js/pluginSetupWizardGui.js http://jenkins-ci.org/commit/jenkins/3edb9fdcecedb4514e4b0396306cb0f115a0b321 Log: JENKINS-33296 - plugin dependency issues during install Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow updated an issue Jenkins / JENKINS-33296 Initial plugin setup needs to consider implied dependencies Change By: Keith Zantow Implied dependencies are not considered at all on the setup dialog. If we think they're so important that we don't allow disabling the plugins when an implied dependent plugin is enabled, we should consider them important enough to install them when such a plugin is installed, no? Otherwise this could result in a giant mess of broken plugins.Assigning to Tom as he wrote the plugin wizard. CC [~kzantow] PR: https://github.com/jenkinsci/jenkins/pull/2122 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow updated an issue Jenkins / JENKINS-33296 Initial plugin setup needs to consider implied dependencies Change By: Keith Zantow Implied dependencies are not considered at all on the setup dialog. If we think they're so important that we don't allow disabling the plugins when an implied dependent plugin is enabled, we should consider them important enough to install them when such a plugin is installed, no? Otherwise this could result in a giant mess of broken plugins.Assigning to Tom as he wrote the plugin wizard. CC [~kzantow] PR: https://github.com/jenkinsci/jenkins/pull/2122 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow started work on JENKINS-33296 Change By: Keith Zantow Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Kohsuke Kawaguchi updated an issue Jenkins / JENKINS-33296 Initial plugin setup needs to consider implied dependencies Change By: Kohsuke Kawaguchi Labels: 2.0 2.0-planned Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Code changed in jenkins User: Daniel Beck Path: war/src/main/js/api/plugins.js http://jenkins-ci.org/commit/jenkins/7f87486c73b1c63cc595c0fc380d42ada45f6116 Log: Temporarily remove plugins affected by JENKINS-33296 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow assigned an issue to Keith Zantow Jenkins / JENKINS-33296 Initial plugin setup needs to consider implied dependencies Change By: Keith Zantow Assignee: Tom FENNELLY Keith Zantow Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Daniel Beck commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Keith Zantow Right, that probably needs to be fed from ClassicPluginStrategy (and may actually require some reworking there if it is currently only available for already installed plugins). Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Daniel Beck ah yes, this is a larger issue: these plugins also don't have the metadata available to the setup wizard (e.g. junit). Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Daniel Beck edited a comment on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Based on this list, LDAP Plugin (core dependency 1.566) should have a dependency on JUnit Plugin (detached 1.577) in the setup dialog (which would be completely bogus, but whatever…), but it does not. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Daniel Beck commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Based on this list, LDAP Plugin (core dependency 1.566) should have a dependency on JUnit Plugin in the setup dialog (which would be completely bogus, but whatever…), but it does not. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title
Daniel Beck commented on JENKINS-33296
Re: Initial plugin setup needs to consider implied dependencies
Keith Zantow Many plugins started out as part of core Jenkins and were later moved into plugins ("detached"). They're automatically added to the classpath of plugins depending on a version of Jenkins when these were still part of core as to not break those plugins.
List of plugins: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/ClassicPluginStrategy.java#L324 Added to dependencies of plugins depending on old cores: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/ClassicPluginStrategy.java#L313..L320
They're not listed in the update site JSON as dependencies, as they're implied. It requires Jenkins core internals (i.e. that list in ClassicPluginStrategy) to determine whether they need to be considered implied dependencies.
The plugin manager UI treats them as actual dependencies, and does not allow disabling e.g. Matrix Project Plugin while at least one plugin depending on core 1.560 or earlier is still enabled. The setup dialog should do the same (or we need to find another solution to this).
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies ... transient dependencies should be installed along with the selected plugins (and they should be visible in the dependency list in the plugin wizard). Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Keith Zantow commented on JENKINS-33296 Re: Initial plugin setup needs to consider implied dependencies Daniel Beck this may just be a display issue; are you referring to transitive dependences or something else? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33296) Initial plugin setup needs to consider implied dependencies
Title: Message Title Daniel Beck created an issue Jenkins / JENKINS-33296 Initial plugin setup needs to consider implied dependencies Issue Type: Bug Assignee: Tom FENNELLY Components: core Created: 03/Mar/16 2:37 PM Labels: 2.0 Priority: Major Reporter: Daniel Beck Implied dependencies are not considered at all on the setup dialog. If we think they're so important that we don't allow disabling the plugins when an implied dependent plugin is enabled, we should consider them important enough to install them when such a plugin is installed, no? Otherwise this could result in a giant mess of broken plugins. Assigning to Tom as he wrote the plugin wizard. CC Keith Zantow Add Comment
