[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33857 Re: Setup wizard password file should end with a newline Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/install/SetupWizard.java http://jenkins-ci.org/commit/jenkins/b633f883477af58be17b83e10c4d7325c2ed9e13 Log: Merge pull request #2201 from orrc/2.0 [FIXED JENKINS-33857] Make initial admin password file end with a newline Compare: https://github.com/jenkinsci/jenkins/compare/6b6ae729a904...b633f883477a Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title SCM/JIRA link daemon commented on JENKINS-33857 Re: Setup wizard password file should end with a newline Code changed in jenkins User: Christopher Orr Path: core/src/main/java/jenkins/install/SetupWizard.java http://jenkins-ci.org/commit/jenkins/3659e9cfaa496c71c7d0152f24740bb33194706f Log: [FIXED JENKINS-33857] Make initial admin password file end with a newline. This makes it a tiny bit more convenient to `cat` the file and copy the password to your clipboard. Previously, the file did not have a line ending, so the password would run into your shell prompt, making copying the text harder. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-33857 Setup wizard password file should end with a newline Change By: SCM/JIRA link daemon Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title Christopher Orr commented on JENKINS-33857 Re: Setup wizard password file should end with a newline Yeah, that looks good. I think it would be nice to include this for 2.0 — it's still a few weeks away, and this small stumbling block happened literally within 30 seconds of starting up the 2.0 beta But you're the release boss! If I get my ICLA accepted soon, I'll at least submit this as a PR, unless someone beats me to it. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title
Daniel Beck commented on JENKINS-33857
Re: Setup wizard password file should end with a newline
I think this should do it?
$ git diff
diff --git a/core/src/main/java/jenkins/install/SetupWizard.java b/core/src/main/java/jenkins/install/SetupWizard.java
index 6c9b53a..7b9a889 100644
--- a/core/src/main/java/jenkins/install/SetupWizard.java
+++ b/core/src/main/java/jenkins/install/SetupWizard.java
@@ -82,7 +82,7 @@ public class SetupWizard {
// JENKINS-33599 - write to a file in the jenkins home directory
// most native packages of Jenkins creates a machine user account 'jenkins' to run Jenkins,
// and use group 'jenkins' for admins. So we allo groups to read this file
-iapf.write(randomUUID, "UTF-8");
+iapf.write(randomUUID + System.lineSeparator(), "UTF-8");
iapf.chmod(0640);
TBH I'd hesitate to include this in 2.0. It's clearly an improvement, clearly not critical… as usual, let's just hold for 2.1 and make that one an overloaded, broken mess of a release.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title Daniel Beck assigned an issue to Daniel Beck Jenkins / JENKINS-33857 Setup wizard password file should end with a newline Change By: Daniel Beck Assignee: Daniel Beck Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33857) Setup wizard password file should end with a newline
Title: Message Title Christopher Orr created an issue Jenkins / JENKINS-33857 Setup wizard password file should end with a newline Issue Type: Improvement Assignee: Unassigned Components: core Created: 2016/Mar/28 10:40 PM Environment: Jenkins 2.0 beta Labels: 2.0-beta Priority: Minor Reporter: Christopher Orr Now that JENKINS-33599 changed the password to be written to a file, it would be more convenient for copy-pasting if the password was printed on its own line — i.e. the file should end with a (platform-specific) newline character. With the 2.0 beta, I saw this: chris@rebigulator:~$ cat /tmp/j2beta/secrets/initialAdminPassword c84b4a5991db49ef9d431159421107bdchris@rebigulator:~$
