[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo edited a comment on JENKINS-33991 Re: If the jobs is parameterized but there are no parameters defined it causes all builds to fail This could be seen as a problem of both Jenkins-core and the parameterized trigger plugin.I am going to submit a pull request for Jenkins-core, and I will also submit a pull request to the parameterized trigger plugin, in order to increase the possibility of fixing the problem (ideally it would require to upgrade both Jenkins AND the Parameterized Trigger Plugin, but upgrading each just one of them will also work solve part of the problem, which is better than nothing ). I will treat the problem on the plugin side on another JIRA issue. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo updated an issue Jenkins / JENKINS-33991 If the jobs is parameterized but there are no parameters defined it causes all builds to fail Change By: André Carmo Jenkins 1.637 introduced a problem related to parameterized builds. This problem has impact in multiple situations, as I am going to describe next.Jenkins 1.637 introduced the "OptionalJobProperty" class. Please see this commit: https://github.com/jenkinsci/jenkins/commit/53c86ec857a49609613ed1871a01830d51a89265*Job configuration*Follow the following steps:* Create a new job "Job1"* Activate the option "This build is parameterized"* Don't add any parameter* Save the job* Get back to the job configurationPrevious to this version, you would see that Jenkins was "smart" enough to understand that it makes no sense to have a parameterized job without parameters, so it wouldn't save this option.After this version, the "This build is parameterized" option is active (and actually saved to the config.xml file) without any parameter. See the attached image "1".The config.xml file contains the following content.{code} {code}*Downstream job trigger " * Follow these steps:* Install the "Parameterized Trigger Plugin"* Add a new job "Job0". Add a downstream job "Job1", and pass the current build parameters.* Trigger "Job0", and wait for it to trigger "Job1"Result* Before Jenkins 1.637, the job triggers with no problems.* After Jenkins 1.637, Job1 won't trigger.This appears in Console Output.{quote}ERROR: Failed to build parameters to trigger project: Job1java.lang.NullPointerException at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.getParameterDefinitionsMap(ProjectSpecificParameterValuesActionTransform.java:47) at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.transformParametersAction(ProjectSpecificParameterValuesActionTransform.java:29) at hudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.getProjectSpecificBuildActions(ProjectSpecificParametersActionFactory.java:32) at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBuildActions(BuildTriggerConfig.java:290) at hudson.plugins.parameterizedtrigger.ParameterizedDependency.shouldTriggerBuild(ParameterizedDependency.java:60) at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:245) at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:684) at hudson.model.Build$BuildExecution.cleanUp(Build.java:200) at hudson.model.Run.execute(Run.java:1785) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:410)Finished: SUCCESS{quote}This is not a major problem because there a workaround.
[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo updated an issue Jenkins / JENKINS-33991 If the jobs is parameterized but there are no parameters defined it causes all builds to fail Change By: André Carmo Jenkins 1.637 introduced a problem related to parameterized builds. This problem has impact in multiple situations, as I am going to describe next.Jenkins 1.637 introduced the "OptionalJobProperty" class. Please see this commit: https://github.com/jenkinsci/jenkins/commit/53c86ec857a49609613ed1871a01830d51a89265*Job configuration*Follow the following steps:* Create a new job "Job1"* Activate the option "This build is parameterized"* Don't add any parameter* Save the job* Get back to the job configurationPrevious to this version, you would see that Jenkins was "smart" enough to understand that it makes no sense to have a parameterized job without parameters, so it wouldn't save this option.After this version, the "This build is parameterized" option is active (and actually saved to the config.xml file) without any parameter. See the attached image "1".The config.xml file contains the following content.{code} {code}*Downstream job trigger*Follow these steps:* Install the "Parameterized Trigger Plugin"* Add a new job "Job0". Add a downstream job "Job1", and pass the current build parameters.* Trigger "Job0", and wait for it to trigger "Job1"Result* Before Jenkins 1.637, the job triggers is triggered with no problems.* After Jenkins 1.637, Job1 won't trigger be triggered .This appears in Console Output.{quote}ERROR: Failed to build parameters to trigger project: Job1java.lang.NullPointerException at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.getParameterDefinitionsMap(ProjectSpecificParameterValuesActionTransform.java:47) at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.transformParametersAction(ProjectSpecificParameterValuesActionTransform.java:29) at hudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.getProjectSpecificBuildActions(ProjectSpecificParametersActionFactory.java:32) at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBuildActions(BuildTriggerConfig.java:290) at hudson.plugins.parameterizedtrigger.ParameterizedDependency.shouldTriggerBuild(ParameterizedDependency.java:60) at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:245) at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:684) at hudson.model.Build$BuildExecution.cleanUp(Build.java:200) at hudson.model.Run.execute(Run.java:1785) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:410)Finished: SUCCESS{quote}This is not a major problem because there a workaround.
[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo updated an issue Jenkins / JENKINS-33991 If the jobs is parameterized but there are no parameters defined it causes all builds to fail Change By: André Carmo Environment: Jenkins 1.637 and above Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo assigned an issue to André Carmo Jenkins / JENKINS-33991 If the jobs is parameterized but there are no parameters defined it causes all builds to fail Change By: André Carmo Assignee: André Carmo Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo commented on JENKINS-33991 Re: If the jobs is parameterized but there are no parameters defined it causes all builds to fail This could be seen as a problem of both Jenkins-core and the parameterized trigger plugin. I am going to submit a pull request for Jenkins-core, and I will also submit a pull request to the parameterized trigger plugin, in order to increase the possibility of fixing the problem (ideally it would require to upgrade both Jenkins AND the Parameterized Trigger Plugin, but upgrading each one of them will also work). I will treat the problem on the plugin side on another JIRA issue. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-33991) If the jobs is parameterized but there are no parameters defined it causes all builds to fail
Title: Message Title André Carmo created an issue Jenkins / JENKINS-33991 If the jobs is parameterized but there are no parameters defined it causes all builds to fail Issue Type: Bug Assignee: Unassigned Attachments: 1.png Components: core Created: 2016/Apr/03 9:42 PM Priority: Minor Reporter: André Carmo Jenkins 1.637 introduced a problem related to parameterized builds. This problem has impact in multiple situations, as I am going to describe next. Jenkins 1.637 introduced the "OptionalJobProperty" class. Please see this commit: https://github.com/jenkinsci/jenkins/commit/53c86ec857a49609613ed1871a01830d51a89265 Job configuration Follow the following steps: Create a new job "Job1" Activate the option "This build is parameterized" Don't add any parameter