[JIRA] [docker-build-step] (JENKINS-23733) Error in saving Jenkins system configuration due to empty Docker REST URL

2014-07-10 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-23733 as Fixed


Error in saving Jenkins system configuration due to empty Docker REST URL
















Change By:


SCM/JIRA link daemon
(10/Jul/14 12:20 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [docker-build-step] (JENKINS-23733) Error in saving Jenkins system configuration due to empty Docker REST URL

2014-07-10 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-23733


Error in saving Jenkins system configuration due to empty Docker REST URL















Code changed in jenkins
User: Vojtech Juranek
Path:
 src/main/java/org/jenkinsci/plugins/dockerbuildstep/DockerBuilder.java
http://jenkins-ci.org/commit/docker-build-step-plugin/a8b40740b6729682cf765b5e4209cfda2cafb144
Log:
  [FIXED JENKINS-23733] Allow user to save global config even if Docker URL is empty





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [docker-build-step] (JENKINS-23733) Error in saving Jenkins system configuration due to empty Docker REST URL

2014-07-10 Thread jkriza...@gmail.com (JIRA)














































Jurica Krizanic
 commented on  JENKINS-23733


Error in saving Jenkins system configuration due to empty Docker REST URL















Probably some of my colleagues installed the plugin in order to use Docker, but hasn't set it up yet.

I've disabled the plugin until Docker and URL are set up, and I am able to save the Jenkins system configuration.

Still, it shouldn't prevent the user from saving the configuration, as you agreed.

Thank you for the your answer.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [docker-build-step] (JENKINS-23733) Error in saving Jenkins system configuration due to empty Docker REST URL

2014-07-10 Thread vjura...@java.net (JIRA)














































vjuranek
 commented on  JENKINS-23733


Error in saving Jenkins system configuration due to empty Docker REST URL















I agree plugin shouldn't disallow you to make and save any changes, I'll remove this check. But still curious what is the use case for empty Docker URL - as the plugin uses only REST API, IMHO you should either setup Docker URL to be able to use it or you don't need this plugin, as it won't work anyway



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [docker-build-step] (JENKINS-23733) Error in saving Jenkins system configuration due to empty Docker REST URL

2014-07-10 Thread jkriza...@gmail.com (JIRA)














































Jurica Krizanic
 created  JENKINS-23733


Error in saving Jenkins system configuration due to empty Docker REST URL















Issue Type:


Bug



Affects Versions:


current



Assignee:


vjuranek



Components:


docker-build-step



Created:


10/Jul/14 8:03 AM



Description:


Hello,
I am trying to save Jenkins system configuration (after changing for example CIFS share or something not related to Docker build step) and getting the message "Docker REST URL cannot be empty".
Current version of docker-build step is 1.6.

I believe the URL should be validated only in case of testing connection towards the provided Docker REST URL.
This type of plugin's implementation prevents any other changes in Jenkins system configuration.




Project:


Jenkins



Labels:


docker
configuration
docker-build-step




Priority:


Major



Reporter:


Jurica Krizanic

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.