[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29851 Re: global instance cap not respected for spot instances Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/EC2Cloud.java http://jenkins-ci.org/commit/ec2-plugin/848fec3b9a473386173a7faabae25ef911d54b36 Log: JENKINS-29851 Global instance cap not calculated for spot instances correctly (fixed NPE) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Francis Upton commented on JENKINS-29851 Re: global instance cap not respected for spot instances s/b resolved in 1.30 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Francis Upton closed an issue as Fixed Jenkins / JENKINS-29851 global instance cap not respected for spot instances Change By: Francis Upton Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29851 Re: global instance cap not respected for spot instances Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/EC2Cloud.java src/main/java/hudson/plugins/ec2/EC2SpotSlave.java src/main/java/hudson/plugins/ec2/SlaveTemplate.java http://jenkins-ci.org/commit/ec2-plugin/f85b37b8f3ace611191c8b3507d03dcbda999a55 Log: JENKINS-29851 Global instance cap not calculated for spot instances correctly JENKINS-32397 Spot instance AMI counting has problems JENKINS-32398 Remove spot instance nodes when requests are canceled Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title James Judd commented on JENKINS-29851 Re: global instance cap not respected for spot instances We have run into this as well. Probably won't have time to look into this before January. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Mohsen K stopped work on JENKINS-29851 Change By: Mohsen K Status: In Progress Open Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Mohsen K started work on JENKINS-29851 Change By: Mohsen K Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Ryan Aslett edited a comment on JENKINS-29851 Re: global instance cap not respected for spot instances I've narrowed this down to what I think are two problems is the problem in countCurrentEC2Slaves:First, it is only looping through the reservations and calling describeInstances : https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/EC2Cloud.java#L232-232This will only count spot requests that have been fulfilled, not pending spot requests as they have not yet become an instance. What is probably needed is a call to describeSpotInstanceRequests() to get the spot instances, and additionally increment n if there are pending spot requests. Either that or there needs to be an entirely separate set of checks for the maximum number of spot requests.We have a cron that can sometimes send as many as 100 jobs at once, and we end up with spikes of 100 machines provisioned even though we set our limit to 20. It would be ideal if we could use spot instances + limits on the number running + pending. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Ryan Aslett commented on JENKINS-29851 Re: global instance cap not respected for spot instances I've narrowed this down to what I think are two problems in countCurrentEC2Slaves: First, it is only looping through the reservations and calling describeInstances : https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/EC2Cloud.java#L232-232 This will only count spot requests that have been fulfilled, not pending spot requests as they have not yet become an instance. What is probably needed is a call to describeSpotInstanceRequests() to get the spot instances, and additionally increment n if there are pending spot requests. Either that or there needs to be an entirely separate set of checks for the maximum number of spot requests. We have a cron that can sometimes send as many as 100 jobs at once, and we end up with spikes of 100 machines provisioned even though we set our limit to 20. It would be ideal if we could use spot instances + limits on the number running + pending. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Archie Brentano updated an issue Jenkins / JENKINS-29851 global instance cap not respected for spot instances Change By: Archie Brentano Priority: Minor Major Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Archie Brentano commented on JENKINS-29851 Re: global instance cap not respected for spot instances I think this is major, since it causes money to be spent. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Ryan Aslett commented on JENKINS-29851 Re: global instance cap not respected for spot instances This keeps biting us. We had global instance cap of 30, and a per cloud cap of 30, as well as cc28xl caps at aws. Turns out that our aws caps only applied to on demand instances, and so did jenkins. i.e. we had 90 machines running at once. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Arien Kock created an issue Jenkins / JENKINS-29851 global instance cap not respected for spot instances Issue Type: Bug Assignee: Francis Upton Attachments: ec2bug.jpg Components: ec2-plugin Created: 07/Aug/15 8:21 AM Environment: Jenkins ver. 1.623 plugin version 1.29 Labels: instance ec2 ec2-plugin aws configuration Priority: Minor Reporter: Arien Kock When the build queue piles up new instances are launched. One per waiting job, it seems. I've attached a screenshot of my configuration. The instance cap per AMI doesn't have any effect either.
[JIRA] [ec2-plugin] (JENKINS-29851) global instance cap not respected for spot instances
Title: Message Title Arien Kock updated an issue Jenkins / JENKINS-29851 global instance cap not respected for spot instances Change By: Arien Kock Whenthebuildqueuepilesupnewinstancesarelaunched.Oneperwaitingjob,itseems.I'veattachedascreenshotofmyconfiguration.TheinstancecapperAMIdoesn'thaveanyeffecteither. IbelievethismayberelatedtospotinstancesnotcomingupwiththeJenkinsslavetags,andsonotbeingcountedcorrectly.Thoughtheglobalcapshouldapplytotheoverallnumberofrunninginstances,no? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
