[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Francis Upton commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. Version 1.33 released with this fix. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Francis Upton commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. OK, done on master. I will release a new version. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/EC2Cloud.java http://jenkins-ci.org/commit/ec2-plugin/f45093e4567290112ca4302e03acacacb50bbc5d Log: JENKINS-34667 Provision attempt is made when possible slaves count is 0. (back out change) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Robert Pilachowski commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. In case I wasn't clear, I suggest removing this change. I ran both test scenarios using the JENKINS-34667 branch, but the code change removed and both scenarios worked correctly. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Robert Pilachowski commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. This code change did not solve the problem. I tested a slight different scenario than above where both AMIs had provisioned slaves to the cap amount, but all were in the stopped state, i.e. no more slaves could be provisioned. When I started several builds spread across both AMIs, none of the slaves restarted. I suspect this happened because provisionSlaveIfPossible ended without trying to start any stopped slaves. When the old version of the check, (possibleSlavesCount < 0), was done, it would still try to start a stopped slave. I believe there is an issue in the logic where provisioning new slaves and starting stopped slaves is treated the same. Instead they should be treated differently and whenever there is a stopped slaves and excess work exists. Or, another option is to have countCurrentEC2Slaves not count stopped slaves. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/EC2Cloud.java http://jenkins-ci.org/commit/ec2-plugin/644500758cd274f14bea1d77bf7222f8b986c8fb Log: JENKINS-34667 Provision attempt is made when possible slaves count is 0. (#197) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Francis Upton closed an issue as Fixed Jenkins / JENKINS-34667 Provision attempt is made when possible slaves count is 0. Change By: Francis Upton Status: In Progress Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Francis Upton commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. Robert Pilachowski I took care of making the PR, if you could give it a test, we will get it in. Thanks for the fix. https://github.com/jenkinsci/ec2-plugin/pull/197 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Francis Upton started work on JENKINS-34667 Change By: Francis Upton Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title SCM/JIRA link daemon commented on JENKINS-34667 Re: Provision attempt is made when possible slaves count is 0. Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/EC2Cloud.java http://jenkins-ci.org/commit/ec2-plugin/1b9188f9fb5178f465c0134772eb4e53c1510d9f Log: JENKINS-34667 Provision attempt is made when possible slaves count is 0. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title
Johnny Shields edited a comment on JENKINS-34667
Re: Provision attempt is made when possible slaves count is 0.
Hi, can you please fork the repo on Github and raise a PR with this fix.{{git clone https://github.com/jenkinsci/ec2-plugincd ec2-pluginmvn install }}Then upload the target/ec2.hpi file to Jenkins to test?
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title
Johnny Shields edited a comment on JENKINS-34667
Re: Provision attempt is made when possible slaves count is 0.
Hi, can you please fork the repo on Github and raise a PR with this fix. {{ git clone https://github.com/jenkinsci/ec2-plugincd ec2-pluginmvn install }} Then upload the target/ec2.hpi file to Jenkins to test?
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title
Johnny Shields commented on JENKINS-34667
Re: Provision attempt is made when possible slaves count is 0.
Hi, can you please fork the repo on Github and raise a PR with this fix.
{{ git clone https://github.com/jenkinsci/ec2-plugin
cd ec2-plugin
mvn install }}
Then upload the target/ec2.hpi file to Jenkins to test?
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title
Johnny Shields edited a comment on JENKINS-34667
Re: Provision attempt is made when possible slaves count is 0.
Hi, can you please fork the repo on Github and raise a PR with this fix.{{ git clone https://github.com/jenkinsci/ec2-plugincd ec2-pluginmvn install}}Then upload the target/ec2.hpi file to Jenkins to test?
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [ec2-plugin] (JENKINS-34667) Provision attempt is made when possible slaves count is 0.
Title: Message Title Robert Pilachowski created an issue Jenkins / JENKINS-34667 Provision attempt is made when possible slaves count is 0. Issue Type: Bug Assignee: Francis Upton Components: ec2-plugin Created: 2016/May/07 7:22 PM Priority: Minor Reporter: Robert Pilachowski We a have setup with multiple AMI that are tag based. Here is the scenario that is causing a problem. Setup: AMI_1 has tag ONE and only runs Jenkins jobs with that tag. This AMI has an instance cap of 1 and the executor count on the slave is 1 as well, meaning there can be at most one Jenkins job with tag ONE running at a time. AMI_2 has no tags and is used as much as possible. It also has an instance cap of 6 and each slave has 4 executors. The overall max cap is 10. Jenkins is currently running one instance of AMI_1 (at cap) and two running instances and 2 stopped instances of AMI_2 (below cap). All executors are active. In the queue there is 1 job waiting for AMI_1 and 6 jobs waiting for AMI_2. Problem: What happens is the plugin tries provision a new slave for AMI_1 but cannot because it is at cap, and then DOES NOT attempt to provision (start) any AMI_2 slaves. I looked through the code and saw the following in EC2Cloud.java: EC2AbstractSlave.java
