[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer resolved JENKINS-17742 as Fixed Pick Up Committer from Upstream Job Available with next release. Change By: Christian Galsterer (31/Jul/14 5:37 AM) Status: InProgress Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: http://jenkins-ci.org/commit/email-ext-plugin/4b19e9bfd1ce3d59975be52fd9287793408a2d1a Log: JENKINS-17742 - Pick Up Committer from Upstream Job I18N for display name src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java http://jenkins-ci.org/commit/email-ext-plugin/b87a57e244752fe1b9ac965f044b39d96d755862 Log: JENKINS-17742 - Pick Up Committer from Upstream Job fixed review comment on display name This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java src/main/resources/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider/help.html http://jenkins-ci.org/commit/email-ext-plugin/f44a742850de3f133124612dd155a924e4115303 Log: JENKINS-17742 - Pick Up Committer from Upstream Job This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java http://jenkins-ci.org/commit/email-ext-plugin/303a15e7fe2da246500cec32623b8b858cdbfe57 Log: JENKINS-17742 - Pick Up Committer from Upstream Job fixed review comments (logging and spacing) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java src/main/resources/hudson/plugins/emailext/Messages.properties http://jenkins-ci.org/commit/email-ext-plugin/dacc3e212cd4c95493b5060c2ae07a4885b7eb81 Log: JENKINS-17742 - Pick Up Committer from Upstream Job I18N for display name This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java http://jenkins-ci.org/commit/email-ext-plugin/56896689098d61a3aa79a1f54dff802f26388ff6 Log: JENKINS-17742 - Pick Up Committer from Upstream Job fixed review comments (logging and spacing) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Christian Galsterer Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java src/main/resources/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider/help.html http://jenkins-ci.org/commit/email-ext-plugin/763ecc19519e6d14b35e0be4150f55d99a028850 Log: JENKINS-17742 - Pick Up Committer from Upstream Job This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
SCM/JIRA link daemon commented on JENKINS-17742 Pick Up Committer from Upstream Job Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider.java src/main/resources/hudson/plugins/emailext/Messages.properties src/main/resources/hudson/plugins/emailext/plugins/recipients/UpstreamComitterRecipientProvider/help.html http://jenkins-ci.org/commit/email-ext-plugin/58f0a1ef125a361fc9045e05c93b1053932dc337 Log: Merge pull request #91 from christiangalsterer/JENKINS-17742 JENKINS-17742 - Pick Up Committer from Upstream Job Compare: https://github.com/jenkinsci/email-ext-plugin/compare/bfaadca29e5b...58f0a1ef125a This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job You could do a pull request for the current plugin, that would be fine. I just don't have time to implement it. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer assigned JENKINS-17742 to Christian Galsterer Pick Up Committer from Upstream Job Change By: Christian Galsterer (25/Jun/14 7:04 AM) Assignee: AlexEarl ChristianGalsterer This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer reopened JENKINS-17742 Pick Up Committer from Upstream Job Change By: Christian Galsterer (25/Jun/14 3:41 PM) Resolution: WontFix Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer started work on JENKINS-17742 Pick Up Committer from Upstream Job Change By: Christian Galsterer (25/Jun/14 3:41 PM) Status: Reopened InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl resolved JENKINS-17742 as Wont Fix Pick Up Committer from Upstream Job This can be implemented by a plugin that implements a RecipientProvider, it will not be implemented in the email-ext plugin. Change By: Alex Earl (15/Jun/14 3:44 AM) Status: Reopened Resolved Resolution: WontFix This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job The RecipientProvider extension point has been released as part of 2.38.1, feel free to implement a plugin that implements a RecipientProvider, or create a new pull request based on the latest code. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl assigned JENKINS-17742 to Alex Earl Pick Up Committer from Upstream Job Change By: Alex Earl (05/Feb/14 3:53 AM) Assignee: ChristianGalsterer AlexEarl This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job The discussion on the pull request has led me to implement a RecipientProvider extension point. This will allow people to implement their own plugins that add functionality. It will be much easier for people to create pull requests with new ways of providing recipients. I hope to get it into the next release. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer reopened JENKINS-17742 Pick Up Committer from Upstream Job Change By: Christian Galsterer (24/Dec/13 8:16 AM) Resolution: WontFix Status: Resolved Reopened Assignee: AlexEarl ChristianGalsterer This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer commented on JENKINS-17742 Pick Up Committer from Upstream Job I implemented a change which is available in pull request https://github.com/jenkinsci/email-ext-plugin/pull/83. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job With the groovy script, each admin has the ability to tailor it to their needs, this is why I am advocating using a script instead of adding a new feature. "Send to Requester" actually sends to the person (if there was a person) that initiated the build. Are you thinking of Culprits or Developers? Culprits does have a similar issue, it will break if you are using a different project type that doesn't have the same layout as other projects (like Build Flow). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Jonathan Brecher commented on JENKINS-17742 Pick Up Committer from Upstream Job We have hundreds of developers maintaining their own Jenkins jobs on a central server. We can reasonably expect them to choose whether to hit a checkbox. We cannot expect them to learn Gradle on top of their other responsibilities. How could it not be a good idea for the plugin to handle this natively? If the plugin handles it natively, with a checkbox as suggested by Christian, then admins have a choice of using the native implementation if it works for them. They also still have the option of using Gradle if they love lots of repeated code in each of their Jenkins jobs. Without native support in the plugin, there are no options. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job Why would they need Gradle? The script is pure Groovy. There are plenty of ways to reduce the need for each person to know Groovy. You can create template jobs (plugin), when new jobs are created you create them based on a template (if you don't want a plugin). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Jonathan Brecher commented on JENKINS-17742 Pick Up Committer from Upstream Job Sorry, I meant Groovy. I've edited my previous comment. I also have a way of reducing the need for each person to know Groovy: Provide a checkbox that offers this functionality natively. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job Feel free to implement it and issue a pull request. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job For instance, more people are using the Build Flow plugin, the Upstream stuff doesn't work the same way with a Build Flow job as it does with a normal job. You have to access it differently. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer commented on JENKINS-17742 Pick Up Committer from Upstream Job But wouldn't this also apply for the groovy script, that one need different ways to retrieve the upstream builds and does this also not apply then to the build in "Send to Requester" feature which calculates the root upstream build using the Jenkins core feature and is not aware of the "Build Flow plugin"? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer edited a comment on JENKINS-17742 Pick Up Committer from Upstream Job I would volunteer to implement this as a native feature of the plugin to keep it consistent with the existing trigger configuration, but just having a simple checkbox to activate this feature. I see the following options with decreasing preference. Option 1: Add a new "Send to Upstream Committers" Main benefit is that it doesn't change existing functionality and is the most flexible one with regards to configuration Option 2: Change behaviour of "Send To Culprits" You can say that when a build is triggered by a SCM change in a upstream build the committer(s) of the upstream build(s) might be the culprit(s). Drawback is that this changes the current behaviour. Option 3: Change behaviour of "Send to Requester" You can say that when a build is triggered by a SCM change in a upstream build the committer(s) of the upstream build(s) might be the requester(s) although only implicitly. Drawback is the same as option 2 that this changes the current behaviour. I have the implementation actually available, so I would like to hear your opinion which option you prefer. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer commented on JENKINS-17742 Pick Up Committer from Upstream Job I would volunteer to implement this as a native feature of the plugin to keep it consistent with the existing trigger configuration, but just having a simple checkbox to activate this feature. I see the following options with decreasing preference. Option 1: Add a new "Send to Upstream Committers" Main benefit is that it doesn't change existing functionality and is the most flexible one with regards to configuration Option 2: Change behaviour of "Send To Culprits" You can say that when a build is triggered by a SCM change in a upstream build the committer(s) of the upstream build(s) might be the culprit(s). Drawback is that this changes the current behaviour. Option 3: Change behaviour of "Send to Requester" You can say that when a build is triggered by a SCM change in a upstream build the committer(s) of the upstream build(s) might be the requester(s) although only implicitly. Drawback is the same as option 2 that this changes the current behaviour. I have the implementation actually available, so I would like to hear your opinion which option you prefer. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer edited a comment on JENKINS-17742 Pick Up Committer from Upstream Job I would volunteer to implement this as a native feature of the plugin to keep it consistent with the existing trigger configuration, by just having a simple checkbox to activate this feature. This might be easier than a groovy script especially together with the configuration slicing plugin and when you have a couple of hundred/thousand builds to manage. I see the following options with decreasing preference. Option 1: Add a new "Send to Upstream Committers" Main benefit is that it doesn't change existing functionality and is the most flexible one with regards to configuration Option 2: Change behaviour of "Send To Culprits" You can say that when a build is triggered by a SCM change in a upstream build the committer(s) of the upstream build(s) might be the culprit(s). Drawback is that this changes the current behaviour. Option 3: Change behaviour of "Send to Requester" You can say that when a build is triggered by a SCM change in a upstream build the committer(s) of the upstream build(s) might be the requester(s) although only implicitly. Drawback is the same as option 2 that this changes the current behaviour. I have the implementation actually available, so I would like to hear your opinion which option you prefer. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl commented on JENKINS-17742 Pick Up Committer from Upstream Job Why have it native in the plugin if you can do it via the script token? There are different types of builds that putting it directly into the plugin could cause problems. With the script method, the person can tailor it to their setup. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer commented on JENKINS-17742 Pick Up Committer from Upstream Job Thanks for the quick feedback. What problems do you see? From an implementation point of view (which Jenkins API calls are made) it is very similar to "Send To Requester". This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Christian Galsterer edited a comment on JENKINS-17742 Pick Up Committer from Upstream Job Thanks for the quick feedback. What problems do you see, maybe I can take them into consideration? From an implementation point of view (which Jenkins API calls are made) it is very similar to "Send To Requester" and would be inline with JENKINS-7740. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl resolved JENKINS-17742 as Wont Fix Pick Up Committer from Upstream Job This can be done now with a SCRIPT content token in the recipients. Change By: Alex Earl (28/Apr/13 4:38 AM) Status: Open Resolved Resolution: WontFix This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Zachary Young created JENKINS-17742 Pick Up Committer from Upstream Job Issue Type: Bug Assignee: Alex Earl Components: email-ext Created: 24/Apr/13 7:39 PM Description: email-ext should be able to pick up the committer of the upstream job that started a build chain: JobA -- JobB -- JobC If JobC fails, email-ext e-mail should be sent to JobA committer. Project: Jenkins Priority: Minor Reporter: Zachary Young This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [email-ext] (JENKINS-17742) Pick Up Committer from Upstream Job
Alex Earl
commented on JENKINS-17742
Pick Up Committer from Upstream Job
You can do this now with a groovy script.
Quoted from the mailing list:
// the goal is to find the top level job which should contain the changelist
def upstreamBuild = null
def cause = build.causes.find {
if(it instanceof hudson.model.Cause.UpstreamCause) {
return true
}
return false
}
while(cause != null) {
upstreamBuild =
hudson.model.Hudson.instance.getItem(cause.upstreamProject).getBuildByNumber(cause.upstreamBuild)
cause = upstreamBuild.causes.find {
return (it instanceof hudson.model.Cause.UpstreamCause);
}
}
Then I check if upstreamBuild is null or not, and if its not, I have
access to its information like this:
def changeSet = upstreamBuild.changeSet
And you can get the info you are looking for from there.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
