[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title Alex Earl resolved as Fixed Migrated several tokens into token macro 1.12 Jenkins / JENKINS-31380 Expose private tokens from email-ext Change By: Alex Earl Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title Kanstantsin Shautsou commented on JENKINS-31380 Re: Expose private tokens from email-ext Seems nothing can be done with this private tokens Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title
Kanstantsin Shautsou edited a comment on JENKINS-31380
Re: Expose private tokens from email-ext
For 2. Need to be checked whether they tied to html generation * {{BuildLogContent}} - no html, just print log lines* {{BUILD_LOG_EXCERPT}} - no html, just print log lines* {{BuildLogMultilineRegexContent}} -- supports html optionally(?)* {{BuildLogRegexContent}} - supports html optionally * {{BuildURLContent}} - generic* {{JobDescriptionContent}} - generic* {{CauseContent}} - generic, but token name {{CAUSE}} potentially bad* {{WorkspaceFileContent}} - looks generic For 3. Not generic tokens :* {{ChangesSinceLast*}} - depends on email-ext (getPreviousBuild probably can be extracted), one named {{CHANGES}}, other {{CHANGES*}}* {{BuildStatusContent}} - depends on email-ext, can't be migrated or exposed ({{BUILD_STATUS}} may overlap)* {{FailedTestsContent}} - depends on {{junit-plugin}}* {{JenkinsURLContent}} - depends on email-ext jenkins url (global/local to publisher)* {{ProjectURLContent}} - depends on ^^* {{ProjectNameContent}} - 2 tokens, overlaps with out of the box {{JOB_NAME}}* {{SVNRevisionContent}} - strange (?)* {{TemplateContent}} - (?)* {{TestCountsContent}} - depends on {{junit-plugin}}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title
Kanstantsin Shautsou edited a comment on JENKINS-31380
Re: Expose private tokens from email-ext
For 2. Need to be checked whether they tied to html generation * {{BuildLogContent}} - no html, just print log lines* {{BUILD_LOG_EXCERPT}} - no html, just print log lines* {{BuildLogMultilineRegexContent}} -- supports html optionally(?)* {{BuildLogRegexContent}} - supports html optionally * {{BuildURLContent}} - generic* {{JobDescriptionContent}} - generic* {{CauseContent}} - generic, but token name {{CAUSE}} potentially bad* {{WorkspaceFileContent}} - looks generic Not generic: * {{ChangesSinceLast*}} - depends on email-ext (getPreviousBuild probably can be extracted), one named {{CHANGES}}, other {{CHANGES*}}* {{BuildStatusContent}} - depends on email-ext, can't be migrated or exposed ({{BUILD_STATUS}} may overlap)* {{FailedTestsContent}} - depends on {{junit-plugin}}* {{JenkinsURLContent}} - depends on email-ext jenkins url (global/local to publisher)* {{ProjectURLContent}} - depends on ^^* {{ProjectNameContent}} - 2 tokens, overlaps with out of the box {{JOB_NAME}}* {{SVNRevisionContent}} - strange (?)* {{TemplateContent}} - (?)* {{TestCountsContent}} - depends on {{junit-plugin}}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title
Kanstantsin Shautsou commented on JENKINS-31380
Re: Expose private tokens from email-ext
For 2. Need to be checked whether they tied to html generation
BuildLogContent - no html, just print log lines
BUILD_LOG_EXCERPT - no html, just print log lines
BuildLogMultilineRegexContent – supports html optionally
BuildLogRegexContent - supports html optionally
BuildURLContent - generic
JobDescriptionContent - generic
CauseContent - generic, but token name CAUSE potentially bad
WorkspaceFileContent - looks generic
ChangesSinceLast* - depends on email-ext (getPreviousBuild probably can be extracted), one named CHANGES, other {{CHANGES*}
BuildStatusContent - depends on email-ext, can't be migrated or exposed (BUILD_STATUS may overlap)
FailedTestsContent - depends on junit-plugin
JenkinsURLContent - depends on email-ext jenkins url (global/local to publisher)
ProjectURLContent - depends on ^^
ProjectNameContent - 2 tokens, overlaps with out of the box JOB_NAME
SVNRevisionContent - strange
TemplateContent -
TestCountsContent - depends on junit-plugin
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title
Kanstantsin Shautsou edited a comment on JENKINS-31380
Re: Expose private tokens from email-ext
For 2. Need to be checked whether they tied to html generation * {{BuildLogContent}} - no html, just print log lines* {{BUILD_LOG_EXCERPT}} - no html, just print log lines* {{BuildLogMultilineRegexContent}} -- supports html optionally(?)* {{BuildLogRegexContent}} - supports html optionally * {{BuildURLContent}} - generic* {{JobDescriptionContent}} - generic* {{CauseContent}} - generic, but token name {{CAUSE}} potentially bad* {{WorkspaceFileContent}} - looks generic* {{ChangesSinceLast*}} - depends on email-ext (getPreviousBuild probably can be extracted), one named {{CHANGES}}, other {{CHANGES*} } * {{BuildStatusContent}} - depends on email-ext, can't be migrated or exposed ({{BUILD_STATUS}} may overlap)* {{FailedTestsContent}} - depends on {{junit-plugin}}* {{JenkinsURLContent}} - depends on email-ext jenkins url (global/local to publisher)* {{ProjectURLContent}} - depends on ^^* {{ProjectNameContent}} - 2 tokens, overlaps with out of the box {{JOB_NAME}}* {{SVNRevisionContent}} - strange (?)* {{TemplateContent}} - (?)* {{TestCountsContent}} - depends on {{junit-plugin}}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title Kanstantsin Shautsou commented on JENKINS-31380 Re: Expose private tokens from email-ext For 1. only 2 tokens can be deleted https://github.com/jenkinsci/email-ext-plugin/pull/110 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title Kanstantsin Shautsou commented on JENKINS-31380 Re: Expose private tokens from email-ext Atm moment i see the next variants: Review private tokens and define whether they can be removed at all, i.e. BUILD_NUMBER seems duplicates existed job variables migrate generic tokens like BUILD_LOG_EXCERPT to token-macro-plugin keep as is some tokens that depends on global Email-Ext hudsonUrl configuration it impossible to make them generic keep as is JELLY_SCRIPT and SCRIPT. Both depends on templates in JENKINS_HOME and SCRIPT is a bad name and may conflict with some cases. So create new GROOVY_SCRIPT token somewhere (even separate plugin because it will depends on config-file-provider?). That should keep backward compatibility, GROOVY_SCRIPT may obsolete SCRIPT (using files in JENKINS_HOME imho is bad design future) and provide other plugins ability to use this tokens without having dependency on email-ext-plugin Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [email-ext-plugin] (JENKINS-31380) Expose private tokens from email-ext
Title: Message Title Kanstantsin Shautsou created an issue Jenkins / JENKINS-31380 Expose private tokens from email-ext Issue Type: Task Assignee: Kanstantsin Shautsou Components: email-ext-plugin, token-macro-plugin Created: 03/Nov/15 11:23 PM Priority: Minor Reporter: Kanstantsin Shautsou In github-pullrequest-plugin i experimentally created content expansion with private email-ext tokens, this functionality looks generic so we want introduce it in https://github.com/jenkinsci/github-plugin/pull/100 but using hack for macros extraction is not good. Many times people mentioned that this tokens should be extracted from email-ext. Add Comment
