[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-06-02 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Code changed in jenkins
User: Nicolas De loof
Path:
 src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
http://jenkins-ci.org/commit/envinject-plugin/e92085799b2d04f34a689e31784b6c5292a60456
Log:
  FIXED JENKINS-19852





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-06-02 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-19852 as Fixed


NPE during submission of EnvInject JobProperty configurations
















Change By:


SCM/JIRA link daemon
(02/Jun/14 10:33 AM)




Status:


Reopened
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-06-02 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Of course the proper fix is to add a dependency on script-security-plugin. The current SECURITY-86 fix is probably circumventable.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-30 Thread recampb...@java.net (JIRA)














































recampbell
 reopened  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations
















Steven, I realizes this "fixes" the NPE, but I wonder if it breaks what Nicolas  was trying to accomplish in 96a52696 in the first place  to prevent users without RUN_SCRIPTS from editing the groovy script.

Note that the groovy script is read-only without the RUN_SCRIPTS permission, but one could trivially edit the HTML to inject whatever groovy they like. So the server side check is still needed.

My point is, I think we need to re-open JENKINS-19852 and let @ndeloof fix the NPE in a way which still prevents editing of the groovy in this case as desired in 96a52696.





Change By:


recampbell
(30/May/14 9:30 PM)




Resolution:


Fixed





Status:


Resolved
Reopened





Assignee:


GregoryBoissinot
NicolasDeLoof



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-20 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Code changed in jenkins
User: Steven Christou
Path:
 src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
http://jenkins-ci.org/commit/envinject-plugin/7d369eb79c6425d0221c9a87dc84c7ee3ed623b6
Log:
  Merge pull request #29 from christ66/JENKINS-19852

FIXED JENKINS-19852 NPE during submission of EnvInject JobProperty con...


Compare: https://github.com/jenkinsci/envinject-plugin/compare/c68558aba602...7d369eb79c64




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-20 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Code changed in jenkins
User: christ66
Path:
 src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
http://jenkins-ci.org/commit/envinject-plugin/d6fbc760d24609490c42f96b2d769f27fb360587
Log:
  FIXED JENKINS-19852 NPE during submission of EnvInject JobProperty configurations





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-20 Thread scm_issue_l...@java.net (JIRA)















































SCM/JIRA link daemon
 resolved  JENKINS-19852 as Fixed


NPE during submission of EnvInject JobProperty configurations
















Change By:


SCM/JIRA link daemon
(20/May/14 11:11 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-19 Thread schris...@cloudbees.com (JIRA)














































Steven Christou
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















See https://github.com/jenkinsci/envinject-plugin/pull/29 for fix.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-19 Thread o.v.nenas...@gmail.com (JIRA)














































Oleg Nenashev
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















@Steven
Thanks. No idea why I have not created the PR on my own 



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-05-19 Thread o.v.nenas...@gmail.com (JIRA)












































 
Oleg Nenashev
 edited a comment on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations
















@Steven
Thanks. No idea why I had not created the PR on my own 



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-04-10 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 updated  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations
















Change By:


Jesse Glick
(10/Apr/14 9:25 PM)




Labels:


exceptionpermissionsregression



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-04-10 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Fix should be trivial (see duplicate for explanation); do you need a PR for it?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-04-10 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Code changed in jenkins
User: Jesse Glick
Path:
 core/src/main/java/hudson/model/ReconfigurableDescribable.java
http://jenkins-ci.org/commit/jenkins/9bf265e5762f1d27e8560b716a25e2dbb031c8fc
Log:
  FindBugs annotations to catch the likes of JENKINS-19852.





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2014-03-26 Thread renu.lax...@gmail.com (JIRA)














































Renu Chudamani
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















I don't have any groovy scripts associated to my job - but still got this error. I enabled the envinject and then when I try to disable I get this null pointer error.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [envinject] (JENKINS-19852) NPE during submission of EnvInject JobProperty configurations

2013-12-11 Thread dilip...@gmail.com (JIRA)














































Dilip M
 commented on  JENKINS-19852


NPE during submission of EnvInject JobProperty configurations















Users with Admin privilege does not get this exception.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.