[JIRA] [ghprb-plugin] (JENKINS-25574) whitelisted users existing PR's are not accepted
Title: Message Title SCM/JIRA link daemon commented on JENKINS-25574 Re: whitelisted users existing PR's are not accepted Code changed in jenkins User: Travis Johnson Path: src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java http://jenkins-ci.org/commit/ghprb-plugin/774662aa8b9f7abbdbb1dd002a7d5e03f9c176b5 Log: JENKINS-25574 accept whitelisted users existing PR's if a user has a PR, then gets whitelisted, the existing PR's are still unaccepted. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-25574) whitelisted users existing PR's are not accepted
Travis Johnson created JENKINS-25574 whitelisted users existing PRs are not accepted Issue Type: Bug Assignee: Honza Brázdil Components: ghprb-plugin Created: 12/Nov/14 4:35 PM Description: If you whitelist a user, any PR's already detected by the plugin do not get accepted and start building. This (I've found) is because the PR's author is only checked against the whitelist upon initial detection of the PR, and never after. I have a PR out that (I believe) fixes this, but I've not written a test for it as I don't have a java setup atm. Should no one else do this I'll eventually do it myself: https://github.com/jenkinsci/ghprb-plugin/pull/60 Environment: Jenkins: 1.580.1 ghprb-plugin: 1.16-5 OS: Ubuntu 12.04.5 Project: Jenkins Priority: Minor Reporter: Travis Johnson This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-25574) whitelisted users existing PR's are not accepted
Travis Johnson updated JENKINS-25574 whitelisted users existing PRs are not accepted Change By: Travis Johnson (12/Nov/14 4:36 PM) Description: Ifyouwhitelistauser,anyPRsalreadydetectedbytheplugindonotgetacceptedandstartbuilding.This(Ivefound)isbecausethePRsauthorisonlycheckedagainstthewhitelistuponinitialdetectionofthePR,andneverafter. IhaveaPRoutthat(Ibelieve)fixesthis,butIvenotwrittenatestforitasIdonthaveajavasetupatm.ShouldnooneelsedothisIlleventuallydoitmyself:https://github.com/jenkinsci/ghprb-plugin/pull/60 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-25574) whitelisted users existing PR's are not accepted
Travis Johnson commented on JENKINS-25574 whitelisted users existing PRs are not accepted I have a PR out that (I believe) fixes this, but I've not written a test for it as I don't have a java setup atm. Should no one else do this I'll eventually do it myself: https://github.com/jenkinsci/ghprb-plugin/pull/60 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
