[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Yoann Dubreuil commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Christopher Orr The fix was rolled back in 1.32.2 and re-introduced in 1.32.3. I updated the wiki page to reflect this. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Yoann Dubreuil made that edit — maybe he can give some info as to why, since no details were added to the wiki. Both 1.32.1 and 1.32.2 have worked fine for me, and a couple of further releases have been made since then. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Arnaud Héritier commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170 is saying that this fix is removed in 1.32.2 ? thus the issue should be reopened ? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr closed an issue as Fixed Fixed in 1.32.1 of the plugin. Jenkins / JENKINS-34762 PR status cannot be updated due to filtered parameters Change By: Christopher Orr Status: In Progress Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Wolfgang Schnerring commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Christopher Orr Sorry about my brevity, but unfortunately I really don't have much more to tell: The job is a "normal" job, no matrix or anything The job has a parameter named sha1 (as recommended by https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin if one occasionally wants to build manually), with a default value of "fill-me-in" From the console output I see that the sha1 Parameter is not filled in by v1.32.1 to the commit hash of the PR, but rather the default value is left in, which then causes the job execution to fail because it is not a valid git commit name v1.29.4 however fills the parameter, and everything works just fine (if safeParameters is set accordingly) I cannot find anything relevant in the jenkins log file How can I give you better diagnostic information? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Wolfgang Schnerring: Are you able to provide any details other than it "does not work"? What do you see in the logs? Does this happen for all ghprb parameters? What type of job are you using? If it's a matrix job, then that's also broken and doesn't provide parameters at the moment: https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Wolfgang Schnerring commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters The -Dhudson.model.ParametersAction.safeParameters workaround works for me, however the new plugin version 1.32.1 does not work for me, it does not substitute the sha1-parameter in the job. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Andrey Miroshnichenko commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters ...changed the command - moved the parameter before -jar happens: /usr/bin/java -XX:PermSize=256m -XX:MaxPermSize=256m -verbose:gc -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=8081 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dhudson.model.ParametersAction.keepUndefinedParameters=true -jar /usr/share/jenkins/jenkins.war --webroot=/var/cache/jenkins/war --httpPort=-1 --ajp13Port=-1 --httpsPort=8083 --httpsCertificate=/data/jenkins/ssl_certs/dev_com.crt --httpsPrivateKey=/data/jenkins/ssl_certs/dev_com.key Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title
Andrey Miroshnichenko edited a comment on JENKINS-34762
Re: PR status cannot be updated due to filtered parameters
Ok, seems like the advice provided in the article does not work for my Jenkins 2.5. I see the same:{code}May 19, 2016 2:51:13 AM hudson.model.ParametersAction filterWARNING: Skipped parameter `ghprbGhRepository` as it is undefined on `Arena-platform-pull-request-checker`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters`=true to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach{code}in my log even when specified {{-Dhudson.model.ParametersAction.keepUndefinedParameters=true}}Jenkins was spawned with:{code}/usr/bin/java -XX:PermSize=256m -XX:MaxPermSize=256m -verbose:gc -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=8081 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -jar /usr/share/jenkins/jenkins.war --webroot=/var/cache/jenkins/war --httpPort=-1 --ajp13Port=-1 --httpsPort=8083 --httpsCertificate=/data/jenkins/ssl_certs/ cashdev_gsngames_com dev_com .crt --httpsPrivateKey=/data/jenkins/ssl_certs/ cashdev_gsngames_com dev_com .key -Dhudson.model.ParametersAction.keepUndefinedParameters=true{code}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Andrey Miroshnichenko commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Ok, seems like the advice provided in the article does not work for my Jenkins 2.5. I see the same: May 19, 2016 2:51:13 AM hudson.model.ParametersAction filter WARNING: Skipped parameter `ghprbGhRepository` as it is undefined on `Arena-platform-pull-request-checker`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters`=true to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach in my log even when specified -Dhudson.model.ParametersAction.keepUndefinedParameters=true Jenkins was spawned with: /usr/bin/java -XX:PermSize=256m -XX:MaxPermSize=256m -verbose:gc -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=8081 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -jar /usr/share/jenkins/jenkins.war --webroot=/var/cache/jenkins/war --httpPort=-1 --ajp13Port=-1 --httpsPort=8083 --httpsCertificate=/data/jenkins/ssl_certs/cashdev_gsngames_com.crt --httpsPrivateKey=/data/jenkins/ssl_certs/cashdev_gsngames_com.key -Dhudson.model.ParametersAction.keepUndefinedParameters=true Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Andrey Miroshnichenko commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters This article describes the idea how to bypass the problem. My list of the vars was: ghprbActualCommit,ghprbActualCommitAuthor,ghprbActualCommitAuthorEmail,ghprbAuthorRepoGitUrl,ghprbCommentBody,ghprbCredentialsId,ghprbGhRepository,ghprbPullAuthorEmail,ghprbPullAuthorLogin,ghprbPullAuthorLoginMention,ghprbPullDescription,ghprbPullId,ghprbPullLink,ghprbPullLongDescription,ghprbPullTitle,ghprbSourceBranch,ghprbTargetBranch,ghprbTriggerAuthor,ghprbTriggerAuthorEmail,ghprbTriggerAuthorLogin,ghprbTriggerAuthorLoginMention Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr started work on JENKINS-34762 Change By: Christopher Orr Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters There is a PR in progress to fix this (not from me): https://github.com/jenkinsci/ghprb-plugin/pull/336 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Margaret Leber commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters I've been able to do a quick circumvention this for our PRs by simply adding a sha1 parameter to the affected job. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Nicholas Brown commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters https://github.com/nemccarthy/stash-pullrequest-builder-plugin/issues/84 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr updated an issue Jenkins / JENKINS-34762 PR status cannot be updated due to filtered parameters Change By: Christopher Orr Labels: security-170 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Nicholas Brown: If you use that plugin, and you're seeing issues due to the fix for SECURITY-170, could you please file a new bug for that? Also adding it to the wiki page of affected plugins would be helpful. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Nicholas Brown commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters I'd guess that https://github.com/jenkinsci/stash-pullrequest-builder-plugin may have the same problem as it appears define extra parameters in a similar way. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Nick Walke commented on JENKINS-34762 Re: PR status cannot be updated due to filtered parameters Just ran into this. Thanks for finding the cause. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [ghprb-plugin] (JENKINS-34762) PR status cannot be updated due to filtered parameters
Title: Message Title Christopher Orr created an issue Jenkins / JENKINS-34762 PR status cannot be updated due to filtered parameters Issue Type: Bug Assignee: Honza Brázdil Components: ghprb-plugin Created: 2016/May/12 10:46 AM Priority: Critical Reporter: Christopher Orr The fix for SECURITY-170 as described in this blog post means that Jenkins core filters out any parameters used that were not defined in the job: https://jenkins.io/blog/2016/05/11/security-update/ Since GHPRB defines lots of parameters at runtime, and then later tries to access them, a bunch of functionality in the plugin fails. For example, at the end of a PR build, the plugin tries to read the PR ID so that it can update it on GitHub — but because the ghprbPullId parameter gets filtered out, the plugin fails to determine the PR ID. May 12, 2016 12:35:13 PM hudson.model.ParametersAction filter WARNING: Skipped parameter `ghprbPullId ` as it is undefined on `pr-test-job`. Set `-Dhudson.model.ParametersAction.keepUndefinedParameters`=true to allow undefined parameters to be injected as environment variables or `-Dhudson.model.ParametersAction.safeParameters=[comma-separated list]` to whitelist specific parameter names, even though it represents a security breach May 12, 2016 12:35:13 PM hudson.model.listeners.RunListener report WARNING: RunListener failed java.lang.NumberFormatException: null at java.lang.Integer.parseInt(Integer.java:542) at java.lang.Integer.parseInt(Integer.java:615)
