[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
SCM/JIRA link daemon commented on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher Code changed in jenkins User: Daniel Figus Path: src/main/java/hudson/plugins/git/GitPublisher.java src/main/java/hudson/plugins/git/GitSCM.java src/test/java/hudson/plugins/git/GitPublisherTest.java http://jenkins-ci.org/commit/git-plugin/f841caf3c2483532aad9feb20d2f3fac9722a878 Log: JENKINS-24786 Environment variables are not expanded in git publisher Fix: Git publisher fails if remote repository configuration contains environment variables This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Mark Waite resolved JENKINS-24786 as Fixed Since 2.2.6, environment variables are not expanded in git publisher The change from Daniel Figus has been rebased into the git plugin main line and will be available in git plugin 2.3.3 and later. Change By: Mark Waite (23/Dec/14 2:23 PM) Status: InProgress Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Daniel Figus commented on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher Created pull request 283 containing fix and tests. The updated git-plugin runs in our production jenkins without issues. Could you please review and provide feedback? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Daniel Figus commented on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher Hi Mark, I also ran into the issue and had a look into the code. I try to summarize what I already found out - I hope this helps: As the fetch is working I focused on analyzing the differences between the fetch and the push. As far as I understood the code the GitSCM holds the remote repository without expanded environment variables and expands them right before the fetch (https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitSCM.java#L915). This step is is missing in the GitPublisher where the specified remote repository is retrieved from the gitSCM (https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitPublisher.java#L318). As this issue is urgent for our production I already started to prepare a test and fix for this issue. My naive approach would be simply do the same thing as GitSCM.getParamExpandedRepos() does right where the push command is created and executed. But as you wrote that you hit a wall here I'm a bit unconfident. Could you please share your concerns? I would need some more days to prepare a fix for a pull request but so far my first tests looked promising. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Mark Waite commented on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher Daniel Figus Your approach sounds promising. I hit a wall when I couldn't construct a set of tests which gave me enough confidence that I'd solved the problem without critically damaging something else. Since you're a directly involved user, you'll be able to test drive your changes in your own environment. A pull request from you will then allow me and/or Nicolas (or others) to review your changes in depth. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Carlos Alexandre commented on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher Hey there Mark, Any news on this issue? Today I updated to the latest 2.3 version..i was forced to rollback once again due to this issue :/ One thing I noted is that the GitPublisher only fails to expand a variable that is used in the Repository Url. If you use it on any other field, such as GitTag name or something similar, everything works as expected. Jenkins Core: 1.580.2 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Carlos Alexandre edited a comment on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher Hey there Mark, Any news on this issue? Today I updated to the latest 2.3 version..i was forced to rollback once again due to this issue :/ One thing I noted is that the GitPublisher only fails to expand a variable that is used in the Repository Url. If you use it on any other field, such as GitTag name or something similar, everything works as expected. Jenkins Core: 1.580.2 Git Plugin version: 2.3.x This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [git-plugin] (JENKINS-24786) Since 2.2.6, environment variables are not expanded in git publisher
Mark Waite commented on JENKINS-24786 Since 2.2.6, environment variables are not expanded in git publisher I have hit a wall on the fix. My attempts to find a way to retain the other fixes included in 2.2.6 and fix this bug have failed. I'd love to have other eyes on the code, or alternative ways to implement the 2.2.6 fix which introduced the problem. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
