[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Fixed in release 0.21. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske resolved as Fixed Latest release fixes it. Jenkins / JENKINS-21331 GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Change By: Sam Gleske Status: Reopened Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title SCM/JIRA link daemon commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Code changed in jenkins User: Julien Carsique Path: pom.xml src/main/java/org/jenkinsci/plugins/GithubAuthenticationToken.java src/main/java/org/jenkinsci/plugins/GithubOAuthGroupDetails.java src/main/java/org/jenkinsci/plugins/GithubOAuthUserDetails.java src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java http://jenkins-ci.org/commit/github-oauth-plugin/7fea11475da28861ddf1f1e09add6a93a1bbfc6a Log: JENKINS-21331: include teams as groups duplicate: JENKINS-28575 Conflicts: src/main/java/org/jenkinsci/plugins/GithubAuthenticationToken.java src/main/java/org/jenkinsci/plugins/GithubSecurityRealm.java Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Sorry, that was a mistake. I must have misread. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske reopened an issue Jenkins / JENKINS-21331 GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Change By: Sam Gleske Resolution: Duplicate Status: Closed Reopened Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Julien Carsique commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Sam Gleske you've closed both issues ( JENKINS-21331 and JENKINS-28575 ) as duplicate. The pull request (https://github.com/jenkinsci/github-oauth-plugin/pull/36) is not yet merged. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske closed an issue as Duplicate Jenkins / JENKINS-21331 GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Change By: Sam Gleske Status: Open Closed Assignee: Sam Kottler Gleske Resolution: Duplicate Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske edited a comment on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Yes, I'm okay with using * instead if that's the case. What I originally meant is in the UI the user types org/team but the backend translates that to %2F. But for now * simplifies the issue I think. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Yes, I'm okay with using * instead if that's the case. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Julien Carsique commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin PR updated with the right JIRA ref on the last commit. I tested "%2F" and it does not work: auto-completion on group definition waits for "%2F" which is ugly. I guess "*" is fine even if "/" would be better. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Julien Carsique commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Amending, yes of course. I'll do it today. Browsing issues in URL referencing a group, like "jenkins/externalGroups/Org/Team" displayed in "jenkins/groups" (I'm using the Role Based Access Control Plugin - http://jenkins-enterprise.cloudbees.com/docs/user-guide-docs/rbac.html). Of course it works with "jenkins/externalGroups/Org*Team". I'm giving a try with "%2F" you suggested but I expect automated translations leading to the breaking slash in URL... we'll see. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin I think amending the commit messages to include JENKINS-21331 instead would be a good idea. If "/" is not technically an option then I guess I'm okay with it. Can you elaborate on "browsing issues"? Perhaps there's a workaround to the issues you encountered if I learned more. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title
Julien Carsique edited a comment on JENKINS-21331
Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
As explained in JENKINS-28575:{quote}Your suggestion is exactly what I've done in the pull-request, except that I couldn't use the slash ("/") as a separator between Org and Team: that generates browsing issues on Jenkins side. So I choose to use an asterisk ("*" ; see https://github.com/jcarsique/github-oauth-plugin/commit/74f0e9eecea5f3777e7935d9e7c762f4f5f51b70#diff-8524b26b72d1d1cd6ddf1048e92b23a1R19 ): any character filtered out by GitHub would be convenient.{quote} Do you want me to resubmit https://github.com/jenkinsci/github-oauth-plugin/pull/36 with the right JIRA issue?With or without the first "format & cleanup" commit ( https://github.com/jcarsique/github-oauth-plugin/commit/a310a6f0690b17d72f193827ae8f84f1ba7960da )?I'm using the suggested PR for two weeks in my company, with no issue.Note this can be seen as a major security fix since the current behavior actually gives access to GitHub organizations named "Owners", "Developers", "Administrators"... when someone wants to grants its organization teams.
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Julien Carsique commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Do you want me to resubmit https://github.com/jenkinsci/github-oauth-plugin/pull/36 with the right JIRA issue? With or without the first "format & cleanup" commit ( https://github.com/jcarsique/github-oauth-plugin/commit/a310a6f0690b17d72f193827ae8f84f1ba7960da )? I'm using the suggested PR for two weeks in my company, with no issue. Note this can be seen as a major security fix since the current behavior actually gives access to GitHub organizations named "Owners", "Developers", "Administrators"... when someone wants to grants its organization teams. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske updated an issue Jenkins / JENKINS-21331 GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Change By: Sam Gleske Summary: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [github-oauth-plugin] (JENKINS-21331) GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin
Title: Message Title Sam Gleske commented on JENKINS-21331 Re: GitHub teams should be available groups for matrix based security when using GitHub OAuth plugin I updated the subject of the issue to make the problem more obvious to a developer. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
