[JIRA] [job-dsl-plugin] (JENKINS-18174) Checking of unique Build Parameter names has a hole and only works within a single context
Daniel Spilker commented on JENKINS-18174 Checking of unique Build Parameter names has a hole and only works within a single context Even if there are checks across parameter contexts, there are still templates and configure blocks to be considered to be 100% sure to have only unique parameter definitions. Since the DSL does not do this level of checks for other features, I tend to close this as "won't fix" and actually remove the existing checks since they pretend false security. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-18174) Checking of unique Build Parameter names has a hole and only works within a single context
Daniel Spilker assigned JENKINS-18174 to Daniel Spilker Checking of unique Build Parameter names has a hole and only works within a single context Change By: Daniel Spilker (11/Oct/14 10:27 PM) Assignee: Justin Ryan Daniel Spilker This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [job-dsl-plugin] (JENKINS-18174) Checking of unique Build Parameter names has a hole and only works within a single context
Andrew Harmel-Law created JENKINS-18174 Checking of unique Build Parameter names has a hole and only works within a single context Issue Type: Bug Assignee: Justin Ryan Components: job-dsl-plugin Created: 03/Jun/13 12:07 PM Description: In https://github.com/jenkinsci/job-dsl-plugin/blob/master/job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/helpers/BuildParametersContextHelper.groovy the buildParameterNodes.containsKey(parameterName) won't help if someone calls parameters a few times, since that check only works within a single Context. Ideally we should queue up all the buildParameterNodes and then replay only at the very end. See: https://github.com/jenkinsci/job-dsl-plugin/pull/50 Environment: Development Project: Jenkins Priority: Minor Reporter: Andrew Harmel-Law This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
