[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title SCM/JIRA link daemon commented on JENKINS-25253 Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Code changed in jenkins User: Johnny Willemsen Path: src/main/java/org/jenkinsci/plugins/multiplescms/MultiSCMRevisionState.java http://jenkins-ci.org/commit/multiple-scms-plugin/48aeb95c4c2fe9d937db9bdf74193b648cb06e31 Log: At the moment we have a SCM that doesn't require a workspace to poll for changes the ws will be null [FIXED JENKINS-25253] Compare: https://github.com/jenkinsci/multiple-scms-plugin/compare/9f53e8fd72d7...48aeb95c4c2f Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-25253 When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Change By: SCM/JIRA link daemon Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title SCM/JIRA link daemon commented on JENKINS-25253 Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Code changed in jenkins User: Johnny Willemsen Path: src/main/java/org/jenkinsci/plugins/multiplescms/MultiSCM.java http://jenkins-ci.org/commit/multiple-scms-plugin/0cd660a0f9c2a26d6817cd7ba17646205f2b11a8 Log: Implement supportsPolling and requiresWorkspaceForPolling Gets multiple git polling working with no workspace checked out [FIXED JENKINS-25253] Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title Johnny Willemsen commented on JENKINS-25253 Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Tested now my proposed addition, had to make a small change in another place, see https://github.com/jenkinsci/multiple-scms-plugin/pull/18 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title
Johnny Willemsen updated an issue
Jenkins / JENKINS-25253
When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Change By:
Johnny Willemsen
Comment:
Note, I am not a Java person and the code below is not tested at all, but could this be of help, just based on the documentation above. If this is useful, let me know, can create a pull request when that would help. Addition to MultipleSCM.java// Only return supportsPolling when all scms do report back that// they supports polling@Overridepublic boolean supportsPolling(){ for(SCM scm : scms) {if (!scm.supportsPolling()) return false; } return true;}// When one scm does require a workspace we return true, else// we don't need a workspace for polling@Overridepublic boolean requiresWorkspaceForPolling(){ for(SCM scm : scms) {if (scm.requiresWorkspaceForPolling()) return true; } return false;}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title
Johnny Willemsen edited a comment on JENKINS-25253
Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Note, I am not a Java person and the code below is not tested at all, but could this be of help, just based on the documentation above. If this is useful, let me know, can create a pull request when that would help. Addition to MultipleSCM.java// Only return supportsPolling when all scms do report back that// they supports polling@Overridepublic boolean supportsPolling(){ for(SCM scm : scms) {if ( ! scm.supportsPolling() == false ) return false; } return true;}// When one scm does require a workspace we return true, else// we don't need a workspace for polling@Overridepublic boolean requiresWorkspaceForPolling(){ for(SCM scm : scms) {if (scm.requiresWorkspaceForPolling() == true ) return true; } return false;}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title
Johnny Willemsen edited a comment on JENKINS-25253
Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Note, I am not a Java person and the code below is not tested at all, but could this be of help, just based on the documentation above. If this is useful, let me know, can create a pull request when that would help. Addition to MultipleSCM.java {{ // Only return supportsPolling when all scms do report back that// they supports polling@Overridepublic boolean supportsPolling(){ for(SCM scm : scms) {if (scm.supportsPolling() == false) return false; } return true;}// When one scm does require a workspace we return true, else// we don't need a workspace for polling@Overridepublic boolean requiresWorkspaceForPolling(){ for(SCM scm : scms) {if (scm.requiresWorkspaceForPolling() == true) return true; } return false;} }}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title
Johnny Willemsen edited a comment on JENKINS-25253
Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Note, I am not a Java person and the code below is not tested at all, but could this be of help, just based on the documentation above. If this is useful, let me know, can create a pull request when that would help. Addition to MultipleSCM.java {{ // Only return supportsPolling when all scms do report back that// they supports polling@Overridepublic boolean supportsPolling(){ for(SCM scm : scms) {if (scm.supportsPolling() == false) return false; } return true;}// When one scm does require a workspace we return true, else// we don't need a workspace for polling@Overridepublic boolean requiresWorkspaceForPolling(){ for(SCM scm : scms) {if (scm.requiresWorkspaceForPolling() == true) return true; } return false;} }}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title
Johnny Willemsen commented on JENKINS-25253
Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Note, I am not a Java person and the code below is not tested at all, but could this be of help, just based on the documentation above. If this is useful, let me know, can create a pull request when that would help. Addition to MultipleSCM.java
// Only return supportsPolling when all scms do report back that // they supports polling @Override public boolean supportsPolling() { for(SCM scm : scms) { if (scm.supportsPolling() == false) return false; }
return true; }
// When one scm does require a workspace we return true, else // we don't need a workspace for polling @Override public boolean requiresWorkspaceForPolling() { for(SCM scm : scms) { if (scm.requiresWorkspaceForPolling() == true) return true; }
return false; }
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title Johnny Willemsen commented on JENKINS-25253 Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Could this be because this plugin doesn't implement requiresWorkspaceForPolling (see http://javadoc.jenkins-ci.org/hudson/scm/SCM.html#requiresWorkspaceForPolling%28%29). Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Title: Message Title Jean-Christophe Sirot commented on JENKINS-25253 Re: When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Any update on this issue? I'm facing the same issue with docker containers as Jenkins slaves which are deleted when the job is finished (along with the workspace) Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [multiple-scms-plugin] (JENKINS-25253) When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build.
Or Shachar commented on JENKINS-25253 When MultiSCM is used to poll git, it will always rebuild if the workspace is cleaned post build. Thanks for the workaround... I bet there's a simple mistake in one on the conditions in the code that causes it. I'll try to dig in... Thanks! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
