[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen closed JENKINS-24512 as Fixed Add option to lock the created workspace to a host Resolved in 1.1.4 Change By: Paul Allen (05/Feb/15 5:28 PM) Status: Reopened Closed Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host That works This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen commented on JENKINS-24512 Add option to lock the created workspace to a host Ok the short name will not work in some situations. This all comes down to how DNS is resolved on the Host. The easiest is to run a remote invocation on the slave to find out it's hostname (as the slave resolves it). I have submitted the change to Main: https://swarm.workshop.perforce.com/changes/11531 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host It works with my local p4jenkins 1.4-SNAPSHOT ( do you have a latest snapshot deploy somewhere?). However, I am not able to run the test on my windows box. May relate to my environment. I only have linux env at work which does not have access to workshop.perforce.com:1666 Do you timeframe to fix https://issues.jenkins-ci.org/browse/JENKINS-26589?. I need the client configuration to stay unchanged when there is no file changes since I can run p4maven on this workspace anytime This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen commented on JENKINS-24512 Add option to lock the created workspace to a host The 'master' and 'slave' hostnames are calculated in different ways. The simplest way to fix this might be with string manipulation, where I fetch the FQDN for the 'slave' from the Node object and then chop the domain bit off. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host my bad, all my test fails since I am using java 8. With java 7 only one test fails This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran reopened JENKINS-24512 Add option to lock the created workspace to a host Per Java API: InetAddress.getLocalHost().getHostName() returns host shortname and hostname command also returns short name. This means we need to have the client's hostname not to use fqdn format, but short format instead This is the error, I am currently seeing ERROR Client '' can only be used from host 'h.fqdn.name.com'. Change By: dan tran (02/Feb/15 10:07 PM) Resolution: Fixed Status: Closed Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host I am seeing inconsistency in the hostname. For example, p4jenkins sets to full FQDN name of a slave, however at the save the command 'hostname' which is equivalent to InetAddress.getLocalHost().getHostName() return short name. Did you configure the client's at the master or at the slave node?? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen closed JENKINS-24512 as Fixed Add option to lock the created workspace to a host Added feature in 1.1.3 Change By: Paul Allen (30/Jan/15 11:01 AM) Status: Reopened Closed Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen commented on JENKINS-24512 Add option to lock the created workspace to a host Ok, so this works for slaves, but I totally forgot if you don't use slaves then NODE_NAME returns 'master'. Unless you're Jenkins server's hostname is 'master' this isn't much use. I have added some helper function to access the real hostname from the Computer object, but this gives a FQDN; is that an issue or should I look to shorten it to just the machine alias? e.g. foo.domain.com -- foo This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host I went ahead with the upgrade. It works and I think https://issues.jenkins-ci.org/browse/JENKINS-26589 is fixed as well. Thanks This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host full domain name is fine. since you add a new configuration, I wonder if it is backward/forward compatible? just want to ask in case I need to revert the upgrade ( I am about to upgrade to 1.1.3-SNAPSHOT) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen
commented on JENKINS-24512
Add option to lock the created workspace to a host
Hi Dan, just running some tests now...
I had some issues determining the Node name/host. I can implement this in two ways:
1. hostname = envVars.get("NODE_NAME", "");
2. hostname = InetAddress.getLocalHost().getHostName();
Option 2 is not totally reliable and option 1 relies on Users calling the Node the same as the hostname.
I will likely need to add some checks to see if the host is already set, or should I override any previous values at the start of the build?
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host for now option1 works for my organization, however others may have different naming convention How unreliable is option 2 in what way it would fail? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
Paul Allen commented on JENKINS-24512 Add option to lock the created workspace to a host I'll go with option 1. Option 2 can fail if DNS is not configured or if the hostname and /etc/hosts are not defined (Windows... again more issues). The changes are in MAIN (only one line). I only set/update the Host field during a build (not polling), let me know if this might cause an issue. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host My hunch is correct, we have different convention even within my org ( hard to change) However, I can put the requirement to have all the build hosts setup correctly. Would it be possible to make it optional to lock down of the host? perhaps a system prop so that we can get some early feedback update the host field at build time is fine This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran edited a comment on JENKINS-24512 Add option to lock the created workspace to a host You should set the host at every build since the slave may not be the same from last run. I now running into performance issue where P4Maven takes a lots of time to discover the current workspace client where it has to scan thru a long list of clients created by my Jenkins/CI cluster on the same P4 build account This is a crucial feature for me to have p4jenkins to setup build host correctly This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran commented on JENKINS-24512 Add option to lock the created workspace to a host You should set the host at every build. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24512) Add option to lock the created workspace to a host
dan tran edited a comment on JENKINS-24512 Add option to lock the created workspace to a host You should set the host at every build. I now running into performance issue where P4Maven takes a log time to discover the current workspace client where it has to scan thru a long list of clients created by my Jenkins/CI cluster on the same P4 build account This is a crucial feature for me to have p4jenkins to setup build host correctly This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
