[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title SCM/JIRA link daemon commented on JENKINS-24591 Re: Unable to run perforce commands within build steps Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/ConfigurationListener.java src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java src/main/resources/org/jenkinsci/plugins/p4/PerforceScm/global.jelly http://jenkins-ci.org/commit/p4-plugin/3cb5d2208e274843512a0838ce0f7900dc4c0ae4 Log: Hide P4_TICKET for secure systems. An option in the global configuration to hide the P4_TICKET variable (not set by default). JENKINS-24591 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen resolved as Fixed Slated for release 1.3.10 Jenkins / JENKINS-24591 Unable to run perforce commands within build steps Change By: Paul Allen Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen reopened an issue Use an option in the global config to enable/disable P4_PICKET in the environment. Jenkins / JENKINS-24591 Unable to run perforce commands within build steps Change By: Paul Allen Resolution: Fixed Status: Closed Reopened Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen started work on JENKINS-24591 Change By: Paul Allen Status: Reopened In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen closed an issue as Fixed Released Jenkins / JENKINS-24591 Unable to run perforce commands within build steps Change By: Paul Allen Status: Reopened Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Jim Poje reopened an issue Re-open to remove P4_TICKET environment variable Jenkins / JENKINS-24591 Unable to run perforce commands within build steps Change By: Jim Poje Resolution: Fixed Status: Closed Reopened Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Jim Poje commented on JENKINS-24591 Re: Unable to run perforce commands within build steps Exposing the P4_TICKET value is a security risk, since the ticket value is essentially a credential value with access to a perforce server. In conjunction with the exported P4_USER and P4_PORT values, anyone with the ticket value has all the access to the perforce server that is granted to the P4_USER. Passing such a ticket value, in clear text, as an environment variable poses too great a risk. Let me request that the P4_TICKET environment variable be entirely removed, as passing credential values in environment variables is simply a very bad practice. If there is severe pushback to this request, a solution that allows the P4_TICKET environment to be conditionally set – with a default setting that disables it – could be considered as a less desirable alternative. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen closed an issue as Fixed Fixed 1.3.1 Added P4_USER and P4_TICKET Jenkins / JENKINS-24591 Unable to run perforce commands within build steps Change By: Paul Allen Status: Open Closed Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title SCM/JIRA link daemon commented on JENKINS-24591 Re: Unable to run perforce commands within build steps Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java src/main/resources/org/jenkinsci/plugins/p4/PerforceScm/buildEnv.groovy src/main/resources/org/jenkinsci/plugins/p4/PerforceScm/buildEnv.properties http://jenkins-ci.org/commit/p4-plugin/d6a4b48d81c032ef2560e4ad2e1159e81fef9e6b Log: Added P4_USER and P4_TICKET environment variables. Added Perforce environment variables to the buildEnv documentation. JENKINS-24591 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen commented on JENKINS-24591 Re: Unable to run perforce commands within build steps Ok I get p4 lock on a file of files, but counter? Do you want to read the value or set a counter? custom or a Perforce counter? Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Stephen Tunney commented on JENKINS-24591 Re: Unable to run perforce commands within build steps Add p4 lock and counters commands and you've got yourself a deal! Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Paul Allen commented on JENKINS-24591 Re: Unable to run perforce commands within build steps I can add P4_USER, but how would you like me to do auth? If the Job is running on the slave or master then in theory the local .p4ticket file should contain a valid ticket. The alternatives are less than ideal e.g. exposing the user's Password/Ticket. I had an additional idea, not to solve this issue, but could prove to be useful: The initial thinking behind not exposing P4PORT/P4CLIENT etc... was that the plugin would manage all P4 tasks. As the plugin uses p4java there is no need to deploy the 'p4' executable on the slave. My proposal is to add lots of additional p4 steps to the build steps, for example: add/edit/delete a file integ/copy a path sync/print a file I know it won't help p4ant/p4maven, but perhaps people are scripting p4 commands? Feel free to spin this off onto another ISSUE if you think it could be useful. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title
Morne Joubert commented on JENKINS-24591
Re: Unable to run perforce commands within build steps
Currently the env that are set are: P4_CHANGELIST P4_CLIENT P4_PORT
from the following code
public void buildEnvVars(AbstractBuild build, Map env) { super.buildEnvVars(build, env);
TagAction tagAction = build.getAction(TagAction.class); if (tagAction != null) { // Set P4_CHANGELIST value if (tagAction.getBuildChange() != null) { String change = getChangeNumber(tagAction); env.put("P4_CHANGELIST", change); }
// Set P4_CLIENT workspace value if (tagAction.getClient() != null) { String client = tagAction.getClient(); env.put("P4_CLIENT", client); }
// Set P4_PORT connection if (tagAction.getPort() != null) { String port = tagAction.getPort(); env.put("P4_PORT", port); }
} }
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [p4-plugin] (JENKINS-24591) Unable to run perforce commands within build steps
Title: Message Title Stephen Tunney commented on JENKINS-24591 Re: Unable to run perforce commands within build steps P4User, P4Client, P4Port should all be exposed IMO. I would really like to see this implemented. My NAnt scripts are dying without it!!! Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
