[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-05 Thread pal...@perforce.com (JIRA)















































Paul Allen
 closed  JENKINS-26589 as Fixed


p4jenkins set client root to null
















Fixed in 1.1.4





Change By:


Paul Allen
(05/Feb/15 5:27 PM)




Status:


Reopened
Closed





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-04 Thread pal...@perforce.com (JIRA)














































Paul Allen
 commented on  JENKINS-26589


p4jenkins set client root to null















Hi Dan, I can't put an estimate on a fix while I am unable to reproduce the 'null' issue.  I could change the behaviour to only set the workspace at the point of creation, but not sure if this is desired.  

As for the issue with changing STATIC workspaces; this is fixable, but I'm in the middle of adding support for the Workflow plugin.  I'll see what I can do. 



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-04 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-26589


p4jenkins set client root to null















Code changed in jenkins
User: Paul Allen
Path:
 src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
 src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
http://jenkins-ci.org/commit/p4-plugin/8006fe23f8ad5ad7bf4d47460da14c294f48d518
Log:
  Avoid writing `null` client root.

Added protection to prevent a null client root value being written
during polling.  The client root is not set during polling as the
workspace could be polled from another node.

Change also prevents updates to Static workspaces.

JENKINS-26589





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-04 Thread dant...@gmail.com (JIRA)














































dan tran
 commented on  JENKINS-26589


p4jenkins set client root to null















Very much appreciated if you can fix it before big change for the work flow



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-04 Thread dant...@gmail.com (JIRA)














































dan tran
 commented on  JENKINS-26589


p4jenkins set client root to null















When Jenkins does the build, the workspace directory is set correctly. However, on the next poll without souce changes, it is set to "null" as if a null pointer got convert to string. And the host is set to empty.  It is always reproducible on all my Jenkins clusters(2). I'm sure you will eventually see it



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-04 Thread pal...@perforce.com (JIRA)














































Paul Allen
 commented on  JENKINS-26589


p4jenkins set client root to null















Thank you - the Polling bit was just the clue I needed.  I was looking too closely at the build code.  

Found the bug, the question is do I fix it along with the upgrade to support Workflow plugin enhancements?  Might be a 2.0.0 release as it is a big change.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-02-04 Thread dant...@gmail.com (JIRA)














































dan tran
 commented on  JENKINS-26589


p4jenkins set client root to null















I re read yr comment, it is your call



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-30 Thread dant...@gmail.com (JIRA)














































dan tran
 reopened  JENKINS-26589


p4jenkins set client root to null
















Still see the issue. and It is very intermittent.  will manage to find a patter





Change By:


dan tran
(31/Jan/15 12:01 AM)




Resolution:


Fixed





Status:


Closed
Reopened



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-30 Thread pal...@perforce.com (JIRA)















































Paul Allen
 closed  JENKINS-26589 as Fixed


p4jenkins set client root to null
















Fixed in 1.1.3





Change By:


Paul Allen
(30/Jan/15 11:00 AM)




Status:


Open
Closed





Assignee:


PaulAllen





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-27 Thread dant...@gmail.com (JIRA)














































dan tran
 updated  JENKINS-26589


p4jenkins set client root to null
















Change By:


dan tran
(27/Jan/15 11:29 PM)




Description:


my
jenkins
Jenkins
jobusesp4jenkins(1.1.2)customviewwithanassignedworkspacename,andrunsona
jenkins
Jenkins
slave.Whenthejobstarts,p4jenkinscreatetheworkspaceclientandsettherootdirectorytonullstring(literally4charsnullstring)Thepreferwayshouldbe
a
validrootdirectlyatthe
buildnode(
slave
ormaster).Shouldbeupdatedaccordingateachbuild
ThiscausesaproblemwhenusingthesameworkspaceclientwithP4Mavenwhereitexpectsavalidrootdirectory.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-27 Thread rhum...@ravensoftware.com (JIRA)














































Ryan Hummer
 commented on  JENKINS-26589


p4jenkins set client root to null















I am seeing similar behavior with my Multi-configuration project. It is appending node\${node_name} to the clientspec root.  I have the job configured to use the Static workspace behavior.  I would expect it to not mess with my p4 root.  This is a blocker for us using P4 Jenkins.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-25 Thread dant...@gmail.com (JIRA)














































dan tran
 commented on  JENKINS-26589


p4jenkins set client root to null















I also see this behavior when the job is locked at Master



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-24 Thread dant...@gmail.com (JIRA)














































dan tran
 updated  JENKINS-26589


p4jenkins set client root to null
















Change By:


dan tran
(25/Jan/15 7:38 AM)




Description:


myjenkinsjobusesp4jenkins
(1.1.2)
customviewwithanassignedworkspacename,and
run
runs
on
ajenkins
slave.Whenthejobstarts,p4jenkinscreatetheworkspaceclientandsettherootdirectorytonullstring(literally4charsnullstring)Thepreferwayshouldbe
the
valid
rootdirectlyattheslaveThiscausesaproblemwhenusingthesameworkspaceclientwithP4Mavenwhereitexpectsavalidrootdirectory.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-26589) p4jenkins set client root to null

2015-01-24 Thread dant...@gmail.com (JIRA)














































dan tran
 created  JENKINS-26589


p4jenkins set client root to null















Issue Type:


Bug



Assignee:


Unassigned


Components:


p4-plugin



Created:


25/Jan/15 7:35 AM



Description:


my jenkins job uses p4jenkins custom view with an assigned workspace name, and run on slave.  When the job starts, p4jenkins create the workspace client and set the root directory to "null" string ( literally 4 chars "null" string)

The prefer way should be the root directly at the slave

This causes a problem when using the same workspace client with P4Maven where it expects a valid root directory.  




Environment:


linux




Project:


Jenkins



Priority:


Major



Reporter:


dan tran

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.