[JIRA] [p4-plugin] (JENKINS-28498) Null Pointer when publishing assets and server is down

2015-05-29 Thread pal...@perforce.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Paul Allen closed an issue as Fixed 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
Resolved in 1.2.3 
 
 
 
 
 
 
 
 
 
 Jenkins /  JENKINS-28498 
 
 
 
  Null Pointer when publishing assets and server is down  
 
 
 
 
 
 
 
 
 

Change By:
 
 Paul Allen 
 
 
 

Status:
 
 Open Closed 
 
 
 

Resolution:
 
 Fixed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-28498) Null Pointer when publishing assets and server is down

2015-05-21 Thread pal...@perforce.com (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Paul Allen commented on  JENKINS-28498 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Null Pointer when publishing assets and server is down  
 
 
 
 
 
 
 
 
 
 
Thanks for raising this, I had missed the Publish failure case (only checked for Populate/Poll). In an ideal world I should throw this in the ClientHelper/ConnectionHelper class, but for slight behaviour differences with remote slave execution I delay the throw. 
There are a few minor fixes, but the new error looks like this... 

 

P4: Unable to connect: com.perforce.p4java.exception.ConnectionException: Unable to connect to Perforce server at localhost:1888
P4: Connection retry: 1
P4: Unable to connect: com.perforce.p4java.exception.ConnectionException: Unable to connect to Perforce server at localhost:1888
P4: Connection retry: 2
P4: Unable to connect: com.perforce.p4java.exception.ConnectionException: Unable to connect to Perforce server at localhost:1888
P4: Connection retry: 3
P4: Connection retry giving up...

P4 Task: establishing connection.
P4: Server connection error: localhost:1888
P4: Abort, no server connection.

ERROR: Publisher org.jenkinsci.plugins.p4.asset.AssetNotifier aborted due to exception
hudson.AbortException: P4: Abort, no server connection.

	at org.jenkinsci.plugins.p4.tasks.AbstractTask.setWorkspace(AbstractTask.java:57)
	at org.jenkinsci.plugins.p4.asset.AssetNotifier.perform(AssetNotifier.java:88)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:772)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:736)
	at hudson.model.Build$BuildExecution.post2(Build.java:183)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:685)
	at hudson.model.Run.execute(Run.java:1757)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:234)
Finished: FAILURE
 

 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
  

[JIRA] [p4-plugin] (JENKINS-28498) Null Pointer when publishing assets and server is down

2015-05-21 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-28498 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Null Pointer when publishing assets and server is down  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/asset/AssetNotifier.java src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java http://jenkins-ci.org/commit/p4-plugin/efe25d4cb794e2b48e876ab5eeb9d0803d78355d Log: Improved Error for Publish step when connection is down. 
JENKINS-28498 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-28498) Null Pointer when publishing assets and server is down

2015-05-20 Thread n...@palmr.co.uk (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Nick Palmer assigned an issue to Paul Allen 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-28498 
 
 
 
  Null Pointer when publishing assets and server is down  
 
 
 
 
 
 
 
 
 

Change By:
 
 Nick Palmer 
 
 
 

Assignee:
 
 Paul Allen 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [p4-plugin] (JENKINS-28498) Null Pointer when publishing assets and server is down

2015-05-20 Thread n...@palmr.co.uk (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Nick Palmer created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Jenkins /  JENKINS-28498 
 
 
 
  Null Pointer when publishing assets and server is down  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 p4-plugin 
 
 
 

Created:
 

 20/May/15 10:20 AM 
 
 
 

Environment:
 

 Jenkins: 1.613  p4-plugin: 1.2.1 
 
 
 

Priority:
 
  Minor 
 
 
 

Reporter:
 
 Nick Palmer 
 
 
 
 
 
 
 
 
 
 
I was attempting to publish assets as a post build action in one of my jobs and didn't realise the perforce server that it would publish to wasn't online. 
The error I got was not helpful, but a Null Pointer instead: 

 

ERROR: Publisher 'Perforce: Publish assets' aborted due to exception: 
java.lang.InterruptedException: P4: Unable to setup workspace: java.lang.NullPointerException
	at org.jenkinsci.plugins.p4.tasks.AbstractTask.setWorkspace(AbstractTask.java:63)
	at org.jenkinsci.plugins.p4.asset.AssetNotifier.perform(AssetNotifier.java:87)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:726)
	at hudson.model.Build$BuildExecution.post2(Build.java:185)
	at huds