[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-09-11 Thread de...@ikedam.jp (JIRA)















































ikedam
 resolved  JENKINS-22125 as Fixed


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















No details.
Looks an invalid reopen.





Change By:


ikedam
(11/Sep/14 11:34 PM)




Status:


Reopened
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-09-03 Thread dmasla...@java.net (JIRA)














































Dmitry Maslakov
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















I used 
-Dhudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.compatibility_mode=true
 with Jenkins 1.578 and plug-in of version 2.25, it works.

But pay attention that you have manually restart Jenkins on the host, because restarting from UI will restart with old Java options so that added -D option will not appear.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-09-03 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















@vikulin:
Are you running with

-Dhudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.compatibility_mode=true
 as described above?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-09-03 Thread vadym.viku...@gmail.com (JIRA)














































Vadym Vikulin
 reopened  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















Still reproduces on 2.25:

FATAL: Illegal choice: release_2.8
java.lang.IllegalArgumentException: Illegal choice: release_2.8
	at hudson.model.ChoiceParameterDefinition.checkValue(ChoiceParameterDefinition.java:75)
	at hudson.model.ChoiceParameterDefinition.createValue(ChoiceParameterDefinition.java:87)
	at hudson.model.ChoiceParameterDefinition.createValue(ChoiceParameterDefinition.java:19)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.convertToDefinedType(ProjectSpecificParameterValuesActionTransform.java:83)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.transformParametersAction(ProjectSpecificParameterValuesActionTransform.java:34)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.getProjectSpecificBuildActions(ProjectSpecificParametersActionFactory.java:32)
	at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBuildActions(BuildTriggerConfig.java:290)
	at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.perform2(BuildTriggerConfig.java:336)
	at hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig.perform2(BlockableBuildTriggerConfig.java:57)
	at hudson.plugins.parameterizedtrigger.TriggerBuilder.perform(TriggerBuilder.java:85)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:772)
	at hudson.model.Build$BuildExecution.build(Build.java:199)
	at hudson.model.Build$BuildExecution.doRun(Build.java:160)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:535)
	at hudson.model.Run.execute(Run.java:1732)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:234)





Change By:


Vadym Vikulin
(03/Sep/14 8:12 AM)




Resolution:


Fixed





Status:


Resolved
Reopened





Assignee:


Darrell Hamilton
huybrechts



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-28 Thread de...@ikedam.jp (JIRA)















































ikedam
 resolved  JENKINS-22125 as Fixed


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















Fixed in 2.24.





Change By:


ikedam
(29/Mar/14 12:32 AM)




Status:


In Progress
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-21 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















I tested with 2.24 and backwards compatability turned on. I found one problem in some of my trigger jobs. They trigger jobs and specify "Predefined parameters", which is basically just of bunch of strings to pass a parameters. In the config file they look like:



  materialize_type=fresh
workspace_build_type=incremental
product_linux32=true
product_linux64=true	
product_windows32=true
product_windows64=true
product_mac32=false
product_mac64=false
archive_workspace_and_product_for_testing=false
run_squish_tests=false



You can't see it there, but there is a tab character after product_linux64=true. As you might guess, on the job that gets triggered, this parameter is defined as a boolean.

In 2.22, the mal-formed value true\t in the trigger job was interpreted by the triggered job as boolean "true". In 2.24 with compatibility mode on, the mal-formed value was interpreted by the triggered job as boolean "false."

In both 2.22 and 2.24 with compatibility mode on, the correctly-formed values true in the trigger job are interpreted by the triggered job as boolean "true".

This was slightly annoying, as the trailing tab character is not visible in the web interface. However, I would consider this regression as the result of a user error, not a bug in the plugin.

So for us I can say that for us, 2.24 with compatibility mode on works.
Thanks




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread bruce.e...@gmail.com (JIRA)














































Bruce Edge
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@ikedam
New bug as requested here:
https://issues.jenkins-ci.org/browse/JENKINS-22281



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















I'm just interested in what you say a problem, how you produced it, and how I can reproduce it
Understood. I will try and get this tested tomorrow, and report back.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread de...@ikedam.jp (JIRA)














































ikedam
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















This is the first time the phrase "undefined parameter" appears in this issue, isn't it?
2.22, 2.23, 2.24 and 2.24 with compatibility option should handle undefined parameters in the same way. But I cannot decide as you haven't let me know all.

Please report the details of the problem you are facing.
I'm not interested in whether what you do is legitimate or not. I'm just interested in what you say a problem, how you produced it, and how I can reproduce it.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















For case (1), I don't know whether it is a problem in 2.23 or not. It turns out that the jobs that failed under 2.23 had both case (1) AND case (2). So I guess I'm just asking - how does your code (in 2.24, both with and without compatibilty mode) handle a trigger with an undefined parameter?




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread de...@ikedam.jp (JIRA)














































ikedam
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@mwebber
I want to know how to reproduce the case (1) in 2.23.
I'm not sure the case (1) is caused by the change in 2.23 discussed in this issue, and whether can be fixed backward-compatibility option in 2.24.
I think the change in 2.23 at most cause to fail triggering some of builds. It sounds strange that parameters passed in the same trigger are inconsistent.




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@ikedam - you asked
@mwebber Please report more details. I cannot get how I can reproduce your problem in my environment.

Sorry if I wasn't clear, the problem I was discussing was the problem I originally reported, under 2.23. I have not re-tested under 2.24 (in Backward compatibility). What release do you want me to test in?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread de...@ikedam.jp (JIRA)














































ikedam
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@bedge
Would you create a new issue and link to this issue?

@mwebber
Please report more details. I cannot get how I can reproduce your problem in my environment.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-20 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Ah, I see the issues in my setup now. There are actually two cases:

(1) The "Trigger/call builds on other projects" had "predefined parameters", but not all the parameters existed in one of the jobs being triggered. This is actually a legitimate use case - I might be using one step to trigger several job, which have parameters in common, but not exactly the same set in each case.

(2) One of the jobs I was triggering had a parameter of type "Extensible Choice", where the Chooice Provider was a "Global Choice Parameter" which provided a list of strings. The value of the parameter being passed was not in the list of available values. This was intentional.

Case (2) looks like it is covered by the backwards compatibiliy option - does that also handle case (1)?



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-19 Thread bruce.e...@gmail.com (JIRA)














































Bruce Edge
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Can the exception be improved to show what the offending parameter is?

I'm seeing no information on what caused the problem:

FATAL: Illegal choice: 
java.lang.IllegalArgumentException: Illegal choice: 
	at hudson.model.ChoiceParameterDefinition.checkValue(ChoiceParameterDefinition.java:75)
	at hudson.model.ChoiceParameterDefinition.createValue(ChoiceParameterDefinition.java:87)
	at hudson.model.ChoiceParameterDefinition.createValue(ChoiceParameterDefinition.java:19)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.convertToDefinedType(ProjectSpecificParameterValuesActionTransform.java:67)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.transformParametersAction(ProjectSpecificParameterValuesActionTransform.java:32)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.getProjectSpecificBuildActions(ProjectSpecificParametersActionFactory.java:32)
	at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBuildActions(BuildTriggerConfig.java:290)
	at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.perform2(BuildTriggerConfig.java:336)
	at hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig.perform2(BlockableBuildTriggerConfig.java:57)
	at hudson.plugins.parameterizedtrigger.TriggerBuilder.perform(TriggerBuilder.java:85)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804)
	at hudson.model.Build$BuildExecution.build(Build.java:199)
	at hudson.model.Build$BuildExecution.doRun(Build.java:160)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:585)
	at hudson.model.Run.execute(Run.java:1676)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:231)



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-15 Thread de...@ikedam.jp (JIRA)












































  
ikedam
 edited a comment on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















Released Parameterized Trigger 2.24 including fix by @zeroem.
It will be available from your update center in a day.

Backward compatibility mode is enabled with launching Jenkins with:

java -Dhudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.compatibility_mode=true -jar jenkins.war


See Backward compatibility with version 2.22 for more details (I expect the update of that document by someone as I know my poor English).



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-15 Thread de...@ikedam.jp (JIRA)














































ikedam
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Released Parameterized Trigger 2.24 including fix by @zeroem.
It will be available from your update center in a day.

Backward compatibility mode is enabled with launching Jenkins with:

java -Dhudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.compatibility_mode=true -jar jenkins.war


See Backward compatibility with version 2.22 for more details.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-15 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Code changed in jenkins
User: ikedam
Path:
 src/main/java/hudson/plugins/parameterizedtrigger/ProjectSpecificParameterValuesActionTransform.java
http://jenkins-ci.org/commit/parameterized-trigger-plugin/e18d764ecccfbbb58de49f7e5107c12550ccee1c
Log:
  Merge pull request #63 from zeroem/JENKINS-22125

Resolves JENKINS-22125


Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/ff516946ffb2...e18d764ecccf




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-15 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Code changed in jenkins
User: Darrell Hamilton
Path:
 src/main/java/hudson/plugins/parameterizedtrigger/ProjectSpecificParameterValuesActionTransform.java
http://jenkins-ci.org/commit/parameterized-trigger-plugin/8f410be6a8a203e92c4120a12750514878585869
Log:
  Resolves JENKINS-22125

Previously, when the Parameterized Trigger Plugin only passed
StringParameterValues, invalid values could be passed to downstream
jobs, eg passing an invalid value for a Choice Parameter. Now that the
values get converted to their appropriate type, use cases depending on
allowing invalid values to be passed break with an
IllegalArgumentException.

This patch broadens compatibility with existing use cases that are
dependent on passing an invalid value without sacrificing the intended
functionality of the feature.





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-13 Thread darrell.no...@gmail.com (JIRA)














































Darrell Hamilton
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@mwebber Although I am working on getting a compatibility fix done, you might want to consider updating your workflow to use the Extensible Choice Parameter Plugin. It specifically allows for your use case where a parameter has a predefined list of values and can accept arbitrary ones.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread darrell.no...@gmail.com (JIRA)














































Darrell Hamilton
 started work on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















Change By:


Darrell Hamilton
(12/Mar/14 6:20 PM)




Status:


Open
In Progress



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread darrell.no...@gmail.com (JIRA)














































Darrell Hamilton
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















I've submitted a pull request implementing my proposed solution, https://github.com/jenkinsci/parameterized-trigger-plugin/pull/63



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread darrell.no...@gmail.com (JIRA)














































Darrell Hamilton
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















To get things started, yes this appears to be originating in the patch I submitted, so I'll field any fixes.

I think an ideal solution would be to simply try/catch the attempt to convert the value and if an IllegalArgumentException gets thrown back, simply use the original value instead of trying to convert it. Although this contravenes the definition of the parameter on the target job, it will broaden compatibility with any existing use cases.

@dmaslakov, I am hesitant to make this behavior optional as it better ensures the parameters behave as their defined rather than how they're passed. I would propose, instead, that the choice parameter be extended with an optional "accept anything" behavior to accommodate @mwebber's particular use case.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread dmasla...@java.net (JIRA)














































Dmitry Maslakov
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@ikedam, downstream job A uses parameter values as-is, i.e. unexpected values e, f, g are used in processing exactly as expected values a, b, c does. In my case parameter types are just a facade for user-friendly UI, but as build execution is started the values are just strings (like environment variables).


And answering to your questions:

How does downstram project A uses values e, f, g?
In same way as values a, b, c. One of my real example for parameter meaning is a set of host names where SSH session will connect to.

Does A use those unexpected values in builds,
Yes.

or does not use those valus when unexpected values passed or triggered as downstream?
Not using will require additional checks and custom code in build steps. No, I did not skip unexpected values.

I want to know what happens in your case if simply omitting parameters failed to cenvert.
It will fail the build of job A. Behavior you suggest is in same sense harmful and not backward compatible as one implemented in version 2.23.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread de...@ikedam.jp (JIRA)














































ikedam
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















@mwebber
Would you report how to reproduce your problem?
Same to the case of @dmaslakov?

@dmaslakov
Let me know what you want to do with those projects.
How does downstram project A uses values e, f, g?
Does A use those unexpected values in builds, or does not use those valus when unexpected values passed or triggered as downstream?
I want to know what happens in your case if simply omitting parameters failed to cenvert.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread mweb...@java.net (JIRA)















































mwebber
 assigned  JENKINS-22125 to Darrell Hamilton



FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23
















Assigning to zeroem. since this change is suspect.





Change By:


mwebber
(12/Mar/14 10:30 AM)




Assignee:


huybrechts
Darrell Hamilton



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread mweb...@java.net (JIRA)














































mwebber
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















My jobs do nothing special, they just do the most basic thing - trigger another job, with "Predefined parameters" which is, as per the help text, "KEY=value pairs, one per line (Java properties file format)."

I presume this new feature was never tested.




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread alex.ouzou...@me.com (JIRA)














































Alex Ouzounis
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















I agree. This new feature should be optional and the default behaviour shall remain the same.

Alex



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread dmasla...@java.net (JIRA)














































dmaslakov
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Alternatively, making parameter conversion an optional, turned off by default, will be more flexible and less harmful for existing jobs.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-12 Thread dmasla...@java.net (JIRA)














































dmaslakov
 commented on  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Change log of Parameterized Trigger Plugin describes the change "Now attempts to convert parameter strings to the type defined in the project" which is likely the reason of described error.

In any case I also had have the same error after plug-in upgrade. More details:

	job A has parameter P of type 'choice' with number of predefined values a, b, c (Job A is the main job with build steps.)
	job B extends the values of parameter P, precisely, it has parameter P as a choice of values e, f, g (Job B is a wrapper job, it mangles parameters and calls job A for the real work.)
	in version 2.22 all worked fine as parameters was not converted and under the hood Jenkins does not care about parameter types, they are just strings
	in version 2.23 the converting of parameter values fails



Of course, here is a work around for described case: a) convert parameter P of main job A to be a string, b) create wrapper job C with parameter P as a choice of a, b, c, and call job A. But this work around assumes that conversion of choice parameter into string parameter will not fail.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [parameterized-trigger] (JENKINS-22125) FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23

2014-03-11 Thread mweb...@java.net (JIRA)














































mwebber
 created  JENKINS-22125


FATAL: Illegal choice: incremental caused by Parameterized Trigger Plugin 2.23















Issue Type:


Bug



Assignee:


huybrechts



Components:


parameterized-trigger



Created:


11/Mar/14 9:03 AM



Description:


After I upgraded the Parameterized Trigger Plugin from 2.22 to 2.23, I had a number of jobs that failed immediately with

FATAL: Illegal choice: incremental
java.lang.IllegalArgumentException: Illegal choice: incremental
	at hudson.model.ChoiceParameterDefinition.checkValue(ChoiceParameterDefinition.java:75)
	at hudson.model.ChoiceParameterDefinition.createValue(ChoiceParameterDefinition.java:87)
	at hudson.model.ChoiceParameterDefinition.createValue(ChoiceParameterDefinition.java:19)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.convertToDefinedType(ProjectSpecificParameterValuesActionTransform.java:62)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParameterValuesActionTransform.transformParametersAction(ProjectSpecificParameterValuesActionTransform.java:28)
	at hudson.plugins.parameterizedtrigger.ProjectSpecificParametersActionFactory.getProjectSpecificBuildActions(ProjectSpecificParametersActionFactory.java:32)
	at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.getBuildActions(BuildTriggerConfig.java:290)
	at hudson.plugins.parameterizedtrigger.BuildTriggerConfig.perform2(BuildTriggerConfig.java:336)
	at hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig.perform2(BlockableBuildTriggerConfig.java:57)
	at hudson.plugins.parameterizedtrigger.TriggerBuilder.perform(TriggerBuilder.java:85)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:804)
	at hudson.model.Build$BuildExecution.build(Build.java:199)
	at hudson.model.Build$BuildExecution.doRun(Build.java:160)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:585)
	at hudson.model.Run.execute(Run.java:1676)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:231)



Downgrading the Parameterized Trigger Plugin back to 2.22 fixed the problem.

All the failing jobs have build steps of type Trigger/call builds on other projects.




Project:


Jenkins



Priority:


Critical



Reporter:


mwebber

























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.