[JIRA] [perforce] (JENKINS-7436) Add support for perforce shelve builds

2013-06-28 Thread john.mcgo...@openwave.com (JIRA)














































John McGowan
 commented on  JENKINS-7436


Add support for perforce shelve builds















We've been doing precommit/shelved builds for a good while in a build step prior to the main job. Parameterized build with the p4 shelve number as input. I "Run buildstep before SCM":

#!/bin/bash -ex

p4 revert ...

The before the main build task I run this (this is on a clean and new workspace everytime btw): 

if [ $SHELVE != 0 ]; then

	Unshelve the p4 shelve list supplied in the parameter 'SHELVE'
p4 unshelve -s $SHELVE
if [ $? -ne 0 ]; then
echo "Unshelving change $SHELVE hasn't worked, aborting"
exit 1
fi
else
echo "Input a value for the P4 shelve command or else you're just building the latest nightly code, which is covered in another job"
exit 1
fi





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [perforce] (JENKINS-7436) Add support for perforce shelve builds

2013-06-28 Thread john.mcgo...@openwave.com (JIRA)












































 
John McGowan
 edited a comment on  JENKINS-7436


Add support for perforce shelve builds
















We've been doing precommit/shelved builds for a good while in a build step prior to the main job. Parameterized build with the p4 shelve number as input. I run "Run buildstep before SCM":

#!/bin/bash -ex

p4 revert ...

Then before the main build task I run this (this is on a clean and new workspace everytime btw): 

if [ $SHELVE != 0 ]; then

	Unshelve the p4 shelve list supplied in the parameter 'SHELVE'
p4 unshelve -s $SHELVE
if [ $? -ne 0 ]; then
echo "Unshelving change $SHELVE hasn't worked, aborting"
exit 1
fi
else
echo "Input a value for the P4 shelve command or else you're just building the latest nightly code, which is covered in another job"
exit 1
fi





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [perforce] (JENKINS-7436) Add support for perforce shelve builds

2013-06-20 Thread andy_bi...@scee.net (JIRA)














































Andy Bigos
 commented on  JENKINS-7436


Add support for perforce shelve builds















.. I can't justify using company time to implement it.

Thanks for update Rob, we will look at implementing this via build steps in that case.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [perforce] (JENKINS-7436) Add support for perforce shelve builds

2013-06-19 Thread andy_bi...@scee.net (JIRA)














































Andy Bigos
 commented on  JENKINS-7436


Add support for perforce shelve builds
















Just bumping this issue as wondering if there has been any progress. It sounds like the way to get something going (at the moment) is as a build step, however it does really seem to fall in the domain of the scm plugin.

The complications seem to come from trying to be consistent when the workspace isn't cleaned, which is something I guess most people don't do as it's generally considered best practice to clean the workspace between builds. I would think this was especially true when dealing the pre-commit testing. 

With that in mind, I wonder if it's possible to do an initial implementation that relies on having a clean workspace? E.g. if a shelved CL is provided (via a parameter) this overrides the clean workspace setting so that it always starts from a known state? That would remove some of the complexity and I guess meet most peoples use cases. Just an idea.

I'd be interesting to hear of any progress on the plugin side before we go ahead and implement this as a build step.

Ta
Andy



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[JIRA] [perforce] (JENKINS-7436) Add support for perforce shelve builds

2013-06-19 Thread rob.pe...@gmail.com (JIRA)














































Rob Petti
 commented on  JENKINS-7436


Add support for perforce shelve builds















As far as I know, nobody has been working on this. We don't use shelving at my organization, so I can't justify using company time to implement it.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.