[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev reopened JENKINS-25559 Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions The fix does not resolve the issue New PR: https://github.com/jenkinsci/perforce-plugin/pull/61 Seems MacroSubstitutionHelper should catch recursion calls to prevent the issue Change By: Oleg Nenashev (12/Nov/14 3:09 PM) Resolution: Fixed Status: Resolved Reopened This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Rob Petti commented on JENKINS-25559 Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions This is a configuration issue, isn't it? If you don't have the nodename, hostname, or hash in the client name for slaves option, then you will get collisions. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev
commented on JENKINS-25559
Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
If PerforceSCM fails to resolve the client name (it happens due to unresolved EXECUTOR_NUMBER), it fall-backs to a default value without a hash.
Currently, I'm working on this issue. The proper way would be to limit the number of nested recursions in buildEnvVars() by 2 instead of 1 (current implementation)
private String getEffectiveClientName(@Nonnull AbstractBuild build, @CheckForNull MapString,String env)
throws ParameterSubstitutionException, InterruptedException {
Node buildNode = build.getBuiltOn();
FilePath workspace = build.getWorkspace();
String effectiveP4Client = this.p4Client;
try Unknown macro: {
effectiveP4Client = getEffectiveClientName(effectiveP4Client, build);
} catch (Exception e) Unknown macro: {
new StreamTaskListener(System.out).getLogger().println(
Could not get effective client name}
effectiveP4Client = MacroStringHelper.substituteParameters(effectiveP4Client, this, build, env);
return effectiveP4Client;
}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev
edited a comment on JENKINS-25559
Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
If PerforceSCM fails to resolve the client name (it happens due to unresolved EXECUTOR_NUMBER), it fall-backs to a default value without a hash.
Currently, I'm working on this issue. The proper way would be to limit the number of nested recursions in buildEnvVars() by 2 instead of 1 (current implementation)
private String getEffectiveClientName(@Nonnull AbstractBuild build, @CheckForNull MapString,String env)
throws ParameterSubstitutionException, InterruptedException {
Node buildNode = build.getBuiltOn();
FilePath workspace = build.getWorkspace();
String effectiveP4Client = this.p4Client;
try {
effectiveP4Client = getEffectiveClientName(effectiveP4Client, build);
} catch (Exception e) {
new StreamTaskListener(System.out).getLogger().println(
"Could not get effective client name: " + e.getMessage());
}
effectiveP4Client = MacroStringHelper.substituteParameters(effectiveP4Client, this, build, env);
return effectiveP4Client;
}
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev commented on JENKINS-25559 Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions Rob Petti IMO it would be preferable to completely prohibit runtime variables in client names, but it will break many use-cases. I'll try to find a convenient solution This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev started work on JENKINS-25559 Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions Change By: Oleg Nenashev (12/Nov/14 7:22 AM) Status: Open InProgress This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev
created JENKINS-25559
Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Issue Type:
Bug
Assignee:
Rob Petti
Components:
perforce-plugin
Created:
12/Nov/14 7:20 AM
Description:
This bug appears in the following conditions:
Client name contains ${EXECUTOR_NUMBER} variable
High-priority issue appears if:
Concurrent builds are enabled
No NODE_NAME variable in client name
= Missing hash in Client name = collisions in workspaces on different nodes
Project:
Jenkins
Labels:
concurrent-build
variables
environment
Priority:
Blocker
Reporter:
Oleg Nenashev
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
Oleg Nenashev assigned JENKINS-25559 to Oleg Nenashev Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions Change By: Oleg Nenashev (12/Nov/14 7:23 AM) Assignee: RobPetti OlegNenashev This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
SCM/JIRA link daemon resolved JENKINS-25559 as Fixed Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions Change By: SCM/JIRA link daemon (12/Nov/14 7:25 AM) Status: InProgress Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [perforce-plugin] (JENKINS-25559) Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions
SCM/JIRA link daemon commented on JENKINS-25559 Missing hash in client names with EXECUTOR_NUMBER leads to workspace collisions Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/perforce/PerforceSCM.java http://jenkins-ci.org/commit/perforce-plugin/b3c84d1f4db2175273dce62652fea041e8ae2ac5 Log: Merge pull request #60 from stuartrowe/master FIXED JENKINS-25559 - Don't rename remote clients in concurrent builds Compare: https://github.com/jenkinsci/perforce-plugin/compare/71dd14e84751...b3c84d1f4db2 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
