[JIRA] [promoted-builds-plugin] (JENKINS-24782) Clicking "Build Now" on a Promotion results in a phantom, unkillable build
Title: Message Title Oleg Nenashev resolved as Fixed It is fixed according to comments Jenkins / JENKINS-24782 Clicking "Build Now" on a Promotion results in a phantom, unkillable build Change By: Oleg Nenashev Status: Open Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [promoted-builds-plugin] (JENKINS-24782) Clicking "Build Now" on a Promotion results in a phantom, unkillable build
SCM/JIRA link daemon commented on JENKINS-24782 Clicking "Build Now" on a Promotion results in a phantom, unkillable build Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java http://jenkins-ci.org/commit/promoted-builds-plugin/2fe54570a00588e28c3cf9549f25af54858099f7 Log: Merge pull request #56 from recampbell/JENKINS-24782 JENKINS-24782 Prevent phantom builds from being scheduled when PromotionProcesses are built directly. Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/524772c09e5f...2fe54570a005 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [promoted-builds-plugin] (JENKINS-24782) Clicking "Build Now" on a Promotion results in a phantom, unkillable build
SCM/JIRA link daemon commented on JENKINS-24782 Clicking "Build Now" on a Promotion results in a phantom, unkillable build Code changed in jenkins User: Ryan Campbell Path: src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java http://jenkins-ci.org/commit/promoted-builds-plugin/dc858e87c6f99bb1653a1e06f354e4867e11147e Log: JENKINS-24782 Prevent phantom builds from being scheduled when PromotionProcesses are built directly. There is quite a bit more work to be done to tidy up the UX for PromotionProcesses, but at least we can prevent people from shooting themselves in the foot. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [promoted-builds-plugin] (JENKINS-24782) Clicking "Build Now" on a Promotion results in a phantom, unkillable build
Jesse Glick commented on JENKINS-24782 Clicking "Build Now" on a Promotion results in a phantom, unkillable build Customizing the sidepanel seems reasonable, though this seems too high level; there are other build triggers. Not sure what else to suggest, though. This whole plugin is very weird and a lot of things do not behave reasonably. Independently, there seems to be a robustness bug in Promotion.getTarget: should check pta == null. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [promoted-builds-plugin] (JENKINS-24782) Clicking "Build Now" on a Promotion results in a phantom, unkillable build
recampbell commented on JENKINS-24782 Clicking "Build Now" on a Promotion results in a phantom, unkillable build The fundamental problem here is that the PromotionProcess must be buildable, but should not have a "Build Now" button. To be more precise PromotionProcess must return true for isBuildable() so that AbstractProject.scheduleBuild2() will actually perform the build. So we can't just return false for isBuildable(). So it seems to me that the simplest approach is just to customize the left-hand menu for this PromotionProcess to avoid displaying the "Build Now" button. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
