[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue The new version works for me as well. @abayer, do you confirm the merge? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
abayer commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Thanks, Oleg! This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
SCM/JIRA link daemon resolved JENKINS-21044 as Fixed Throttle Concurrent Builds blocking Jenkins queue Change By: SCM/JIRA link daemon (07/Mar/14 10:21 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
SCM/JIRA link daemon commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Code changed in jenkins User: Andrew Bayer Path: src/main/java/hudson/plugins/throttleconcurrents/ThrottleJobProperty.java http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/70107b4222502935a9e46beffa31daae2e99e50b Log: Merge pull request #13 from synopsys-arc-oss/JENKINS_21044_fix FIXED JENKINS-21044 - Throttling blocks the Jenkins queue Compare: https://github.com/jenkinsci/throttle-concurrent-builds-plugin/compare/dc16282a90b7...70107b422250 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
SCM/JIRA link daemon commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/throttleconcurrents/ThrottleJobProperty.java http://jenkins-ci.org/commit/throttle-concurrent-builds-plugin/c453516716079248d74ce588efc0293669e6e1a7 Log: JENKINS-21044 - Don't create a new HashMap after the load operation Signed-off-by: Oleg Nenashev o.v.nenas...@gmail.com This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Dirk Kuypers commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue We are testing the attached version in our production environment since about 4 hours now. Works like a charm until now. We are consolidating two jenkins masters into one machine with about 15 Slaves now, 3000 jobs altogether and quite some continuously running jobs with concurrent builds that are heavily loading the about 100 cores. We even had severe problems with blocked threads when we rolled back to 1.8.0! Funny enough I was using the version 1.8.1 on "my" old master without problems before (even more jobs, same amount of nodes) and using the throttle concurrent builds plugin was "my" idea. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Jesse Glick commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue While that PR may work, I think it would be better to just make the cache be transient. I never had any intention of its being persisted to disk, so if that is what is happening, that was purely an accident (XStream automagically finding stuff and saving it). The cache would just need to be recreated if and when a job category is changed or the cache is requested, but that is pretty simple synchronization. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue @Jesse I've made the cache transient. All other changes just provide the safe migration procedure if there is any cache data on the disk. The load procedure is synchronized to avoid concurrency. After that, the code just re-saves the configuration in order to purge wrong data from configs. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev updated JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Added the local build with a probable fix. https://github.com/jenkinsci/throttle-concurrent-builds-plugin/pull/13 I've tried about 10 restarts with big queues, but the issue has not been reproduced. BTW, it would be great to have a light-weight unit test. Change By: Oleg Nenashev (22/Feb/14 10:13 PM) Attachment: throttle-concurrents.hpi This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Tim Pizey commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue I agree with abayer. We have lost many person hours by assuming no harm would come from installing this update. This is the first time in my use of jenkins that updating to the latest version has bitten me. There should be a mechanism to prevent a plugin with such an issue being presented to end users. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue We have lost many person hours by assuming no harm would come from installing this update. There is a notification on the plugin's Wiki page This is the first time in my use of jenkins that updating to the latest version has bitten me. Heh, you are really lucky. BTW, you are right that such approach hardly affects users. I'm responsible for this f*ckup, because I've released a version without long-run testing on development servers. BTW, we have been waiting for @abayer's review of PR #6 and PR #10 for more than 1 month... There should be a mechanism to prevent a plugin with such an issue being presented to end users. AFAIK in the open-source version of update center there is no such features. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Marcel Wiederkehr commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue We had the same issue after updating the plugins. After many hours we could identify the issue in this plugin (and found the warning on the wiki page). I have a relevant system. You can send me the test build to test the fix. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
abayer commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Oleg - sorry about that. I get so many PR emails from all of the Jenkins repos that I don't notice all of the relevant ones. IF there's anything you need a review on now, I can take a look, but in general, I trust Jesse to be better than me at knowing what code's likely to cause issues anyway. =) This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Jesse Glick commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue I could prototype a fix if my help is needed, but I have no realistic test environment for it. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Finally, I have reproduced the issue. It occurs on configuration-reload operations with many jobs. According to comments above, the internal categories cache is being dumped to hudson.plugins.throttleconcurrents.ThrottleJobProperty.xml The property's loading operations are not synchronized Seems that ThrottleQueueTaskDispatcher tries to access the data before the complete loading of the plugin's configuration. In my case it occurs during the queue's loading I'll create the PR soon. BTW, we will have to add an additional lock object to prevent issues on persistence. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue @abayer I've started working on the issue. BTW, I cannot re-test the fix now due to the vacation. If somebody has a relevant dev. system, I can provide a test build. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Jesse Glick commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue propertiesByCategory is not intended to be serialized at all, so that is probably the issue. May need to be made transient (and restored in readResolve); or making it static might suffice. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
centic commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Some more info for anybody trying to work on this, I did some more investigation and found out the following: Replacing the WeakHashMap with HashMap is tricky as the configuration XML of the plugin also contains the type of Map, so you need to replace it there as well otherwise you'll still end up with WeakHashMaps (cost me a couple hours to find that out!) I think this is also the reason why the problem happens in the first place, the config-serialization is reflection-based and constructs the WeakHashMap outside of the synchronization, thus multiple threads still can access the data concurrently and because of this no synchronization whatsoever will fix it! That also explains why you do not see it always. It only happens if you have a number of throttles defined and use them in multiple jobs. Also starting up will sometimes work, but it may still fail later when the properties are accessed when jobs are started. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Jesse Glick commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue No idea for a fix from me, sorry. The tip about unsynchronized access sounds plausible, but as you note, all accesses to the map should be synchronized from the same monitor. If you can reproduce the bug, then there are various ways of proceeding with debugging, such as switching to a (strong) HashMap to see if the endless loop goes away; this would of course introduce a memory leak, but at least you would have narrowed down the problem. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Michael Niestegge edited a comment on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue I ran into the same problems now: I use Jenkins 1.547 on Debian 5.0.10 with Throttle Concurrent Builds 1.8.1 At midnight several jobs are triggered which are in the same group causing Jenkins webinterface to freeze (process at ~100% cpu). The only solution is to kill the process. After removing the plugin everything runs fine again. In my opinion the plugin is not usable as long as the error is not fixed. Switching back to 1.8 solved the issue for me. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue @centic, for the issue's analysis The issue has been introduce by https://github.com/jenkinsci/throttle-concurrent-builds-plugin/commit/b1f3b836ecd1fbd7a141c89469635c1ca5838dcf committed by @glick I home to find some time to fix the issue on the next week (probably, Jesse will do it before me) I'll put the info to the plugin's page as well. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev updated JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Change By: Oleg Nenashev (27/Jan/14 7:47 AM) Priority: Critical Blocker This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Geoff Cummings created JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Issue Type: Bug Affects Versions: current Assignee: abayer Components: throttle-concurrents Created: 17/Dec/13 2:34 PM Description: Jenkins had stopped responding to browser requests for Jenkins pages and I think it may be caused by the recent upgrade to Throttle Concurrent Builds 1.8.1 Requests were getting blocked waiting on 0x0004181e4520 "Handling GET /jenkins/ : RequestHandlerThread[#171]" daemon prio=10 tid=0x168ee800 nid=0x193b waiting for monitor entry [0x4335b000] java.lang.Thread.State: BLOCKED (on object monitor) at hudson.model.Queue.getItems(Queue.java:687) - waiting to lock 0x0004181e4520 (a hudson.model.Queue) at hudson.model.Queue$CachedItemList.get(Queue.java:216) at hudson.model.Queue.getApproximateItemsQuickly(Queue.java:717) at hudson.model.View.getApproximateQueueItemsQuickly(View.java:483) at sun.reflect.GeneratedMethodAccessor355.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) This seems to be waiting on Throttle Concurrent Builds code. Further dumps after 10 minutes, 20 minutes and 30 minutes showed this same stack trace. "Thread-126" daemon prio=10 tid=0x2aaae0529800 nid=0x1785 runnable [0x4659] java.lang.Thread.State: RUNNABLE at java.util.WeakHashMap$HashIterator.hasNext(WeakHashMap.java:875) at java.util.AbstractCollection.toArray(AbstractCollection.java:139) at java.util.ArrayList.init(ArrayList.java:164) at hudson.plugins.throttleconcurrents.ThrottleJobProperty.getCategoryProjects(ThrottleJobProperty.java:141) - locked 0x00041a79b778 (a java.util.HashMap) at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canRun(ThrottleQueueTaskDispatcher.java:118) at hudson.plugins.throttleconcurrents.ThrottleQueueTaskDispatcher.canRun(ThrottleQueueTaskDispatcher.java:90) at hudson.model.Queue.isBuildBlocked(Queue.java:937) at hudson.model.Queue.maintain(Queue.java:1006) - locked 0x0004181e4520 (a hudson.model.Queue) at hudson.model.Queue$1.call(Queue.java:303) at hudson.model.Queue$1.call(Queue.java:300) at jenkins.util.AtmostOneTaskExecutor$1.call(AtmostOneTaskExecutor.java:69) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:104) at java.lang.Thread.run(Thread.java:724) Locked ownable synchronizers: - None CPU usage was at ~100% for this thread for the 30 minutes that I was watching it before I restarted Jenkins. (6021 = 0x1785) PID USER PR NI VIRT RES SHR S %CPU %MEMTIME+ COMMAND 6021 rcbuild_ 35 10 18.0g 6.2g 32m R 99.7 19.7 30:45.97 java I have rolled back to Throttle Concurrent Builds 1.8 for now. Still learning how to investigate thread dumps but please let me know if there is anything I can do to help. Environment: Jenkins 1.544 Project: Jenkins Priority: Critical Reporter: Geoff Cummings This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev commented on JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Could you briefly describe your case (number of projects, categories structure, frequency of job submissions, etc.)? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Oleg Nenashev assigned JENKINS-21044 to Jesse Glick Throttle Concurrent Builds blocking Jenkins queue BTW, I confirm that the current implementation may cause huge calculation efforts in the case of big number of jobs with a same category: keySet() causes a useless copy of the data copy to a new array leads to an additional copy of items It makes sense to extend a the cache's lock time, but to iterate the HashMap directly. I'll reassign issue to Jesse Glick, who is an author of https://github.com/jenkinsci/throttle-concurrent-builds-plugin/pull/10 Jesse, do you have some time to fix the issue? If no, I can do it on my own Change By: Oleg Nenashev (17/Dec/13 5:39 PM) Assignee: OlegNenashev JesseGlick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Jesse Glick updated JENKINS-21044 Throttle Concurrent Builds blocking Jenkins queue Change By: Jesse Glick (17/Dec/13 6:15 PM) Labels: performance This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[JIRA] [throttle-concurrents] (JENKINS-21044) Throttle Concurrent Builds blocking Jenkins queue
Jesse Glick assigned JENKINS-21044 to Oleg Nenashev Throttle Concurrent Builds blocking Jenkins queue I do not actually run this plugin anywhere so I have no real way of confirming whether a given change improves or degrades performance on a large installation. Extending the scope of the lock on propertiesByCategory may avoid overhead, but runs the risk of deadlocks, if foreign calls such as getItem are included. Change By: Jesse Glick (17/Dec/13 6:17 PM) Assignee: JesseGlick OlegNenashev This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
