[JIRA] [virtualbox-plugin] (JENKINS-16231) Stop slave options should list all possible options, not just save and poweroff
Henri Gomez commented on JENKINS-16231 Stop slave options should list all possible options, not just save and poweroff What about PR, so I could review it and apply. Side note, I'm not using VB Plugin anymore. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [virtualbox-plugin] (JENKINS-16231) Stop slave options should list all possible options, not just save and poweroff
p r commented on JENKINS-16231 Stop slave options should list all possible options, not just save and poweroff But with the option to actually have an acpipowerbutton option the end user can set what action is taken when that acpi button is pressed. End users have to setup what action is taken when that signal is received it does not just automatically send the OS the proper shutdown command for a clean and safe shutdown. Using the poweroff is essentially the same as pulling the power cord from a box. That is not a good choice at all. Also once you send the poweroff you could easily poll to make sure it is not running anymore through checking what is left running or just checking the state of said machine that just got the acpi button press signal. Just my opinion and the biggest downfall I see to this plugin. Not everyone wants or needs to save state and really no one should use the poweroff command unless you want to corrupt your file system VERY quickly. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [virtualbox-plugin] (JENKINS-16231) Stop slave options should list all possible options, not just save and poweroff
p r edited a comment on JENKINS-16231 Stop slave options should list all possible options, not just save and poweroff But with the option to actually have an acpipowerbutton option the end user can set what action is taken when that acpi button is pressed. End users have to setup what action is taken when that signal is received it does not just automatically send the OS the proper shutdown command for a clean and safe shutdown. Using the poweroff is essentially the same as pulling the power cord from a box. That is not a good choice at all. Also once you send the acpipoweroff you could easily poll to make sure it is not running anymore through checking what is left running or just checking the state of said machine that just got the acpi button press signal. Just my opinion and the biggest downfall I see to this plugin. Not everyone wants or needs to save state and really no one should use the poweroff command unless you want to corrupt your file system VERY quickly. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [virtualbox-plugin] (JENKINS-16231) Stop slave options should list all possible options, not just save and poweroff
p r edited a comment on JENKINS-16231 Stop slave options should list all possible options, not just save and poweroff But with the option to actually have an acpipowerbutton option the end user can set what action is taken when that acpi button is pressed. End users have to setup what action is taken when that signal is received it does not just automatically send the OS the proper shutdown command for a clean and safe shutdown in every OS. Using the poweroff is essentially the same as pulling the power cord from a box. That is not a good choice at all. Also once you send the acpipoweroff you could easily poll to make sure it is not running anymore through checking what is left running or just checking the state of said machine that just got the acpi button press signal. Just my opinion and the biggest downfall I see to this plugin. Not everyone wants or needs to save state and really no one should use the poweroff command unless you want to corrupt your file system VERY quickly. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
