[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2016-04-05 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-23080 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: standalone "println" should work like "echo" step  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Kohsuke Kawaguchi Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/fa4ad11f6a8d5f810641bca171cd13c6d3484216 Log: 

JENKINS-23080
 
Get rid of the FlowExecutionOwner.getConsole() method, and implement print in terms of echo step. 
This doesn't handle print() without NL correctly. For that, FlowNode needs to be explicitly added with log, and adjacent print family calls need to be smart enough to combine their outputs into a single FlowNode. 
I don't have cycles to do that right now, but this change at least removes unwanted call from API. 
Originally-Committed-As: bf734ffebe47a67b88638bd398ff7f39e2856eeb 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2016-04-05 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-23080 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: standalone "println" should work like "echo" step  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Kohsuke Kawaguchi Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-job-plugin/e3c89c5cf844cf277c745dc6fc7a4b52489043ba Log: 

JENKINS-23080
 
Make sure println actually produce something into the log 
Originally-Committed-As: 5c79a859e337b7a6c616e7e6687d29aa09c02cab 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2016-04-05 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-23080 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: standalone "println" should work like "echo" step  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Kohsuke Kawaguchi Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java cps/src/test/groovy/org/jenkinsci/plugins/workflow/cps/AbstractCpsFlowTest.groovy http://jenkins-ci.org/commit/workflow-cps-plugin/9a0d14e720df80bcbde319d917e27bd8e2eb2e0c Log: 

JENKINS-23080
 
Get rid of the FlowExecutionOwner.getConsole() method, and implement print in terms of echo step. 
This doesn't handle print() without NL correctly. For that, FlowNode needs to be explicitly added with log, and adjacent print family calls need to be smart enough to combine their outputs into a single FlowNode. 
I don't have cycles to do that right now, but this change at least removes unwanted call from API. 
Originally-Committed-As: bf734ffebe47a67b88638bd398ff7f39e2856eeb 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2016-04-05 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-23080 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: standalone "println" should work like "echo" step  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Kohsuke Kawaguchi Path: basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/EchoStep.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/082cbdab0381a3665c34e89242e462e59ccbfbba Log: 

JENKINS-23080
 
Get rid of the FlowExecutionOwner.getConsole() method, and implement print in terms of echo step. 
This doesn't handle print() without NL correctly. For that, FlowNode needs to be explicitly added with log, and adjacent print family calls need to be smart enough to combine their outputs into a single FlowNode. 
I don't have cycles to do that right now, but this change at least removes unwanted call from API. 
Originally-Committed-As: bf734ffebe47a67b88638bd398ff7f39e2856eeb 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2016-04-05 Thread scm_issue_l...@java.net (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 SCM/JIRA link daemon commented on  JENKINS-23080 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: standalone "println" should work like "echo" step  
 
 
 
 
 
 
 
 
 
 
Code changed in jenkins User: Kohsuke Kawaguchi Path: api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionOwner.java http://jenkins-ci.org/commit/workflow-api-plugin/1675773cee5e884b2ef2fd4ee147101d2c9e7cc7 Log: 

JENKINS-23080
 
Get rid of the FlowExecutionOwner.getConsole() method, and implement print in terms of echo step. 
This doesn't handle print() without NL correctly. For that, FlowNode needs to be explicitly added with log, and adjacent print family calls need to be smart enough to combine their outputs into a single FlowNode. 
I don't have cycles to do that right now, but this change at least removes unwanted call from API. 
Originally-Committed-As: bf734ffebe47a67b88638bd398ff7f39e2856eeb 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2014-11-19 Thread k...@kohsuke.org (JIRA)















































Kohsuke Kawaguchi
 resolved  JENKINS-23080 as Fixed


standalone "println" should work like "echo" step
















Change By:


Kohsuke Kawaguchi
(19/Nov/14 6:20 PM)




Status:


Open
Resolved





Resolution:


Fixed



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2014-11-18 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-23080


standalone "println" should work like "echo" step















Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
 aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java
http://jenkins-ci.org/commit/workflow-plugin/5c79a859e337b7a6c616e7e6687d29aa09c02cab
Log:
  JENKINS-23080

Make sure println actually produce something into the log





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2014-11-18 Thread scm_issue_l...@java.net (JIRA)














































SCM/JIRA link daemon
 commented on  JENKINS-23080


standalone "println" should work like "echo" step















Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
 api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionOwner.java
 basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/EchoStep.java
 cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScript.java
 cps/src/test/groovy/org/jenkinsci/plugins/workflow/cps/AbstractCpsFlowTest.groovy
 job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
http://jenkins-ci.org/commit/workflow-plugin/bf734ffebe47a67b88638bd398ff7f39e2856eeb
Log:
  JENKINS-23080

Get rid of the FlowExecutionOwner.getConsole() method, and implement print in terms of echo step.

This doesn't handle print() without NL correctly. For that, FlowNode needs to be explicitly added with log, and adjacent print family calls need to be smart enough to combine their outputs into a single FlowNode.

I don't have cycles to do that right now, but this change at least removes unwanted call from API.





























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2014-11-18 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 commented on  JENKINS-23080


standalone "println" should work like "echo" step















Perhaps just rename echo to println, delete the getConsole trick, and be done? Incompatible for some existing scripts of course.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2014-11-18 Thread k...@kohsuke.org (JIRA)














































Kohsuke Kawaguchi
 commented on  JENKINS-23080


standalone "println" should work like "echo" step















I'll have to get rid of the getConsole() method. I think my plan was to implement println() as if it were an alias to the echo step, so that it creates a new step and all that to record the output.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] [workflow-plugin] (JENKINS-23080) standalone "println" should work like "echo" step

2014-11-05 Thread jgl...@cloudbees.com (JIRA)














































Jesse Glick
 commented on  JENKINS-23080


standalone "println" should work like "echo" step















Are you planning on doing this in the 1.0 timeframe? After that, getConsole is locked into the API.



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira







-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.