[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/b4563b1d993293d0f7011f21a0b8a7903878edfa Log: JENKINS-29221 If a build fails to start, make sure we still perform all relevant steps as if it finished normally. Originally-Committed-As: 7db48c88df0ac3b35d489f6275b9f7e4d88de85c Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/682638de3356695d2f5629c89fd7eb36248d569a Log: WorkflowRun.execution must be set before the execution starts. Otherwise Owner.get can throw an error claiming that the build has not started yet. We do need to null out the field if starting fails, but we can do that subsequently. Amends the fix of JENKINS-29221 in #149, which introduced this race condition. Originally-Committed-As: 99ca243654430737de5f3be6367c9b24ccfdf5bb Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: tfennelly Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/0827836fe4aad44feae99be53b0d825952a551f9 Log: [FIXED JENKINS-29221] WorkflowRun assigned FlowExecution when execution start fails Originally-Committed-As: adeaf564a94ee6f82861e4253bd2d5bbc22276c4 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/99ca243654430737de5f3be6367c9b24ccfdf5bb Log: WorkflowRun.execution must be set before the execution starts. Otherwise Owner.get can throw an error claiming that the build has not started yet. We do need to null out the field if starting fails, but we can do that subsequently. Amends the fix of JENKINS-29221 in #149, which introduced this race condition. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/7db48c88df0ac3b35d489f6275b9f7e4d88de85c Log: JENKINS-29221 If a build fails to start, make sure we still perform all relevant steps as if it finished normally. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: tfennelly Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/adeaf564a94ee6f82861e4253bd2d5bbc22276c4 Log: [FIXED JENKINS-29221] WorkflowRun assigned FlowExecution when execution start fails Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails Code changed in jenkins User: Tom Fennelly Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/WorkflowRunTest.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-plugin/727f2462606a32c026eaf716952ee0a0df7490fc Log: Merge pull request #149 from tfennelly/ JENKINS-29221 [FIXED JENKINS-29221] WorkflowRun assigned FlowExecution when execution start fails Compare: https://github.com/jenkinsci/workflow-plugin/compare/06cb328979c8...727f2462606a Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-29221 WorkflowRun assigned FlowExecution when execution start fails Change By: SCM/JIRA link daemon Status: InProgress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title Tom FENNELLY started work on JENKINS-29221 Change By: Tom FENNELLY Status: Open InProgress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title
Tom FENNELLY commented on JENKINS-29221
Re: WorkflowRun assigned FlowExecution when execution start fails
To reproduce, create a build with a bad script that fails the start of the run:
{{stage 'dev'
def hello = new HelloWorld()
public class HelloWorld()
{ // - invalid class definition }
}}
Add Comment
This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265)
--
You received this message because you are subscribed to the Google Groups Jenkins Issues group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title Tom FENNELLY created an issue Jenkins / JENKINS-29221 WorkflowRun assigned FlowExecution when execution start fails Issue Type: Bug Assignee: Tom FENNELLY Components: workflow-plugin Created: 03/Jul/15 7:01 PM Priority: Major Reporter: Tom FENNELLY WorkflowRun initialises its execution property before the execution is started. If the start fails, the Run is left with an execution instance that is considered to be in progress. Add Comment
[JIRA] [workflow-plugin] (JENKINS-29221) WorkflowRun assigned FlowExecution when execution start fails
Title: Message Title Tom FENNELLY commented on JENKINS-29221 Re: WorkflowRun assigned FlowExecution when execution start fails PR #149 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
