[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/35a9115af586c5c0f3283e9cbebcab62c647c7ee Log: [FIXED JENKINS-30055] The listener which closes flow graph log files must receive events immediately, and unregister itself. Originally-Committed-As: 1084a9bd2495989bb78e013c08c8348542e7955f Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/FlowHead.java http://jenkins-ci.org/commit/workflow-cps-plugin/630edfb4313db63d01f6eb135cbce7081f496fae Log: [FIXED JENKINS-30055] The listener which closes flow graph log files must receive events immediately, and unregister itself. Originally-Committed-As: 1084a9bd2495989bb78e013c08c8348542e7955f Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/ScalabilityTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/storage/SimpleXStreamFlowNodeStorage.java http://jenkins-ci.org/commit/workflow-support-plugin/ad18aafe913d801eeb88594d89b176df024495b4 Log: Reproduced the originally reported exception from JENKINS-30055 , perhaps independent of JENKINS-30651 . Originally-Committed-As: d3dc35a0f511610bd5ca56ea44317c4200c4953a Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/ScalabilityTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java http://jenkins-ci.org/commit/workflow-support-plugin/8379c0d2a7c4e36de305db68bc54acc2418b7c47 Log: [FIXED JENKINS-30055] The listener which closes flow graph log files must receive events immediately, and unregister itself. Originally-Committed-As: 1084a9bd2495989bb78e013c08c8348542e7955f Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java http://jenkins-ci.org/commit/workflow-api-plugin/f697e0cfd884f7106cb7066364b2eb372206c6a7 Log: [FIXED JENKINS-30055] The listener which closes flow graph log files must receive events immediately, and unregister itself. Originally-Committed-As: 1084a9bd2495989bb78e013c08c8348542e7955f Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/ScalabilityTest.java api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java api/src/main/java/org/jenkinsci/plugins/workflow/flow/GraphListener.java api/src/main/java/org/jenkinsci/plugins/workflow/graph/BlockEndNode.java api/src/main/java/org/jenkinsci/plugins/workflow/graph/FlowNode.java api/src/main/java/org/jenkinsci/plugins/workflow/graph/ForkNode.java api/src/main/java/org/jenkinsci/plugins/workflow/graph/JoinNode.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/FlowHead.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java support/src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java support/src/main/java/org/jenkinsci/plugins/workflow/support/storage/SimpleXStreamFlowNodeStorage.java http://jenkins-ci.org/commit/workflow-plugin/0fdf534bce127223058749643753e2e9206fd448 Log: Merge pull request #213 from jglick/many-steps- JENKINS-30055 JENKINS-30055 Handle a large number of steps in quick succession Compare: https://github.com/jenkinsci/workflow-plugin/compare/97ce55c78e77...0fdf534bce12 Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon resolved as Fixed Jenkins / JENKINS-30055 Simple script with "long" loop created unloadable flow Change By: SCM/JIRA link daemon Status: In Progress Resolved Resolution: Fixed Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/ScalabilityTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/storage/SimpleXStreamFlowNodeStorage.java http://jenkins-ci.org/commit/workflow-plugin/d3dc35a0f511610bd5ca56ea44317c4200c4953a Log: Reproduced the originally reported exception from JENKINS-30055 , perhaps independent of JENKINS-30651 . Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title SCM/JIRA link daemon commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Code changed in jenkins User: Jesse Glick Path: CHANGES.md aggregator/src/test/java/org/jenkinsci/plugins/workflow/ScalabilityTest.java api/src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/FlowHead.java job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java support/src/main/java/org/jenkinsci/plugins/workflow/support/DefaultStepContext.java http://jenkins-ci.org/commit/workflow-plugin/1084a9bd2495989bb78e013c08c8348542e7955f Log: [FIXED JENKINS-30055] The listener which closes flow graph log files must receive events immediately, and unregister itself. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title Jesse Glick started work on JENKINS-30055 Change By: Jesse Glick Status: Open In Progress Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-30055 Simple script with "long" loop created unloadable flow Change By: Jesse Glick Labels: random performance robustness Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with "long" loop created unloadable flow
Title: Message Title Jesse Glick commented on JENKINS-30055 Re: Simple script with "long" loop created unloadable flow Rather a file descriptor leak; the listener in DefaultStepContext gets notified asynchronously, so not fast enough to close the log files from completed steps. Also a failure to ever remove the listener results in a quadratic slowdown. With that fixed, the insertion of sleep unit: 'MILLISECONDS', time: 1 inside the loop lets it work, but without that extra pause the notifications just pile up undelivered and the error occurs. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with long loop created unloadable flow
Title: Message Title Jesse Glick updated an issue Jenkins / JENKINS-30055 Simple script with long loop created unloadable flow Change By: Jesse Glick Labels: randomrobustness Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with long loop created unloadable flow
Title: Message Title Jesse Glick commented on JENKINS-30055 Re: Simple script with long loop created unloadable flow Smells like a race condition: perhaps a reference to a new flow node is saved before the node itself is. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with long loop created unloadable flow
Title: Message Title
Tom FENNELLY created an issue
Jenkins / JENKINS-30055
Simple script with long loop created unloadable flow
Issue Type:
Bug
Assignee:
Jesse Glick
Components:
workflow-plugin
Created:
20/Aug/15 12:49 PM
Priority:
Major
Reporter:
Tom FENNELLY
Create a workflow with a simple script containing a loop with e.g. 1000 iterations:
node {
stage 'Build'
for (int i = 0; i 1000; i++) {
echo hello: ${i}
}
}
Run the job a few times. Restart jenkins and try loading the job. you should see an error like:
*** java.lang.instrument ASSERTION FAILED ***: !errorOutstanding with message transform method call failed at ../../../src/share/instrument/JPLISAgent.c line: 844
Aug 20, 2015 1:09:35 PM org.jenkinsci.plugins.workflow.job.WorkflowRun onLoad
WARNING: null
java.io.IOException: failed to load flow node from /Users/tfennelly/projects/jenkins-plugins/cloudbees-workflow-plugin/aggregator/work/jobs/WWW/builds/5/workflow/1008.xml
at org.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage$PersistenceContext.loadInner(SimpleXStreamFlowNodeStorage.java:227)
at org.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage$PersistenceContext.loadOuter(SimpleXStreamFlowNodeStorage.java:213)
at
[JIRA] [workflow-plugin] (JENKINS-30055) Simple script with long loop created unloadable flow
Title: Message Title
Tom FENNELLY updated an issue
Jenkins / JENKINS-30055
Simple script with long loop created unloadable flow
Change By:
Tom FENNELLY
Createaworkflowwithasimplescriptcontainingaloopwithe.g.1000iterations:{code:java}node{ stage'Build' for(inti=0;i1000;i++){ echohello:${i} }}{code}Runthejobafewtimes.Restartjenkinsandtryloadingthejob . , youshouldseeanerrorlike:{code}***java.lang.instrumentASSERTIONFAILED***:!errorOutstandingwithmessagetransformmethodcallfailedat../../../src/share/instrument/JPLISAgent.cline:844Aug20,20151:09:35PMorg.jenkinsci.plugins.workflow.job.WorkflowRunonLoadWARNING:nulljava.io.IOException:failedtoloadflownodefrom/Users/tfennelly/projects/jenkins-plugins/cloudbees-workflow-plugin/aggregator/work/jobs/WWW/builds/5/workflow/1008.xml atorg.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage$PersistenceContext.loadInner(SimpleXStreamFlowNodeStorage.java:227) atorg.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage$PersistenceContext.loadOuter(SimpleXStreamFlowNodeStorage.java:213) atorg.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage$PersistenceContext.access$100(SimpleXStreamFlowNodeStorage.java:185) atorg.jenkinsci.plugins.workflow.support.storage.SimpleXStreamFlowNodeStorage.getNode(SimpleXStreamFlowNodeStorage.java:87) atorg.jenkinsci.plugins.workflow.cps.CpsFlowExecution.initializeStorage(CpsFlowExecution.java:397) atorg.jenkinsci.plugins.workflow.cps.CpsFlowExecution.onLoad(CpsFlowExecution.java:413) atorg.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:380) athudson.model.RunMap.retrieve(RunMap.java:223) athudson.model.RunMap.retrieve(RunMap.java:57) atjenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:465) atjenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:448) atjenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:356) atjenkins.model.lazy.LazyBuildMixIn.getBuildByNumber(LazyBuildMixIn.java:226) atorg.jenkinsci.plugins.workflow.job.WorkflowJob.getBuildByNumber(WorkflowJob.java:199) atorg.jenkinsci.plugins.workflow.job.WorkflowJob.getBuildByNumber(WorkflowJob.java:92) atjenkins.model.PeepholePermalink.resolve(PeepholePermalink.java:95) athudson.model.Job.getLastSuccessfulBuild(Job.java:888) atjenkins.tasks.SimpleBuildStep$LastBuildActionFactory.createFor(SimpleBuildStep.java:111) atjenkins.tasks.SimpleBuildStep$LastBuildActionFactory.createFor(SimpleBuildStep.java:101) athudson.model.Actionable.createFor(Actionable.java:107) athudson.model.Actionable.getAllActions(Actionable.java:98) atsun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethod) atsun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) atsun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) atjava.lang.reflect.Method.invoke(Method.java:606) atorg.apache.commons.jexl.util.PropertyExecutor.execute(PropertyExecutor.java:125) atorg.apache.commons.jexl.util.introspection.UberspectImpl$VelGetterImpl.invoke(UberspectImpl.java:314) atorg.apache.commons.jexl.parser.ASTArrayAccess.evaluateExpr(ASTArrayAccess.java:185) atorg.apache.commons.jexl.parser.ASTIdentifier.execute(ASTIdentifier.java:75)
