[JIRA] [zaproxy-plugin] (JENKINS-29686) ZAP process is left running if build is aborted
Title: Message Title Rogerio Peixoto commented on JENKINS-29686 Re: ZAP process is left running if build is aborted It's happening here, I'm using ZAP 2.4.2 core version. I installed it using custom tool plugin. And I always get a message "Cannot listen on port " on a second run of the job. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [zaproxy-plugin] (JENKINS-29686) ZAP process is left running if build is aborted
Title: Message Title Dave Hunt commented on JENKINS-29686 Re: ZAP process is left running if build is aborted I've been unable to replicate this today, but I did notice that if I abort a build it's marked as successful instead of aborted. I still think it's worth switching the plugin to a build wrapper rather than a build step, and I've been able to implement a simple start/stop wrapper here: https://github.com/jenkinsci/zaproxy-plugin/compare/master...davehunt:build-wrapper I stopped there because I'm not sure I fully understand the plugin architecture enough. With some guidance I'd be happy to continue. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [zaproxy-plugin] (JENKINS-29686) ZAP process is left running if build is aborted
Title: Message Title Ludovic Roucoux commented on JENKINS-29686 Re: ZAP process is left running if build is aborted Hum, this should not happen because when an exception is catched, zap is stop in a finally bloc. Unfortunately, I have no time to work on the plugin for the moment. If you want, you can take a look an why not, make a pull request to correct this bug. Thank you for your feedback. Ludovic, Regards. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [zaproxy-plugin] (JENKINS-29686) ZAP process is left running if build is aborted
Title: Message Title Dave Hunt created an issue Jenkins / JENKINS-29686 ZAP process is left running if build is aborted Issue Type: Bug Assignee: Ludovic Roucoux Components: zaproxy-plugin Created: 28/Jul/15 3:17 PM Priority: Critical Reporter: Dave Hunt If a build with ZAP running is aborted, the ZAP process remains alive. I discovered this when I notced that I had 10 ZAP processes still running! I think if the plugin was changed to a BuildWrapper it may simplify configuration and allow for proper termination of the process. This way there'd be a checkbox in the Build Environment to indicate that you want a ZAP process to be started. The Admin and Startup configuration could then be moved to this section, and environment variables such as ZAP_HOST, ZAP_PORT, etc. could be exposed for the build steps. Here's an example tearDown that handles clean up in a plugin I've worked on: https://github.com/mozilla/testdroid-marionette-plugin/blob/master/src/main/java/jenkins/plugins/testdroid/DeviceSessionWrapper.java#L226 Add Comment