[JIRA] (JENKINS-55843) Folders missed due to anonymization in the bundle
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-55843 Folders missed due to anonymization in the bundle Issue Type: Bug Assignee: Ramon Leon Components: support-core-plugin Created: 2019-01-29 16:36 Priority: Major Reporter: Ramon Leon When the anonymization is enabled and the instance has an element with the name "/", or any other name containing the slash, the folders in the bundle are missed and instead of that, files are generated. It's possible to have such a name, for example with labels. "/", "a/b", ... In the zip, you should have: jenkins-root-configuration-files/build-failure-analyzer.xml But you get: jenkins-root-configuration-files*user_steep_lung*build-failure-analyzer.xml The / is replaced by user_steep_lung. Add Comment
[JIRA] (JENKINS-55843) Folders missed due to anonymization in the bundle
Title: Message Title Ramon Leon started work on JENKINS-55843 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55843) Folders missed due to anonymization in the bundle
Title: Message Title Ramon Leon updated JENKINS-55843 Jenkins / JENKINS-55843 Folders missed due to anonymization in the bundle Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55866) Anonymize by words
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-55866 Anonymize by words Issue Type: Bug Assignee: Ramon Leon Components: support-core-plugin Created: 2019-01-30 12:23 Priority: Major Reporter: Ramon Leon Change how the replacements take place when anonymizing the support bundle. It seems like the process doesn't replace by words. Acceptance criteria: Job with name some in the instance. The ContentMapping for the anonymization becomes some -> randomname. Then: Text in log: It's an awesome message thrown in some place of the code Currently: It's an awe*randomname*some message thrown in randomname place of the code Desired: It's an awesome message thrown in randomname place of the code It could help to make the bundle more readable without losing protection of sensitive information. Add Comment
[JIRA] (JENKINS-55866) Anonymize by words
Title: Message Title Ramon Leon started work on JENKINS-55866 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56982) Close the connection while restarting to avoid tests hung
Title: Message Title Ramon Leon updated JENKINS-56982 Jenkins / JENKINS-56982 Close the connection while restarting to avoid tests hung Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56492) [ATH] Fix Javadoc failures on Java11
Title: Message Title Ramon Leon updated JENKINS-56492 Jenkins / JENKINS-56492 [ATH] Fix Javadoc failures on Java11 Change By: Ramon Leon Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56982) Close the connection while restarting to avoid tests hung
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-56982 Close the connection while restarting to avoid tests hung Issue Type: Bug Assignee: Ramon Leon Components: acceptance-test-harness Created: 2019-04-11 16:17 Labels: test hang stalled stuck Priority: Major Reporter: Ramon Leon We have experienced some tests getting hung/stalled/stuck (for searches ) during the execution of the ATHs. The symptom is very different tests hold in every execution and the build doesn't finish. After a lot of analysis, I've found out that it's because of the connection used for testing if Jenkins is ready not being closed. This issue may impact a lot of people, a lot of tests with very different symptoms. If you have a test restarting Jenkins in your ATH test and your tests don't finish getting hung in very different tests, perhaps you are facing this issue. Add Comment
[JIRA] (JENKINS-56982) Close the connection while restarting to avoid tests hung
Title: Message Title Ramon Leon started work on JENKINS-56982 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56928) Fix NodeLabelParameterPluginTest # run_on_online_slave_and_master_with_node_restriction. Fail with element not clickable because other obscures it
Title: Message Title Ramon Leon commented on JENKINS-56928 Re: Fix NodeLabelParameterPluginTest # run_on_online_slave_and_master_with_node_restriction. Fail with element not clickable because other obscures it PR superseded by https://github.com/jenkinsci/acceptance-test-harness/pull/501 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56928) Fix NodeLabelParameterPluginTest # run_on_online_slave_and_master_with_node_restriction. Fail with element not clickable because other obscures it
Title: Message Title Ramon Leon updated JENKINS-56928 Jenkins / JENKINS-56928 Fix NodeLabelParameterPluginTest # run_on_online_slave_and_master_with_node_restriction. Fail with element not clickable because other obscures it Change By: Ramon Leon Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56982) Close the connection while restarting to avoid tests hung
Title: Message Title Ramon Leon updated JENKINS-56982 Jenkins / JENKINS-56982 Close the connection while restarting to avoid tests hung Change By: Ramon Leon Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-56982) Close the connection while restarting to avoid tests hung
Title: Message Title Ramon Leon commented on JENKINS-56982 Re: Close the connection while restarting to avoid tests hung PR with the fix: https://github.com/jenkinsci/acceptance-test-harness/pull/502 So far so good, but it was not easy. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57518) Remove XMLUtils from the plugin when it is unrestricted in core
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57518 Remove XMLUtils from the plugin when it is unrestricted in core Issue Type: Improvement Assignee: Unassigned Components: credentials-plugin Created: 2019-05-17 10:37 Priority: Minor Reporter: Ramon Leon We removed the dependency to XMLUtils on core from the credentials plugin because it becomes restricted for external use. There is a PR where XMLUtils is again unrestricted: https://github.com/jenkinsci/jenkins/pull/4032 Once this PR is merged and released, we can remove the new util package and restore the dependencies with the core again. Add Comment
[JIRA] (JENKINS-57702) Schedule a job doesn't fire correctly when using Etc/GMT-XX time zones
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57702 Schedule a job doesn't fire correctly when using Etc/GMT-XX time zones Issue Type: Bug Assignee: Unassigned Components: core Created: 2019-05-27 15:17 Labels: core Priority: Minor Reporter: Ramon Leon A problem related to using time zones in the schedule to build jobs periodically: GMT-10 is the same timezone as US/Hawaii. Both, at 12:00 are 00:00 at CEST Time Zone. If you set this in the Schedule textarea of a build configuration: TZ=US/Hawaii 00 12 * * * The next execution is at 00:00 CEST => OK But, if you set this: TZ=Etc/GMT-10 00 12 * * * The next execution is at 04:00 CEST => WRONG It seems to be a bug when specifying time zones with GMT-XX.
[JIRA] (JENKINS-57761) Create JCasC tests for metrics plugin
Title: Message Title Ramon Leon updated JENKINS-57761 Jenkins / JENKINS-57761 Create JCasC tests for metrics plugin Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199707.1559209728000.19352.1559572140304%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57761) Create JCasC tests for metrics plugin
Title: Message Title Ramon Leon commented on JENKINS-57761 Re: Create JCasC tests for metrics plugin A PR with a full export/replace/restart contained in the plugin: https://github.com/jenkinsci/metrics-plugin/pull/45 Two PR doing the same, but with the generic part included in JCasC to be reusable by any plugin: https://github.com/jenkinsci/configuration-as-code-plugin/pull/908 https://github.com/jenkinsci/metrics-plugin/pull/46 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199707.1559209728000.19353.1559572260312%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57862) A wrong configuration of CasC yaml kill Jenkins startup
Title: Message Title Ramon Leon commented on JENKINS-57862 Re: A wrong configuration of CasC yaml kill Jenkins startup https://github.com/jenkinsci/configuration-as-code-plugin/issues/912 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199824.1559748979000.22094.1559753820195%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57863) CasC ciphers values already ciphered when running under test
Title: Message Title Ramon Leon commented on JENKINS-57863 Re: CasC ciphers values already ciphered when running under test https://github.com/jenkinsci/configuration-as-code-plugin/issues/913 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199825.1559751383000.22091.1559753760144%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57862) A wrong configuration of CasC yaml kill Jenkins startup
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57862 A wrong configuration of CasC yaml kill Jenkins startup Issue Type: Bug Assignee: Ewelina Wilkosz Components: configuration-as-code-plugin Created: 2019-06-05 15:36 Labels: configuration-as-code jcasc-compatibility Priority: Major Reporter: Ramon Leon While testing the CasC plugin I've found that if the yaml is wrong, Jenkins stop restarting, leaving you with an unoperational instance. Steps to reproduce: Create a yaml with ssh credentials Import this yaml Remove credentials and ssh-credentials Restart Jenkins Expected: Some settings are established, others not. Current behavior: Jenkins doesn't start. Jun 05, 2019 5:27:03 PM jenkins.InitReactorRunner$1 onTaskFailedJun 05, 2019 5:27:03 PM jenkins.InitReactorRunner$1 onTaskFailedSEVERE: Failed ConfigurationAsCode.initjava.lang.Error:
[JIRA] (JENKINS-57761) Create JCasC tests for metrics plugin
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57761 Create JCasC tests for metrics plugin Issue Type: Improvement Assignee: Ramon Leon Components: metrics-plugin Created: 2019-05-30 09:48 Labels: jcasc-compatibility Priority: Minor Reporter: Ramon Leon Add tests to metrics plugin to check the right behavior of Jenkins Configuration as Code (JCasC) with the configuration of this plugin. There is already an opened PR to do that: https://github.com/jenkinsci/metrics-plugin/pull/43 Add Comment
[JIRA] (JENKINS-57761) Create JCasC tests for metrics plugin
Title: Message Title Ramon Leon started work on JENKINS-57761 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199707.1559209728000.16527.1559209800075%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57824) Add Full JCasC test to SSH Credentials Plugin
Title: Message Title Ramon Leon commented on JENKINS-57824 Re: Add Full JCasC test to SSH Credentials Plugin PR: https://github.com/jenkinsci/ssh-credentials-plugin/pull/42 Pending of https://github.com/jenkinsci/configuration-as-code-plugin/pull/908 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199779.1559579051000.19687.1559579580221%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57824) Add Full JCasC test to SSH Credentials Plugin
Title: Message Title Ramon Leon updated JENKINS-57824 Jenkins / JENKINS-57824 Add Full JCasC test to SSH Credentials Plugin Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199779.1559579051000.19686.1559579580208%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57824) Add Full JCasC test to SSH Credentials Plugin
Title: Message Title Ramon Leon started work on JENKINS-57824 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199779.1559579051000.19685.1559579580176%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57824) Add Full JCasC test to SSH Credentials Plugin
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57824 Add Full JCasC test to SSH Credentials Plugin Issue Type: Improvement Assignee: Ramon Leon Components: ssh-credentials-plugin Created: 2019-06-03 16:24 Labels: jcasc-compatibility Priority: Minor Reporter: Ramon Leon Add a test to run Jenkins Configuration as Code (JCasC) in the plugin to certify it's compatible. It's using a new utility class created in JCasC. It's still unreleased. This task depends on this PR: https://github.com/jenkinsci/configuration-as-code-plugin/pull/908 Add Comment
[JIRA] (JENKINS-57863) CasC ciphers values already ciphered when running under test
Title: Message Title
Ramon Leon created an issue
Jenkins / JENKINS-57863
CasC ciphers values already ciphered when running under test
Issue Type:
Bug
Assignee:
Ewelina Wilkosz
Attachments:
GlobalCredentialsCiphered.yml
Components:
configuration-as-code-plugin
Created:
2019-06-05 16:16
Environment:
Jenkins 2.73.3, 2.164.1, 2.165 JCasC 1.19, 1.20-snapshot Credentials 2.19, 2.20
Labels:
jcasc-compatibility
Priority:
Major
Reporter:
Ramon Leon
Jenkins 2.73.3, 2.164.1, 2.165 when running " under test ", let's say `mvn hpi:run` or `mvn test`, ciphers the tokens even though they are ciphered in the YAML, whereas the same Jenkins running normally doesn't cipher the tokens if they are already ciphered. When configuring with the attached yml: If Jenkins is running normally (java -jar ...), in the viewExport page (View Configuration button) it shows: _ {AQAAABAQ93qR7ipIm+dYmOZ1AXqSLWDj9V+KUrHew/fiyPNoHTo=} _ The same as in the file. But when running under test, with mvn hpi:run or running integration tests (mvn package) it shows: usernamePassword: _ {AQAAABBA1e/z7rT6SsbMm5XmaDkHn0N8YeoHYRm8JltNZh68IZumi/SmbDrI+nH8Z51YNwSokbUbxkq85QMMe5CkEDLL+YNkXGcnAMwvSgTLLH71dlc=} _ basicSSHUserPrivateKey: _ {AQAAABBAb5Y+gVJlthgpEfLXRvFmnYtPqeTnxFDzNaKpRPDhpbWw70t7h4W1jI9h5u7TEafPxk6AhWmq+BoWkzAQtKLvzYFLCUwE2xNusw5nXeKVklY=} _ Even though both secrets are the same
[JIRA] (JENKINS-57862) A wrong configuration of CasC yaml kill Jenkins startup
Title: Message Title Ramon Leon commented on JENKINS-57862 Re: A wrong configuration of CasC yaml kill Jenkins startup Also if the yaml file is removed you have to edit io.jenkins.plugins.casc.CasCGlobalConfig.xml to remove the file. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199824.1559748979000.22888.1559843280161%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57761) Create JCasC tests for metrics plugin
Title: Message Title Ramon Leon updated JENKINS-57761 Released as metrics-4.0.2.4 Jenkins / JENKINS-57761 Create JCasC tests for metrics plugin Change By: Ramon Leon Status: In Review Resolved Resolution: Done Released As: 4.0.2.4 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199707.1559209728000.25905.1560337560109%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57761) Create JCasC tests for metrics plugin
Title: Message Title Ramon Leon closed an issue as Done Jenkins / JENKINS-57761 Create JCasC tests for metrics plugin Change By: Ramon Leon Status: Resolved Closed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199707.1559209728000.1620.1560770640102%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon updated JENKINS-57990 Jenkins / JENKINS-57990 Avoid filtering contents without sensible data and do per-content anonymization Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199975.1560350087000.1950.1560800580087%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon commented on JENKINS-57990 Re: Avoid filtering contents without sensible data and do per-content anonymization PR: https://github.com/jenkinsci/support-core-plugin/pull/174/files Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199975.1560350087000.1951.1560801060112%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title
Ramon Leon updated an issue
Jenkins / JENKINS-57990
Avoid filtering contents without sensible data and do per-content anonymization
Change By:
Ramon Leon
Change the behavior of the {{Contents}} to avoid filtering when it's not needed. And change the way it's anonymized by delegating it to the component to avoid losing the structure of the information.*Should be filtered* * NodesContent: include labels and filesystem path * AboutUser * AgentsConfigFile (secrets encrypted but maybe other sensitive info) * BuildQueue: name of the job * ConfigFileComponent (secrets encrypted but maybe other sensitive info) * EnvironmentVariables * JenkinsLogs * JVMProcessSystemMetricsContent (environment variables) * LoggerManager * NetworInterfaces (ips) * NodeMonitors (computer name) * OtherConfigFilesComponent * RoocCAs * SlaveLaunchLogs * SlaveLogs * SystemConfiguration Agents and Master (user running) * UpdateCenter (proxy information: urls) * SystemProperties*Shouldn’t be filtered* * AboutContent * AboutBrowser * ActivePlugins * DisabledPlugins * FailedPlugins * Dockerfile * MasterChecksumsContent * NodeChecksumsContent * AdministrativeMonitors * DeadlockRequestComponent * DumpExportTable * FileDescriptorLimit * GCLogs - Out of scope, it needs some refactor of classes. To tackle on another ticket - Done because i needed the infra for other components. * HeapUsageHistogram * ItemsContent * LoadStats * Metrics * RemotingDiagnostics * ReverseProxy * SlaveCommandStatistics * SlowRequestComponent * ThreadDumpsAvoid anonymizing the labels, the structure of the files under the control of the plugin (.md files, and information files). Analyze what values should be anonymized.The contents generated on the fly are going to extend the PrefilteredContent by creating a new *PrefilteredPrintedContent* and they are going to filter the information by themselves.The ones that are being filtered and shouldn't to will override the {{shouldBeFiltered}} method to avoid that.h3. Acceptance criteria * The support-core plugin is changed by creating a new {{PrefilteredPrintedContent}} that extends {{PrefilteredContent}} * The contents that don't need to be filtered don't do that by overriding {{shouldBeFiltered}} (false) * The contents that need to be filtered extends from a {{PrefilteredContent}}, most likely {{PrefilteredPrintedContent}} and do the filtering by themselves implementing the new {{writeTo}} method. Look at: [https://github.com/jenkinsci/support-core-plugin/blob/e2d79249818d4ea96979a710ac3404018f78/src/main/java/com/cloudbees/jenkins/support/api/StringContent.java#L58] avoiding to filter the structure of the markdown or whatever is going to affect the comprehension of the content. * Some tests are implemented for: * * * A content that was filtered and now it's not * * * A content that was filtered affecting the structure (markdown) and now it's not affected * The PR in support-core is merged
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon started work on JENKINS-57990 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199975.1560350087000.25965.1560350160104%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57990 Avoid filtering contents without sensible data and do per-content anonymization Issue Type: Bug Assignee: Ramon Leon Components: support-core-plugin Created: 2019-06-12 14:34 Priority: Minor Reporter: Ramon Leon Change the behavior of the Contents to avoid filtering when it's not needed. And change the way it's anonymized by delegating it to the component to avoid losing the structure of the information. Should be filtered NodesContent: include labels and filesystem path AboutUser AgentsConfigFile (secrets encrypted but maybe other sensitive info) BuildQueue: name of the job ConfigFileComponent (secrets encrypted but maybe other sensitive info) EnvironmentVariables JenkinsLogs
[JIRA] (JENKINS-58165) support-core doesn't take into account %t on GC logs
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-58165 support-core doesn't take into account %t on GC logs Issue Type: Bug Assignee: Emilio Escobar Components: support-core-plugin Created: 2019-06-24 13:51 Priority: Minor Reporter: Ramon Leon When you specify %t in the log file for garbage collection: Xloggc:$path/gc%t.log: specifies where the verbose GC data is written to. The %t in the gc log file path will cause the JVM to generate a new file with each JVM restart with a timestamp. From: https://go.cloudbees.com/docs/solutions/jvm-troubleshooting/ The support-core plugin cannot find the log file used for that, so it doesn't include the file in the bundle. It throws the warning: Jun 24, 2019 3:42:25 PM com.cloudbees.jenkins.support.impl.GCLogs addContents WARNING: [Support Bundle] GC Logging apparently configured, but file '/JENKINS HOME PATH/gc-%t.log' not found The reason is that the code looks for the exact file name, but it should be a pattern: https://github.com/jenkinsci/support-core-plugin/blob/5fb61461e578fa82190c8a1f1dd5efd95235702f/src/main/java/com/cloudbees/jenkins/support/impl/GCLogs.java#L80
[JIRA] (JENKINS-57090) Some Java 8 artifacts return 404 on download
Title: Message Title Ramon Leon commented on JENKINS-57090 Re: Some Java 8 artifacts return 404 on download This plugin could help: https://github.com/jenkinsci/adoptopenjdk-plugin I have my concerns (legals) about the next steps for the jdk-tool-plugin: https://github.com/jenkinsci/jdk-tool-plugin/pull/5#issuecomment-497321545 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198834.124102000.1555.1560762420353%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52600) credentials plugin uses Restricted jenkins.util.xml.XMLUtils
Title: Message Title Ramon Leon assigned an issue to Ramon Leon Jenkins / JENKINS-52600 credentials plugin uses Restricted jenkins.util.xml.XMLUtils Change By: Ramon Leon Assignee: Ramon Leon Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192443.153181715.2953.1558006680763%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52600) credentials plugin uses Restricted jenkins.util.xml.XMLUtils
Title: Message Title Ramon Leon started work on JENKINS-52600 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192443.153181715.2951.1558006680700%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52600) credentials plugin uses Restricted jenkins.util.xml.XMLUtils
Title: Message Title Ramon Leon commented on JENKINS-52600 Re: credentials plugin uses Restricted jenkins.util.xml.XMLUtils We're working on make credentials been able to be compiled on Java 11, so we need to remove this dependency: https://github.com/jenkinsci/credentials-plugin/pull/112 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192443.153181715.2948.1558006680609%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52600) credentials plugin uses Restricted jenkins.util.xml.XMLUtils
Title: Message Title Ramon Leon commented on JENKINS-52600 Re: credentials plugin uses Restricted jenkins.util.xml.XMLUtils Updated the PR to remove the dependency to restricted classes (not only XMLUtils) Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192443.153181715.220.1558017660243%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52600) credentials plugin uses Restricted jenkins.util.xml.XMLUtils
Title: Message Title Ramon Leon updated JENKINS-52600 Jenkins / JENKINS-52600 credentials plugin uses Restricted jenkins.util.xml.XMLUtils Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192443.153181715.216.1558017600281%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57223) Telemetry gathering for missing classes due to Java modules
Title: Message Title Ramon Leon edited a comment on JENKINS-57223 Re: Telemetry gathering for missing classes due to Java modules It has been tested in this scenarios: * A CNFE thrown by a `getClass().getClassLoader().loadClass` in a step implemented in a plugin * A CNFE thrown by a `Thread.currentThread().getContextClassLoader().loadClass` in a step implemented in a plugin * A CNFE thrown by a `getClass().getClassLoader().loadClass` in an action implemented in a plugin * A CNFE thrown by a `Thread.currentThread().getContextClassLoader().loadClass` in an action implemented in a plugin * A NoClassDefFoundError thrown by a call to a class moved to a module (`import sun.misc.BASE64Encoder;`) in a step implemented in a plugin Tester plugin: [https://github.com/MRamonLeon/java11-tester-plugin] Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57223) Telemetry gathering for missing classes due to Java modules
Title: Message Title Ramon Leon commented on JENKINS-57223 Re: Telemetry gathering for missing classes due to Java modules It has been tested in this scenarios: A CNFE thrown by a `getClass().getClassLoader().loadClass` in a step implemented in a plugin A CNFE thrown by a `Thread.currentThread().getContextClassLoader().loadClass` in a step implemented in a plugin A CNFE thrown by a `getClass().getClassLoader().loadClass` in an action implemented in a plugin A CNFE thrown by a `Thread.currentThread().getContextClassLoader().loadClass` in an action implemented in a plugin A NoClassDefFoundError thrown by a call to a class moved to a module (`import sun.misc.BASE64Encoder;`) in a step implemented in a plugin Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57223) Telemetry gathering for missing classes due to Java modules
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57223 Telemetry gathering for missing classes due to Java modules Issue Type: New Feature Assignee: Ramon Leon Components: core Created: 2019-04-29 14:17 Labels: java11 Priority: Minor Reporter: Ramon Leon A first step on gathering information via telemetry related to Java 11. In this ticket, we are going to gather the ClassNotFoundExeptions and some NoClassDefFoundError thrown in the master related to the Java packages moved to modules from Java 8. Add Comment
[JIRA] (JENKINS-57320) Fix a possible regression introduced on JENKINS-56312
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-57320 Fix a possible regression introduced on JENKINS-56312 Issue Type: Bug Assignee: Unassigned Components: plugin-compat-tester Created: 2019-05-03 12:31 Labels: java11 java11-devtools-compatibility triaged Priority: Major Reporter: Ramon Leon Baptiste Mathus has worked on adding integration tests to PCT. This is done in this PR: https://github.com/jenkinsci/plugin-compat-tester/pull/140 With this PR, the Jenkinsfile of PCT runs a test well known to be successful on Java 8 and Java 11. But when testing this PR and a previous one (https://github.com/jenkinsci/plugin-compat-tester/pull/133) we found out that PCT fails because it hasn't run any test. In the PR #133 Baptiste reverted the changes on https://github.com/jenkinsci/plugin-compat-tester/pull/115 and the integration test for PCT ran successfully. So it seems that there is something wrong with this PR (#133). This task is to look into it and fix the problem. Acceptance criteria: Create a PR with a fix that makes the Integration Tests introduced on PR #140 run successfully
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon updated JENKINS-57990 Jenkins / JENKINS-57990 Avoid filtering contents without sensible data and do per-content anonymization Change By: Ramon Leon Status: In Review Resolved Resolution: Done Released As: 2.57 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199975.1560350087000.2310.1562329740349%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-55493) [support-core] Upgrade parent pom and fix HTMLForm API usage
Title: Message Title Ramon Leon updated JENKINS-55493 Jenkins / JENKINS-55493 [support-core] Upgrade parent pom and fix HTMLForm API usage Change By: Ramon Leon Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196624.1547065683000.2312.1562329740429%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58341) Add a markdown library to write these files appropriately in support-core-plugin
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-58341 Add a markdown library to write these files appropriately in support-core-plugin Change By: Ramon Leon Issue Type: Bug Improvement Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200454.1562232715000.2269.1562326020283%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon commented on JENKINS-57990 Re: Avoid filtering contents without sensible data and do per-content anonymization I don't think so Henry Chen, it's only related to the logs included in a zip generated by the support-core-plugin. A plugin to create zips with information about the instance to help to diagnose problems on it. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199975.1560350087000.9439.1561556880551%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon edited a comment on JENKINS-57602 Re: NPE in Support Core Plugin when reporting agents [PR # : https://github.com/jenkinsci/support-core-plugin/pull/ 179| [ https://github.com/jenkinsci/support-core-plugin/pull/179] ] Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8101.1562863260320%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon edited a comment on JENKINS-57602 Re: NPE in Support Core Plugin when reporting agents [PR # 157 179 |[https://github.com/jenkinsci/support-core-plugin/pull/179]] Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8098.1562863260240%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon assigned an issue to Ramon Leon Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents Change By: Ramon Leon Assignee: Ramon Leon Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8086.1562863200700%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon commented on JENKINS-57602 Re: NPE in Support Core Plugin when reporting agents [PR #157|https://github.com/jenkinsci/support-core-plugin/pull/179] Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8094.1562863200848%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon started work on JENKINS-57602 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8089.1562863200747%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon updated JENKINS-57602 Jenkins / JENKINS-57602 NPE in Support Core Plugin when reporting agents Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8092.1562863200783%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon edited a comment on JENKINS-57602 Re: NPE in Support Core Plugin when reporting agents It only happens with JCasC because the node configured ha the field to *null* instead of *""* (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI?If we consider that JCasC should do the same as the UI then it's a bug in the UI.[~oleg_nenashev] WDYT? https://github.com/jenkinsci/support-core-plugin/pull/179#issuecomment-510910195 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8827.1562942640134%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57602) NPE in Support Core Plugin when reporting agents
Title: Message Title Ramon Leon commented on JENKINS-57602 Re: NPE in Support Core Plugin when reporting agents It only happens with JCasC because the node configured ha the field to null instead of "" (empty string). Not sure whether it's a bug in JCasC or not because the field is mandatory anyway. Why can you leave it empty in the UI? If we consider that JCasC should do the same as the UI then it's a bug in the UI. Oleg Nenashev WDYT? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199526.1558523885000.8824.1562942580173%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57824) Add Full JCasC test to SSH Credentials Plugin
Title: Message Title Ramon Leon updated JENKINS-57824 Jenkins / JENKINS-57824 Add Full JCasC test to SSH Credentials Plugin Change By: Ramon Leon Status: In Review Resolved Resolution: Done Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199779.1559579051000.5198.1562652300376%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-52600) credentials plugin uses Restricted jenkins.util.xml.XMLUtils
Title: Message Title Ramon Leon updated JENKINS-52600 Jenkins / JENKINS-52600 credentials plugin uses Restricted jenkins.util.xml.XMLUtils Change By: Ramon Leon Status: In Review Resolved Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.192443.153181715.5200.1562652300495%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58341) Add a markdown library to write these files appropriately in support-core-plugin
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-58341 Add a markdown library to write these files appropriately in support-core-plugin Issue Type: Improvement Assignee: Emilio Escobar Components: support-core-plugin Created: 2019-07-04 09:31 Priority: Minor Reporter: Ramon Leon The plugin is writing some markdown plugins. So far, it's up to the developer to identify what pieces of data may have special characters and escape them with custom methods. There are a lot of texts not being escaped, for example: paths of files or directories with underscores labels with underscores etc This ticket is to add a markdown library to write this type of files giving the responsibility of escaping the text to the library, therefore doing a best formatting. Add Comment
[JIRA] (JENKINS-58341) Add a markdown library to write these files appropriately in support-core-plugin
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-58341 Add a markdown library to write these files appropriately in support-core-plugin Change By: Ramon Leon Issue Type: Improvement Bug Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200454.1562232715000.1702.1562232780667%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58341) Add a markdown library to write these files appropriately in support-core-plugin
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-58341 Add a markdown library to write these files appropriately in support-core-plugin Change By: Ramon Leon The plugin is writing some markdown plugins. So far, it's up to the developer to identify what pieces of data may have special characters and escape them with custom methods. There are a lot of texts not being escaped, for example: * paths of files or directories with underscores * labels with underscores * etcThis ticket is to add a markdown library to write this type of files giving the responsibility of escaping the text to the library, therefore doing a best better formatting. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200454.1562232715000.1697.1562232780604%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58341) Add a markdown library to write these files appropriately in support-core-plugin
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-58341 Add a markdown library to write these files appropriately in support-core-plugin Change By: Ramon Leon The plugin is writing some markdown plugins. So far, it's up to the developer to identify what pieces of data may have special characters and escape them with custom methods. There are a lot of texts not being escaped, for example: * paths of files or directories with underscores * labels with underscores * etcThis ticket is to add a markdown library to write this type of files giving the responsibility of escaping the text to the library, therefore doing a better formatting. I consider it a bug because currently there is a lot of unescaped texts that should be escaped. Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200454.1562232715000.1704.1562232840133%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58341) Add a markdown library to write these files appropriately in support-core-plugin
Title: Message Title Ramon Leon assigned an issue to Unassigned Jenkins / JENKINS-58341 Add a markdown library to write these files appropriately in support-core-plugin Change By: Ramon Leon Assignee: Emilio Escobar Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200454.1562232715000.1729.1562234040134%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-57990) Avoid filtering contents without sensible data and do per-content anonymization
Title: Message Title Ramon Leon commented on JENKINS-57990 Re: Avoid filtering contents without sensible data and do per-content anonymization Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199975.1560350087000.13323.1562005200183%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-58980) support-core should only collect the latest GC logs
Title: Message Title Ramon Leon commented on JENKINS-58980 Re: support-core should only collect the latest GC logs I see this ticket as an Improvement, not a bug. It's logical that it takes a long time to gather the files if GC log is huge. WDYT Evaristo Gutierrez? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201329.1566177465000.7037.1566397800130%40Atlassian.JIRA.
[JIRA] (JENKINS-58980) support-core should only collect the latest GC logs
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-58980 support-core should only collect the latest GC logs Change By: Ramon Leon Issue Type: Bug Improvement Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201329.1566177465000.7078.1566398160607%40Atlassian.JIRA.
[JIRA] (JENKINS-56245) Add the instanceId in the bundle
Title: Message Title Ramon Leon commented on JENKINS-56245 Re: Add the instanceId in the bundle The PR: https://github.com/jenkinsci/support-core-plugin/pull/183 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197812.155082788.7136.1566400920149%40Atlassian.JIRA.
[JIRA] (JENKINS-58980) support-core should only collect the latest GC logs
Title: Message Title Ramon Leon commented on JENKINS-58980 Re: support-core should only collect the latest GC logs Changed, if you don't mind Allan BURDAJEWICZ Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201329.1566177465000.7082.1566398220179%40Atlassian.JIRA.
[JIRA] (JENKINS-59030) Include only the latest lines of log files (configurable)
Title: Message Title Ramon Leon created an issue Jenkins / JENKINS-59030 Include only the latest lines of log files (configurable) Issue Type: Improvement Assignee: Emilio Escobar Components: support-core-plugin Created: 2019-08-21 14:57 Priority: Major Reporter: Ramon Leon Implement a FileLatestContent that gets the latest lines of the log files to avoid adding too many bytes to the zip by default. The limit can be set by a System property, useful if the logs are not enough to diagnose the problem, then the admin can change that property and generate the bundle again. We have two types of logs: The ones coming from LogRecordContent. They all are already limited in such a way or another. By RingBufferLogHandler or by SupportLogHandler. The ones coming from FileContent that reads log files. Currently, it's not limited. Although the FileContent has a constructor to define the max size, it would return the first part of the file, therefore the older log records. So we need to implement a sort of +FileLatestConten+t that gets the latest lines of the file. As this class is intended to be used with filtering, it's because the content is textual. So we can limit the size by lines, instead of bytes. Good to have this limitation configurable by a system property. We can do that using the RandomAccessFile class directly. Although we can use some existing wrappers like org.apache.commons.io.input.ReversedLinesFileReader. Acceptance criteria The support-core plugin is changed and the logs included in the bundle are
[JIRA] (JENKINS-59030) Include only the latest lines of log files (configurable)
Title: Message Title Ramon Leon assigned an issue to Unassigned Jenkins / JENKINS-59030 Include only the latest lines of log files (configurable) Change By: Ramon Leon Assignee: Emilio Escobar Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201384.1566399425000.7128.1566399901553%40Atlassian.JIRA.
[JIRA] (JENKINS-58980) support-core should only collect the latest GC logs
Title: Message Title Ramon Leon commented on JENKINS-58980 Re: support-core should only collect the latest GC logs The PR: https://github.com/jenkinsci/support-core-plugin/pull/185 Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201329.1566177465000.7141.1566401220216%40Atlassian.JIRA.
[JIRA] (JENKINS-59301) Crowd 2 plugin not compatible with JDK11
Title: Message Title Ramon Leon commented on JENKINS-59301 Re: Crowd 2 plugin not compatible with JDK11 Adrien Lecharpentier Baptiste Mathus could you take a look here please Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201849.156813782.1164.1568190420698%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics I'm working right now on trying to reproduce these leaks playing with the cancellation of the build. Whatever clue or suggestion is welcome. :sweat: Thanks! Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.8432.1572875460627%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics I’m trying to cancel jobs while in the Queue (cancel) or once running (getExecutor().interrupt()), but in this way, the job is correctly finished so the metrics thread is freed. I need to figure out a way to kill a job in a way that the future is not set in the WorkUnitContext: https://github.com/jenkinsci/jenkins/blob/264980c707c6cafc01369378b1e90d247561df78/core/src/main/java/hudson/model/queue/WorkUnitContext.java#L132 Most likely playing with several executors and subtasks and interrupting some of them. Still working, any clue on how to achieve that is welcome Daniel Beck Jesse Glick Oleg Nenashev Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.8531.1572889080294%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics Another approach, I think the best candidate, but it requires fixing Jenkins core: I’m pondering whether we could solve the problem of so many QueueSubTaskMetrics threads waiting by ensuring the synchronizeEnd and synchronizeStart always set the future? For example by surrounding the code of these two methods with try-catch and setting the future in the finally clause before rethrowing the exception. I think this because if an exception is thrown in these methods, the result is not set, so the thread is always waiting because the complete flag is not set. WorkUnitContext.java#L132 But this is a fix on Jenkins core, not in Metrics plugin. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.5090.1572425940294%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-59793 Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail Change By: Ramon Leon Summary: Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.11817.1573461481221%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail Added what has been done to the title for the sake of searches Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.11825.1573461540334%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics PR: https://github.com/jenkinsci/jenkins/pull/4346 Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.10713.1573146301127%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon updated JENKINS-59793 Jenkins / JENKINS-59793 Possible thread leak 'QueueSubTaskMetrics' in metrics Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.10714.1573146301201%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics I've pushed the test failing, after the CI fails I will push the fix Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.10721.1573146302297%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title
Ramon Leon commented on JENKINS-59793
Re: Possible thread leak 'QueueSubTaskMetrics' in metrics
Besides the code in Metrics: https://github.com/jenkinsci/metrics-plugin/blob/24bf92ebd59095d8f77b2552696b3f210a024bdc/src/main/java/jenkins/metrics/impl/JenkinsMetricProviderImpl.java#L1142
try {
return future.get();
} catch (Throwable t) {
sneakyThrow(t);
throw new RuntimeException(t);
}
We have here another affected code in: https://github.com/jenkinsci/workflow-cps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java#L940
try {
return getCurrentExecutions(false).get(1, TimeUnit.SECONDS).stream().anyMatch(StepExecution::blocksRestart);
} catch (Exception x) {
// TODO RestartListener.Default.isReadyToRestart can throw checked exceptions, but AsynchronousExecution.blocksRestart does not currently allow it
Level level = x.getCause() instanceof RejectedExecutionException ? /* stray Executor past program end? */ Level.FINE : Level.WARNING;
LOGGER.log(level, "Not blocking restart due to problem checking running steps in " + this, x);
return false;
}
We see in the log:
2019-10-14 13:16:56.104+ [id=16386139] WARNING o.j.p.w.cps.CpsFlowExecution#blocksRestart: Not blocking restart due to problem checking running steps in CpsFlowExecution[**]]java.util.concurrent.TimeoutException: Timeout waiting for task.
at com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:259)
at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:91)
at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.blocksRestart(CpsFlowExecution.java:940)
at org.jenkinsci.plugins.workflow.job.WorkflowRun$2.blocksRestart(WorkflowRun.java:372)
at org.jenkinsci.plugins.workflow.job.WorkflowRun$2.displayCell(WorkflowRun.java:375)
at hudson.model.Executor.isDisplayCell(Executor.java:668)
...
Add Comment
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title
Ramon Leon edited a comment on JENKINS-59793
Re: Possible thread leak 'QueueSubTaskMetrics' in metrics
Besides the code in * Metrics * : [ https://github.com/jenkinsci/metrics-plugin/blob/24bf92ebd59095d8f77b2552696b3f210a024bdc/src/main/java/jenkins/metrics/impl/JenkinsMetricProviderImpl.java#L1142 ] {code:java}try {return future.get();} catch (Throwable t) {sneakyThrow(t);throw new RuntimeException(t);}{code} We have here another affected code in *Pipeline* : [ https://github.com/jenkinsci/workflow-cps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java#L940 ] {code:java}try {return getCurrentExecutions(false).get(1, TimeUnit.SECONDS).stream().anyMatch(StepExecution::blocksRestart);} catch (Exception x) {// TODO RestartListener.Default.isReadyToRestart can throw checked exceptions, but AsynchronousExecution.blocksRestart does not currently allow itLevel level = x.getCause() instanceof RejectedExecutionException ? /* stray Executor past program end? */ Level.FINE : Level.WARNING;LOGGER.log(level, "Not blocking restart due to problem checking running steps in " + this, x);return false;}{code}We see in the log: {code:java}2019-10-14 13:16:56.104+ [id=16386139] WARNING o.j.p.w.cps.CpsFlowExecution#blocksRestart: Not blocking restart due to problem checking running steps in CpsFlowExecution[**]]java.util.concurrent.TimeoutException: Timeout waiting for task.at com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:259)at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:91)at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.blocksRestart(CpsFlowExecution.java:940)at org.jenkinsci.plugins.workflow.job.WorkflowRun$2.blocksRestart(WorkflowRun.java:372)at org.jenkinsci.plugins.workflow.job.WorkflowRun$2.displayCell(WorkflowRun.java:375)at hudson.model.Executor.isDisplayCell(Executor.java:668)...{code} Fortunately, this code just waits 1 second, so despite populating the code, it doesn't block anything. * [|https://cloudbees.atlassian.net/secure/AddComment!default.jspa?id=229191]
Add Comment
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title
Ramon Leon edited a comment on JENKINS-59793
Re: Possible thread leak 'QueueSubTaskMetrics' in metrics
Besides the code in *Metrics*: [https://github.com/jenkinsci/metrics-plugin/blob/24bf92ebd59095d8f77b2552696b3f210a024bdc/src/main/java/jenkins/metrics/impl/JenkinsMetricProviderImpl.java#L1142] {code:java}try {return future.get();} catch (Throwable t) {sneakyThrow(t);throw new RuntimeException(t);}{code} We have here another affected code in *Pipeline*:[https://github.com/jenkinsci/workflow-cps-plugin/blob/master/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java#L940]{code:java}try {return getCurrentExecutions(false).get(1, TimeUnit.SECONDS).stream().anyMatch(StepExecution::blocksRestart);} catch (Exception x) {// TODO RestartListener.Default.isReadyToRestart can throw checked exceptions, but AsynchronousExecution.blocksRestart does not currently allow itLevel level = x.getCause() instanceof RejectedExecutionException ? /* stray Executor past program end? */ Level.FINE : Level.WARNING;LOGGER.log(level, "Not blocking restart due to problem checking running steps in " + this, x);return false;}{code}We see in the log: {code:java}2019-10-14 13:16:56.104+ [id=16386139] WARNING o.j.p.w.cps.CpsFlowExecution#blocksRestart: Not blocking restart due to problem checking running steps in CpsFlowExecution[**]]java.util.concurrent.TimeoutException: Timeout waiting for task.at com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:259)at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:91)at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.blocksRestart(CpsFlowExecution.java:940)at org.jenkinsci.plugins.workflow.job.WorkflowRun$2.blocksRestart(WorkflowRun.java:372)at org.jenkinsci.plugins.workflow.job.WorkflowRun$2.displayCell(WorkflowRun.java:375)at hudson.model.Executor.isDisplayCell(Executor.java:668)...{code} Fortunately, this code just waits 1 second, so despite populating the code, it doesn't block anything , although it populates the log with these messages . * [|https://cloudbees.atlassian.net/secure/AddComment!default.jspa?id=229191]
Add Comment
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics I've managed to reproduce the problem in a test. I schedule a freestyle project with a long SleepBuilder and you add a SubTaskContributor throwing an exception in the run method of the Executable created. Then the WorkUnitContext#synchronizeEnd method exists with an InterruptedException and the future.set is not called. In addition, the next abort call also exists in if (aborted!=null) return; so the endLatch is not aborted properly. With this scenario, the wuc.future keeps waiting forever in the JenkinsMetricProviderImpl#asSupplier method. From my point of view the synchronizeEnd should guarantee the future is set even when throwing the InterruptedException, or the abort method shouldn't exit without aborting the latches. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.9522.1572977520603%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title
Ramon Leon edited a comment on JENKINS-59793
Re: Possible thread leak 'QueueSubTaskMetrics' in metrics
If the exception is thrown in a Builder the wrong behavior is not showed up: {code:java}FreeStyleProject p = j.createProject(FreeStyleProject.class);p.getBuildersList().add(new TestBuilder() { @Override public boolean perform(AbstractBuild build, Launcher launcher, BuildListener listener) throws InterruptedException { listener.getLogger().println("running failing builder"); throw new IndexOutOfBoundsException("Unexpected exception while building"); }});{code} It happens because when it fails and the code enters the _synchronizeEnd_ method, and then the _endLatch.synchronize()_, it exits without throwing an exception, which is different from when you get here from a _SubTask#run_
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.10103.1573050060408%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title
Ramon Leon commented on JENKINS-59793
Re: Possible thread leak 'QueueSubTaskMetrics' in metrics
If the exception is thrown in a Builder the wrong behavior is not showed up:
FreeStyleProject p = j.createProject(FreeStyleProject.class);
p.getBuildersList().add(new TestBuilder() {
@Override
public boolean perform(AbstractBuild build, Launcher launcher, BuildListener listener) throws InterruptedException {
listener.getLogger().println("running failing builder");
throw new IndexOutOfBoundsException("Unexpected exception while building");
}
});
Add Comment
This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.10060.1573048980697%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail
Title: Message Title Ramon Leon updated JENKINS-59793 Jenkins / JENKINS-59793 Possible thread leak 'QueueSubTaskMetrics' in metrics - Allow finishing builds when SubTask badly fail Change By: Ramon Leon Status: In Review Fixed but Unreleased Resolution: Fixed Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.13217.1573635721112%40Atlassian.JIRA.
[JIRA] (JENKINS-59455) CheckFilterTest failing on environment.txt
Title: Message Title Ramon Leon edited a comment on JENKINS-59455 Re: CheckFilterTest failing on environment.txt The environment.txt file is written by a PrintedContent which extends the Content which has shouldBeFiltered = true, so the file should be filtered. The CheckFilterTest supposes the environment.txt file in the bundle will have the _*path*_ word, it's always on window or linux environments. The file is filled up with the result of a call to _System.getenv()_. Maybe the path variable is not between the env vars defined where the bundle is generated, but it's unlikely I guess. [https://github.com/jenkinsci/support-core-plugin/blob/0695d2acea1300f2133522b722ad4e5cc8651c63/src/test/java/com/cloudbees/jenkins/support/CheckFilterTest.java#L234-L237] Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202048.1568948997000.9208.1572952380158%40Atlassian.JIRA.
[JIRA] (JENKINS-59455) CheckFilterTest failing on environment.txt
Title: Message Title Ramon Leon commented on JENKINS-59455 Re: CheckFilterTest failing on environment.txt The environment.txt file is written by a PrintedContent which extends the Content which has shouldBeFiltered = true, so the file should be filtered. The CheckFilterTest supposes the environment.txt file in the bundle will have the path word, it's always on window or linux environments. The file is filled up with the result of a call to System.getenv(). Maybe the path variable is not between the env vars defined where the bundle is generated, but it's unlikely I guess. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202048.1568948997000.9205.1572952260161%40Atlassian.JIRA.
[JIRA] (JENKINS-59455) CheckFilterTest failing on environment.txt
Title: Message Title Ramon Leon edited a comment on JENKINS-59455 Re: CheckFilterTest failing on environment.txt Then it would be great if we use another word instead of _path_. But not sure which one could we use. Maybe some env var that is always set during the tests? . There is a way to add env vars but it implies using reflection and _setAccesible(true)_ which I don't like. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202048.1568948997000.9302.1572961200243%40Atlassian.JIRA.
[JIRA] (JENKINS-59455) CheckFilterTest failing on environment.txt
Title: Message Title Ramon Leon commented on JENKINS-59455 Re: CheckFilterTest failing on environment.txt Then it would be great if we use another word instead of path. But not sure which one could we use. Maybe some env var that is always set during the tests? Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202048.1568948997000.9299.1572961080320%40Atlassian.JIRA.
[JIRA] (JENKINS-59793) Possible thread leak 'QueueSubTaskMetrics' in metrics
Title: Message Title Ramon Leon commented on JENKINS-59793 Re: Possible thread leak 'QueueSubTaskMetrics' in metrics I mentioned this because in the instance we detected the metric threads, there were a lot of log messages of this type. But maybe it's not related and it's just a performance issue. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202523.1571157685000.11205.1573220160328%40Atlassian.JIRA.
[JIRA] (JENKINS-57304) Multiple "idle" entries on Build Executor Status for non-existant executors
Title: Message Title Ramon Leon updated JENKINS-57304 Jenkins / JENKINS-57304 Multiple "idle" entries on Build Executor Status for non-existant executors Change By: Ramon Leon Status: In Progress Review Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199072.1556795988000.10969.1575361622974%40Atlassian.JIRA.
[JIRA] (JENKINS-55811) Jenkins pipeline idle lightweight executor list is growing
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-55811 Jenkins pipeline idle lightweight executor list is growing Change By: Ramon Leon Labels: lts-candidate Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197205.1548669487000.10917.1575361500537%40Atlassian.JIRA.
[JIRA] (JENKINS-55811) Jenkins pipeline idle lightweight executor list is growing
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-55811 Jenkins pipeline idle lightweight executor list is growing Change By: Ramon Leon Labels: lts-candidate Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197205.1548669487000.10919.1575361562932%40Atlassian.JIRA.
[JIRA] (JENKINS-57304) Multiple "idle" entries on Build Executor Status for non-existant executors
Title: Message Title Ramon Leon updated an issue Jenkins / JENKINS-57304 Multiple "idle" entries on Build Executor Status for non-existant executors Change By: Ramon Leon Labels: lts-candidate regression Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199072.1556795988000.10931.1575361565979%40Atlassian.JIRA.
[JIRA] (JENKINS-57304) Multiple "idle" entries on Build Executor Status for non-existant executors
Title: Message Title Ramon Leon started work on JENKINS-57304 Change By: Ramon Leon Status: Open In Progress Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199072.1556795988000.10967.1575361622949%40Atlassian.JIRA.
[JIRA] (JENKINS-57304) Multiple "idle" entries on Build Executor Status for non-existant executors
Title: Message Title Ramon Leon commented on JENKINS-57304 Re: Multiple "idle" entries on Build Executor Status for non-existant executors Assigned to me to keep track of it and added the lts-candidate as the PR seems to fix a bunch of tickets. Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199072.1556795988000.10955.1575361622594%40Atlassian.JIRA.
