Re: github-branch-source-plugin Filter issue

2017-08-13 Thread Stephen Connolly 
On Sun 13 Aug 2017 at 10:19, Danny Rehelis  wrote:

> We hit this today while trying to use filter
> https://issues.jenkins-ci.org/browse/JENKINS-46079
>
> Any particular reason why filter is not per discovered behavior?
>

The previous behaviour was a bug. Supposed to filter based on the
scmhead.getName... previously it was filtering based on *the name of the
branch the PR originated from* (which is madness when you think about it)

You can define multiple includes separated by comma

master,PR-*

Should build master and PRs as you described

-- 
> You received this message because you are subscribed to the Google Groups
> "Jenkins Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-users+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-users/CAObRFCUJ67-L%3DX1O2j95GyaWz27FWH4x05E%3DNupgqiczWHCFVA%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
-- 
Sent from my phone

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-users/CA%2BnPnMyVowWnTQg-GESJSoYkag1LZFPUh4UR6_WuFAFGBpi5nA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

github-branch-source-plugin Filter issue

2017-08-13 Thread Danny Rehelis 
We hit this today while trying to use filter
https://issues.jenkins-ci.org/browse/JENKINS-46079

Any particular reason why filter is not per discovered behavior?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-users/CAObRFCUJ67-L%3DX1O2j95GyaWz27FWH4x05E%3DNupgqiczWHCFVA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Does docker-slaves-plugin with pipeline assume Linux?

2017-08-13 Thread nicolas de loof 
Yes indeed. But as long g as you use git this one is actually ran in
Jenkins agent container due to an implementation issue.

Le 13 août 2017 12:16 PM, "Jacob Larsen"  a écrit :

> Wouldn't you need a Windows SCM image as well?
>
> On 2017-08-12 18:56, nicolas de loof wrote:
>
> I think you just miss a Jenkins agent docker image for Windows
> architecture, everything else should work (linux style paths aren't an
> issue afaik)
>
> Le 11 août 2017 16:37, "Thiago Carvalho Davila" <
> thiago.dav...@serpro.gov.br> a écrit :
>
>> That is very sad.. I have slaves for windows and linux, and I was
>> begining a migration of my machine slaves to containers =(
>>
>> Is there a JIRA feature created for that cause?
>>
>> Em 11/08/2017 04:52:49, Geoff Bache escreveu:
>>
>>
>> OK, I think we can conclude from my evidence that it doesn't yet work on
>> Windows then: I'm not trying to do anything beyond basic usage. Perhaps you
>> could write this in the plugin description?
>>
>> On Friday, 11 August 2017 09:08:51 UTC+2, nicolas de loof wrote:
>>>
>>> This plugin has never been tested for Windows containers, so I can't
>>> tell if they can work without changes.
>>>
>>> Le 11 août 2017 9:04 AM, "Geoff Bache"  a écrit :
>>>

 I removed the extra slash in global configuration, but it still fails
 and there are still Linux-style paths that I don't seem to be able to
 configure. See text below.
 I also tried using jenkinsci/slave, which the tooltip recommends, but
 got the same error.

 /Geoff

 Start Docker container to host the build
 $ docker volume create
 $ docker create --interactive --log-driver=none --env
 TMPDIR=/home/jenkins/.tmp --user 1:1 --rm --volume
 20cf056ee345717252ece59811047e0692a9bea818f5ca23b79af77f220dbd0a:/home/jenkins/
 jenkins/agent java -Djava.io.tmpdir=/home/jenkins/.tmp -jar
 /home/jenkins/slave.jar Error response from daemon: invalid bind mount spec
 "20cf056ee345717252ece59811047e0692a9bea818f5ca23b79af77f220dbd0a:/home/jenkins/":
 invalid volume specification: '20cf056ee345717252ece59811047
 e0692a9bea818f5ca23b79af77f220dbd0a:\home\jenkins\'

 On Thursday, 10 August 2017 17:14:30 UTC+2, Geoff Bache wrote:
>
> Hi all,
>
>
>
> I have a Jenkins pipeline defined (Windows server 2016) and I’m trying
> to get it to use docker containers instead of building locally. The
> docker-slaves-plugin looked like the most convenient interface for this
> among a confusing forest of different Docker plugins.
>
>
>
> So I installed it and pointed it at my Docker image in the
> configuration. It carried on exactly as before and ignored Docker 
> entirely,
> even after Jenkins restart.
>
>
>
> I then found a hint that I should replace “node” with
> “dockerNode(‘myimage’)” in my Jenkinsfile. So I did that, and got the
> following in my build log (with debug option enabled).
>
> Note the “docker create” line which seems to be referring to a bunch
> of linux paths that just don’t exist and looks a bit hardcoded...
>
>
> If, as I suspect, this isn't supported, any hints on which plugin to
> use instead would be appreciated.
>
>
>
> Regards,
>
> Geoff Bache
>
>
>
> Start Docker container to host the build
>
> $ docker volume create
>
> $ docker create --interactive --log-driver=none --env
> TMPDIR=/home/jenkins/.tmp --user 1:1 --rm --volume
> 45aa67db1c5cc27820ebc3afd7abdd4a708b78f8d7ce2720fdbc2c7956ac2a52:/home/jenkins/
> jenkins/agent/ java -Djava.io.tmpdir=/home/jenkins/.tmp -jar
> /home/jenkins/slave.jar
>
> Error parsing reference: "jenkins/agent/" is not a valid
> repository/tag: invalid reference format
>
> [Pipeline] // dockerNode
>
> [Pipeline] }
>
> [Pipeline] // stage
>
> [Pipeline] }
>
> [Pipeline] // node
>
> [Pipeline] End of Pipeline
>
> java.io.IOException: Failed to create docker image
>
> at it.dockins.dockerslaves.driver
> s.CliDockerDriver.launchRemotingContainer(CliDockerDriver.java:176)
>
> at it.dockins.dockerslaves.Defaul
> tDockerProvisioner.launchRemotingContainer(DefaultDockerProv
> isioner.java:88)
>
> at it.dockins.dockerslaves.Docker
> ComputerLauncher.launch(DockerComputerLauncher.java:58)
>
> at it.dockins.dockerslaves.Docker
> ComputerLauncher.launch(DockerComputerLauncher.java:49)
>
> at it.dockins.dockerslaves.api.On
> eShotSlave.provision(OneShotSlave.java:123)
>
> Caused: it.dockins.dockerslaves.api.OneShotExecutorProvisioningExcep
> tion
>
> at it.dockins.dockerslaves.api.On
> eShotSlave.provisionFailed(OneShotSlave.java:145)
>
> at it.dockins.dockerslaves.api.On
> eShotSlave.prov

Re: Does docker-slaves-plugin with pipeline assume Linux?

2017-08-13 Thread Jacob Larsen 

Wouldn't you need a Windows SCM image as well?


On 2017-08-12 18:56, nicolas de loof wrote:
I think you just miss a Jenkins agent docker image for Windows 
architecture, everything else should work (linux style paths aren't an 
issue afaik)


Le 11 août 2017 16:37, "Thiago Carvalho Davila" 
mailto:thiago.dav...@serpro.gov.br>> a 
écrit :


That is very sad.. I have slaves for windows and linux, and I was
begining a migration of my machine slaves to containers =(

Is there a JIRA feature created for that cause?

Em 11/08/2017 04:52:49, Geoff Bache escreveu:


OK, I think we can conclude from my evidence that it doesn't
yet work on Windows then: I'm not trying to do anything beyond
basic usage. Perhaps you could write this in the plugin
description?

On Friday, 11 August 2017 09:08:51 UTC+2, nicolas de loof wrote:

This plugin has never been tested for Windows containers,
so I can't tell if they can work without changes.

Le 11 août 2017 9:04 AM, "Geoff Bache"
 a écrit :


I removed the extra slash in global configuration, but
it still fails and there are still Linux-style paths
that I don't seem to be able to configure. See text below.
I also tried using jenkinsci/slave, which the tooltip
recommends, but got the same error.

/Geoff

Start Docker container to host the build
$ docker volume create
$ docker create --interactive --log-driver=none --env
TMPDIR=/home/jenkins/.tmp --user 1:1 --rm
--volume

20cf056ee345717252ece59811047e0692a9bea818f5ca23b79af77f220dbd0a:/home/jenkins/
jenkins/agent java -Djava.io.tmpdir=/home/jenkins/.tmp
-jar /home/jenkins/slave.jar Error response from
daemon: invalid bind mount spec

"20cf056ee345717252ece59811047e0692a9bea818f5ca23b79af77f220dbd0a:/home/jenkins/":
invalid volume specification:

'20cf056ee345717252ece59811047e0692a9bea818f5ca23b79af77f220dbd0a:\home\jenkins\'


On Thursday, 10 August 2017 17:14:30 UTC+2, Geoff
Bache wrote:

Hi all,

I have a Jenkins pipeline defined (Windows server
2016) and I’m trying to get it to use docker
containers instead of building locally. The
docker-slaves-plugin looked like the most
convenient interface for this among a confusing
forest of different Docker plugins.

So I installed it and pointed it at my Docker
image in the configuration. It carried on exactly
as before and ignored Docker entirely, even after
Jenkins restart.

I then found a hint that I should replace “node”
with “dockerNode(‘myimage’)” in my Jenkinsfile. So
I did that, and got the following in my build log
(with debug option enabled).

Note the “docker create” line which seems to be
referring to a bunch of linux paths that just
don’t exist and looks a bit hardcoded...


If, as I suspect, this isn't supported, any hints
on which plugin to use instead would be appreciated.

Regards,

Geoff Bache

Start Docker container to host the build

$ docker volume create

$ docker create --interactive --log-driver=none
--env TMPDIR=/home/jenkins/.tmp --user 1:1
--rm --volume

45aa67db1c5cc27820ebc3afd7abdd4a708b78f8d7ce2720fdbc2c7956ac2a52:/home/jenkins/
jenkins/agent/ java
-Djava.io.tmpdir=/home/jenkins/.tmp -jar
/home/jenkins/slave.jar

Error parsing reference: "jenkins/agent/" is not a
valid repository/tag: invalid reference format

[Pipeline] // dockerNode

[Pipeline] }

[Pipeline] // stage

[Pipeline] }

[Pipeline] // node

[Pipeline] End of Pipeline

java.io.IOException: Failed to create docker image

at

it.dockins.dockerslaves.drivers.CliDockerDriver.launchRemotingContainer(CliDockerDriver.java:176)

at

it.dockins.dockerslaves.DefaultDockerProvisioner.launchRemotingContainer(DefaultDockerProvisioner.java:88)

at