Re: CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-13 Thread Sundararajan Athijegannathan

Vote: yes

On 9/13/2015 8:03 PM, Alan Bateman wrote:


I hereby nominate Jean-Francois Denise to jigsaw Committer.

Jean-Francois is a jdk9 Committer and has been contributing to the 
ongoing development of the jimage container format. He has also been 
focused recently on the link phase and jlink tool cited in JEP 261 
[0]. He has more than 40 change-sets/contributions in the jigsaw/jake 
forest.


Votes are due by September 26, 2015 8:00 PDT.

Only current jigsaw Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2].

-Alan.

[0] http://openjdk.java.net/jeps/261
[1] http://openjdk.java.net/census
[2] http://openjdk.java.net/projects/#committer-vote




Re: jigsaw vs. jsr166 CVS

2015-09-13 Thread Martin Buchholz
Alan, thanks for that pointer.  I succeeded at building jsr166 and running
tests with it after beating ant into submission.

People *will* write code to distinguish between a pre-module and
post-module JDK by inspecting the filesystem.
Here's one implementation in ant:



  


Then we can have conditional ant code like this:

  
  

It's not just a matter of "porting to jigsaw".  There seems to be no way of
deploying jsr166 CVS as a directly deployable software artifact as we have
been doing with -Xbootclasspath/p.  To use -Xoverride, there must be an
exploded directory.  It would be convenient if -Xoverride was usable with
an equivalent jar file (jsr166.jar).  But y'all are trying to make module
overriding possible, not convenient?!

javadoc does not seem to have any support for -Xmodule, so I don't know how
to fix the "docs" target.

The fundamental disconnect is that from a developer point of view, jsr166
CVS contains an independently developed "module" with binary deployable
artifacts, but jigsaw disagrees about its module-ness, and that can
probably not be fixed because of circular dependencies between
java.util.concurrent and the rest of java.base?


On Fri, Sep 11, 2015 at 9:47 PM, Alan Bateman 
wrote:

>
> On 12/09/2015 00:30, Martin Buchholz wrote:
>
>> I tried adding -Xoverride, but it didn't help.
>>
>> You'll need to use javac -Xmodule:java.base to compile the classes, then
> use -Xoverride at run-time. As it happens, there is an example that
> compiles and uses an development version of CHM here:
>
>   http://openjdk.java.net/projects/jigsaw/quick-start#xoverride
>
> Hopefully it won't too much to get the build.xml to do this.
>
> -Alan
>


Re: CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-13 Thread James Laskey
Vote: yes

Sent from my iPhone

> On Sep 13, 2015, at 11:33 AM, Alan Bateman  wrote:
> 
> 
> I hereby nominate Jean-Francois Denise to jigsaw Committer.
> 
> Jean-Francois is a jdk9 Committer and has been contributing to the ongoing 
> development of the jimage container format. He has also been focused recently 
> on the link phase and jlink tool cited in JEP 261 [0]. He has more than 40 
> change-sets/contributions in the jigsaw/jake forest.
> 
> Votes are due by September 26, 2015 8:00 PDT.
> 
> Only current jigsaw Committers [1] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> -Alan.
> 
> [0] http://openjdk.java.net/jeps/261
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#committer-vote


hg: jigsaw/jake/jdk: 3 new changesets

2015-09-13 Thread alan . bateman
Changeset: 6b9fef847d06
Author:alanb
Date:  2015-09-13 14:50 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/6b9fef847d06

Rename MixedModeTest.java to AddModsTest and extend coverage

+ test/jdk/jigsaw/launcher/addmods/AddModsTest.java
+ test/jdk/jigsaw/launcher/addmods/src/app/Main.java
+ test/jdk/jigsaw/launcher/addmods/src/lib/jdk/lib/Util.java
+ test/jdk/jigsaw/launcher/addmods/src/lib/module-info.java
- test/jdk/jigsaw/launcher/mixedmode/MixedModeTest.java
- test/jdk/jigsaw/launcher/mixedmode/src/app/Main.java
- test/jdk/jigsaw/launcher/mixedmode/src/lib/jdk/lib/Util.java
- test/jdk/jigsaw/launcher/mixedmode/src/lib/module-info.java

Changeset: 9d521fd83608
Author:alanb
Date:  2015-09-13 15:35 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9d521fd83608

AccessibleObject.setAccessible should not be final for compatibility reasons

! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java
! src/java.base/share/classes/java/lang/reflect/Constructor.java
! src/java.base/share/classes/java/lang/reflect/Field.java
! src/java.base/share/classes/java/lang/reflect/Method.java

Changeset: 0321cfe06fef
Author:alanb
Date:  2015-09-13 15:38 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0321cfe06fef

Merge

- src/java.base/unix/classes/sun/nio/fs/GnomeFileTypeDetector.java
- src/java.base/unix/native/libnio/fs/GnomeFileTypeDetector.c



Re: CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-13 Thread Alan Bateman

Vote: yes


CFV: New jigsaw Committer: Jean-Francois Denise

2015-09-13 Thread Alan Bateman


I hereby nominate Jean-Francois Denise to jigsaw Committer.

Jean-Francois is a jdk9 Committer and has been contributing to the 
ongoing development of the jimage container format. He has also been 
focused recently on the link phase and jlink tool cited in JEP 261 [0]. 
He has more than 40 change-sets/contributions in the jigsaw/jake forest.


Votes are due by September 26, 2015 8:00 PDT.

Only current jigsaw Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [2].

-Alan.

[0] http://openjdk.java.net/jeps/261
[1] http://openjdk.java.net/census
[2] http://openjdk.java.net/projects/#committer-vote


Re: Retrieving PLATFORM_CLASS_PATH from file manager

2015-09-13 Thread Alan Bateman

On 12/09/2015 20:16, Jayaprakash Arthanareeswaran wrote:


Hello experts,

With JDK 9, some of JDT Core tests have started failing. The failing tests
are in the JSR 199 area, where we test Eclipse's compiler in a mixed mode
with Javac's StandardJavaFileManager.

standardJavaFileManager.getLocation(StandardLocation.PLATFORM_CLASS_PATH);

Until JDK 8, this used to return rt.jar and other jars but not anymore. I
expected this to return the path to the bootmodules.jimage just like the
system property "sun.boot.class.path".

The proposal is to drop sun.boot.class.path, see the "Removed: Bootstrap 
class-path options" in JEP 261 [1]. It wasn't been useful since the 
changes for JEP 220 went into JDK 9. There are a few remaining pieces to 
be done in HotSpot before we can get there, mostly in the Serviceability 
Agent and the "Compile-The-World" built-in test. The issue is tracked by 
JDK-8131049 and JDK-8077209.


To be consistent then I would think getLocation(PLATFORM_CLASS_PATH) 
would return an empty Iterable and a getLocation(SYSTEM_MODULE_PATH), or 
a Iterable variant, would return jrt:/.  I'm sure Jon will reply 
on this issue and explain JRT_MARKER_FILE (which I suspect is what you 
are wondering about).


-Alan

[1] http://openjdk.java.net/jeps/261


Re: Jigsaw EA feedback on running an internal app

2015-09-13 Thread Chris Newland
Yes, I'd only use these switches as a temporary solution just to get your
projects compiling under jigsaw.

Looks like the maven team have a handle on how to fix it:
http://mail-archives.apache.org/mod_mbox/maven-dev/201509.mbox/browser

Regards,

Chris


On Sat, September 12, 2015 17:36, David M. Lloyd wrote:
> On 09/12/2015 10:26 AM, Alan Bateman wrote:
>
>>
>>
>> On 11/09/2015 16:52, Peter Levart wrote:
>>
>>>
>>> Building the app with Maven doesn't work though. Maven compiler
>>> module doesn't seem to be able to use the javac compiler API
>>> correctly. Maven folks would have to look at it.
>> I met Chris Newland today at an event, he was running into the same
>> issue but found a workaround:
>>
>> https://twitter.com/chriswhocodes/status/642646126689132544
>>
>
> The forked mode lacks some features of the compiler API mode though; it
> might not work for some projects, and I wouldn't recommend it for any kind
> of long-term substitute in any event.
>
> --
> - DML
>
>