Re: CFV: New Committer: Christian Tornqvist

[Sundararajan Athijegannathan]

Vote: yes

On 9/17/2015 10:48 PM, John Rose wrote:

Vote: yes


On Sep 16, 2015, at 2:42 PM, Karen Kinnear  wrote:

I hereby nominate Christian Tornqvist to Jigsaw Committer.

Re: CFV: New Jigsaw Committer: Harold Seigel

[Sundararajan Athijegannathan]

Vote: yes

On 9/17/2015 10:49 PM, John Rose wrote:

Vote: yes


On Sep 11, 2015, at 12:31 PM, Karen Kinnear  wrote:

I hereby nominate Harold Seigel to Jigsaw Committer.

Re: CFV: New Jigsaw Committer: Lois Foltan

[Sundararajan Athijegannathan]

Vote: yes

On 9/17/2015 10:48 PM, John Rose wrote:

Vote: yes


On Sep 16, 2015, at 2:43 PM, Karen Kinnear  wrote:


I hereby nominate Lois Foltan to Jigsaw Committer.

hg: jigsaw/jake/jdk: Exception typo in Proxy class javadoc

[mandy . chung]

Changeset: 3f905b5efebf
Author:mchung
Date:  2015-09-17 15:14 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3f905b5efebf

Exception typo in Proxy class javadoc

! src/java.base/share/classes/java/lang/reflect/Proxy.java

hg: jigsaw/jake/hotspot: fixing XoverrideCCDS.java test failure

[mandy . chung]

Changeset: e6b7e9cc28c0
Author:ccheung
Date:  2015-09-17 14:39 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e6b7e9cc28c0

fixing XoverrideCCDS.java test failure
Summary: adjusted the expected error message during dump time
Reviewed-by: iklam, jiangli

! test/runtime/modules/XoverrideCDS.java

hg: jigsaw/jake/langtools: update local build support

[jonathan . gibbons]

Changeset: 24e405279ff8
Author:jlahoda
Date:  2015-09-17 15:09 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/24e405279ff8

update local build support

! make/build.xml
! make/launcher.sh-template
! make/netbeans/langtools/build.xml

hg: jigsaw/jake/langtools: remove unnecessary local variables

[jonathan . gibbons]

Changeset: b32127130c64
Author:jjg
Date:  2015-09-17 14:50 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b32127130c64

remove unnecessary local variables

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

Re: JavaxToolsCompiler

[Robert Scholte]

I can confirm the fix.

thanks!

Robert

Op Wed, 16 Sep 2015 12:27:11 +0200 schreef Alan Bateman  
:




On 14/09/2015 20:21, Stuart McCulloch wrote:
Yes, the issue is that ToolProvider.getSystemJavaCompiler() is  
returning null when using the Jigsaw EA with Maven.


AFAICT this is because it’s now using the service loader mechanism  
which is influenced by the Thread’s context ClassLoader


The following patch to make sure Maven uses the system context when  
looking up the compiler appears to solve the issue:



Just to follow-up on this one, the bug in ToolProvider has been fixed in  
the jigsaw/jake forest. We should have an updated EA build in the next  
day or two that will pick up this fix.


Thanks again for the mails on this, it's good to have found this one  
early.


-Alan

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Jigsaw early access: Build 81 posted

[mark . reinhold]

2015/9/17 1:20 -0700, cnewl...@chrisnewland.com:
> Jigsaw build 81 fixes the maven compiler issue for me on Linux x86_64
> (Debian Wheezy) and OSX Yosemite 10.10.5
> 
> My gradle build gets further now. In the previous Jigsaw build it errored
> out on AccessibleObject.setAccessible but now has a problem with missing
> tools.jar (problem now on my side).

Progress!

- Mark

Re: Jigsaw early access: Build 81 posted

[Chris Newland]

Hi Mark,

Jigsaw build 81 fixes the maven compiler issue for me on Linux x86_64
(Debian Wheezy) and OSX Yosemite 10.10.5

My gradle build gets further now. In the previous Jigsaw build it errored
out on AccessibleObject.setAccessible but now has a problem with missing
tools.jar (problem now on my side).

Kind regards,

Chris


On Thu, September 17, 2015 16:56, mark.reinh...@oracle.com wrote:
> Available here: https://jdk9.java.net/jigsaw/
>
>
> Notable changes include fixes for the setAccessible and ToolProvider
> issues, previously reported on this list:
>
> Changeset: 9d521fd83608
> Author:alanb
> Date:  2015-09-13 15:35 +0100
> URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9d521fd83608
>
>
> AccessibleObject.setAccessible should not be final for compatibility
> reasons
>
> ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java
> ! src/java.base/share/classes/java/lang/reflect/Constructor.java
> ! src/java.base/share/classes/java/lang/reflect/Field.java
> ! src/java.base/share/classes/java/lang/reflect/Method.java
>
>
> Changeset: 948a1770620e
> Author:jjg
> Date:  2015-09-15 14:21 -0700
> URL:
> http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/948a1770620e
>
>
> ToolProvider should use getSystemClassLoader
>
>
> ! src/java.compiler/share/classes/javax/tools/ToolProvider.java
>
>
> This build also includes all changes in JDK 9 build 81.
>
>
> Thanks for the feedback -- keep it coming!
>
>
> - Mark
>
>

Re: CFV: New Committer: Christian Tornqvist

[John Rose]

Vote: yes

> On Sep 16, 2015, at 2:42 PM, Karen Kinnear  wrote:
> 
> I hereby nominate Christian Tornqvist to Jigsaw Committer.

Re: CFV: New jigsaw Committer: Jean-Francois Denise

[John Rose]

Vote: yes

> On Sep 16, 2015, at 12:17 PM, mark.reinh...@oracle.com wrote:
> 
> Vote: yes
> 
> - Mark

Re: CFV: New Jigsaw Committer: Harold Seigel

[John Rose]

Vote: yes

> On Sep 11, 2015, at 12:31 PM, Karen Kinnear  wrote:
> 
> I hereby nominate Harold Seigel to Jigsaw Committer.

Re: CFV: New Jigsaw Committer: Lois Foltan

[John Rose]

Vote: yes

> On Sep 16, 2015, at 2:43 PM, Karen Kinnear  wrote:
> 
> 
> I hereby nominate Lois Foltan to Jigsaw Committer.

Jigsaw early access: Build 81 posted

[mark . reinhold]

Available here: https://jdk9.java.net/jigsaw/

Notable changes include fixes for the setAccessible and ToolProvider
issues, previously reported on this list:

  Changeset: 9d521fd83608
  Author:alanb
  Date:  2015-09-13 15:35 +0100
  URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9d521fd83608

  AccessibleObject.setAccessible should not be final for compatibility reasons

  ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java
  ! src/java.base/share/classes/java/lang/reflect/Constructor.java
  ! src/java.base/share/classes/java/lang/reflect/Field.java
  ! src/java.base/share/classes/java/lang/reflect/Method.java

  Changeset: 948a1770620e
  Author:jjg
  Date:  2015-09-15 14:21 -0700
  URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/948a1770620e

  ToolProvider should use getSystemClassLoader

  ! src/java.compiler/share/classes/javax/tools/ToolProvider.java

This build also includes all changes in JDK 9 build 81.

Thanks for the feedback -- keep it coming!

- Mark

Re: CFV: New jigsaw Committer: Jean-Francois Denise

[Vincent Ryan]

Vote: yes

Re: CFV: New Committer: Christian Tornqvist

[Vincent Ryan]

Vote: yes

Re: CFV: New Jigsaw Committer: Harold Seigel

[Vincent Ryan]

Vote: yes

Re: CFV: New Jigsaw Committer: Lois Foltan

[Vincent Ryan]

Vote: yes

Re: CFV: New Committer: Christian Tornqvist

[Erik Joelsson]

Vote: yes

/Erik

Re: CFV: New jigsaw Committer: Jean-Francois Denise

[Erik Joelsson]

Vote: yes

/Erik

Re: CFV: New Jigsaw Committer: Lois Foltan

[Erik Joelsson]

Vote: yes

/Erik

Re: CFV: New Jigsaw Committer: Harold Seigel

[Erik Joelsson]

Vote: yes

/Erik

Re: CFV: New Committer: Christian Tornqvist

[Karen Kinnear]

vote: yes

thanks,
Karen

On Sep 16, 2015, at 2:42 PM, Karen Kinnear wrote:

> I hereby nominate Christian Tornqvist to Jigsaw Committer.
> 
> Christian is the hotspot runtime SQE lead and a Reviewer on the jdk9 project. 
> Christian has contributed new tests and made extensive changes to the hotspot 
> tests for jigsaw in the
> jigsaw/m3 forest, including adding the ability to test JVM_* APIs via white 
> box testing, testing
> for memory leaks due to class unloading, and modifications to tests to deal 
> with jigsaw command
> line options.
> 
> Votes are due by: September 30, 2015, 7:00 PST. Only current Jigsaw
> Committers [1] are eligible to vote on this nomination.  Votes must be cast
> in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> thanks,
> Karen
> 
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#committer-vote
> 
> Christian's jigsaw changesets:
> 
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/928e89280286
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a6486dd6f141
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/2e29f5e8333b
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/18c4d48f7fdf
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0a3a73c4976b
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/97666a3ee1b7
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b6c27227f14d
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0be80247e442
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bbc6dfd8f329
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/651cd13f8cc2
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0b8ad3584a1c
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/aaab3e55ae2f
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/e91779d9e691
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/35f7a63f6260
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/0b1b80bd13c5
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5c450268abbd
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/dbe3a0baee50
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/cc031dd0e784

Re: CFV: New Jigsaw Committer: Lois Foltan

[Karen Kinnear]

vote: yes

thanks,
Karen

On Sep 16, 2015, at 2:43 PM, Karen Kinnear wrote:

> 
> I hereby nominate Lois Foltan to Jigsaw Committer.
> 
> Lois is a member of the hotspot runtime team and a committer on the jdk9 
> project.
> Lois has been contributing to Project Jigsaw for more than a year, including 
> jvm support
> for module and package metadata, boot class loader support for observability 
> boundary
> checking and jvm support for access control checks based on the new jigsaw 
> access
> control rules relative to module readability and exports. These are currently 
> prototyped in the
> jigsaw/m3 forest.
> 
> Votes are due by: September 30, 2015, 7:00 PST. Only current Jigsaw 
> Committers [1]
> are eligible to vote on this nomination.  Votes must be cast in the open by 
> replying to
> this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#committer-vote
> 
> jigsaw changesets:
> 
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/ec64631485ee
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/361b6493fd8c
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/483a16ff1561
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/a96cc469159a
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b77ade9699f3
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/4bf2c76660e6
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6304c4530d95
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6821aa4f2b30
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/40b26486a13a
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c642727aa248
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/c5533b42e897
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f0885ae77815
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/423249ef49ba
> 
> And the one that Alan committed, but is contributed by Harold and myself that 
> contains the initial implementation of the VM support for modules.
> http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/6e3af5b0d4c8
> 
> 

Re: jlink tool doesn't create windows os compatible launcher in resulting runtime image

[Ali Ebrahimi]

Hi,
This is clean and tested patch:

diff --git
a/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
b/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
---
a/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
+++
b/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
@@ -172,17 +172,24 @@
 ByteArrayInputStream stream = new
ByteArrayInputStream(res.getByteArray());
 mainClass = ModuleDescriptor.read(stream).mainClass();
 if (mainClass.isPresent()) {
-Path cmd = root.resolve("bin").resolve(module);
+Path cmd = root.resolve("bin").resolve(isWindows()?
module+".bat": module);
 if (!Files.exists(cmd)) {
 StringBuilder sb = new StringBuilder();
-sb.append("#!/bin/sh")
-.append("\n");
-sb.append("DIR=`dirname $0`")
-.append("\n");
-sb.append("$DIR/java -m ")
-.append(module).append('/')
-.append(mainClass.get())
-.append(" $@\n");
+if(!isWindows()) {
+sb.append("#!/bin/sh")
+.append("\n");
+sb.append("DIR=`dirname $0`")
+.append("\n");
+sb.append("$DIR/java -m ")
+.append(module).append('/')
+.append(mainClass.get())
+.append(" $@\n");
+} else {
+sb.append("%~dp0java -m ")
+.append(module).append('/')
+.append(mainClass.get())
+.append(" %*\n");
+}

 try (BufferedWriter writer =
Files.newBufferedWriter(cmd,
 StandardCharsets.ISO_8859_1,


On Wed, Sep 16, 2015 at 8:46 PM, Jean-Francois Denise <
jean-francois.den...@oracle.com> wrote:

> Hi Ali,
> I logged: https://bugs.openjdk.java.net/browse/JDK-8136645
> Thanks for reporting.
> JF
>
> On 16 Sep 2015, at 17:55, Ali Ebrahimi  wrote:
>
> > Hi,
> >
> > The following patch tries to fix this:
> >
> > diff --git
> >
> a/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
> >
> b/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
> > ---
> >
> a/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
> > +++
> >
> b/src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
> > @@ -172,17 +172,24 @@
> > ByteArrayInputStream stream = new
> > ByteArrayInputStream(res.getByteArray());
> > mainClass = ModuleDescriptor.read(stream).mainClass();
> > if (mainClass.isPresent()) {
> > -Path cmd = root.resolve("bin").resolve(module);
> > +Path cmd = root.resolve("bin").resolve(isWindows()?
> > module+".bat": module);
> > if (!Files.exists(cmd)) {
> > StringBuilder sb = new StringBuilder();
> > -sb.append("#!/bin/sh")
> > +if(!isWindows())
> > +sb.append("#!/bin/sh")
> > +.append("\n");
> > +sb.append("DIR=`dirname $0`")
> > .append("\n");
> > -sb.append("DIR=`dirname $0`")
> > -.append("\n");
> > -sb.append("$DIR/java -m ")
> > +sb.append("$DIR/java -m ")
> > .append(module).append('/')
> > .append(mainClass.get())
> > .append(" $@\n");
> > +} else {
> > +sb.append("%~dp0java -m ")
> > +.append(module).append('/')
> > +.append(mainClass.get())
> > +.append(" $*\n");
> > +}
> >
> >
> > Best Regards,
> > Ali Ebrahimi
>
>


-- 

Best Regards,
Ali Ebrahimi

Re: RFR: JDK-8080511 - Refresh of jimage support

[Roman Shevchenko]

Fixed in the recent 14.1.5 RC (build 141.2734.1).

> On 24 Jul 2015, at 20:10, Sergey Bylokhov  wrote:
> 
> ...
> 
> It seems that IntelliJ also broken in some way so it cannot take classes from 
> the jdk9 after this fix. probably they should update jrt-fs.jar?
> 
> 
> On 23.06.15 19:08, Jean-Francois Denise wrote:
>> Hi,
>> an updated webrev that takes into account reviews. In addition the hotspot 
>> tests have been reworked following Christian Tornqvist suggestions.
>> 
>> top: http://cr.openjdk.java.net/~jfdenise/hs-rt-jimage.3/webrev-top/
>> langtools: 
>> http://cr.openjdk.java.net/~jfdenise/hs-rt-jimage.3/webrev-langtools/
>> hotspot: http://cr.openjdk.java.net/~jfdenise/hs-rt-jimage.3/webrev-hotspot/
>> jdk: http://cr.openjdk.java.net/~jfdenise/hs-rt-jimage.3/webrev-jdk/
>> 
>> Testing:
>> JCK(s) tests are passing (ran only on Mac OS)
>> Hotspot tests are passing (All platforms)
>> Java PIT tests are passing (All platforms). Ran once on 
>> https://bugs.openjdk.java.net/browse/JDK-8129592
>> 
>> Thanks.
>> JF
>> 
>> On 23 Jun 2015, at 14:10, Jean-Francois Denise 
>>  wrote:
>> 
>>> Hi Paul,
>>> 
>>> On 19 Jun 2015, at 16:39, Paul Sandoz  wrote:
>>> 
 On Jun 18, 2015, at 2:08 AM, Jim Laskey (Oracle)  
 wrote:
 
> https://bugs.openjdk.java.net/browse/JDK-8080511
> 
> This is an long overdue refresh of the jimage support in the JDK9-dev 
> repo.  This includes native support for reading jimage files, improved 
> jrt-fs (java runtime file system) support for retrieving modules and 
> packages from the runtime, and improved performance for langtools in the 
> presence of jrt-fs.
> 
> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-top 
> 
> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-jdk 
> 
 I eyeballed the JDK changes. Just two thing:
 
 make/src/classes/build/tools/module/ModuleArchive.java
 
 90 @Override
 91 public Stream entries() {
 92 List entries = new ArrayList<>();
 93 try {
 94 if (classes != null)
 95 Files.walk(classes)
 96 .sorted()
 97 .filter(p -> !Files.isDirectory(p)
 98 && 
 !classes.relativize(p).toString().startsWith("_the.")
 99 && 
 !classes.relativize(p).toString().equals("javac_state"))
 100 .map(p -> toEntry(p, classes, 
 EntryType.CLASS_OR_RESOURCE))
 101 .forEach(entries::add);
 102 if (cmds != null)
 103 Files.walk(cmds)
 104 .filter(p -> !Files.isDirectory(p))
 105 .map(p -> toEntry(p, cmds, 
 EntryType.NATIVE_CMD))
 106 .forEach(entries::add);
 107 if (libs != null)
 108 Files.walk(libs)
 109 .filter(p -> !Files.isDirectory(p))
 110 .map(p -> toEntry(p, libs, 
 EntryType.NATIVE_LIB))
 111 .forEach(entries::add);
 112 if (configs != null)
 113 Files.walk(configs)
 114 .filter(p -> !Files.isDirectory(p))
 115 .map(p -> toEntry(p, configs, 
 EntryType.CONFIG))
 116 .forEach(entries::add);
 117 } catch (IOException ioe) {
 118 throw new UncheckedIOException(ioe);
 119 }
 120 return entries.stream();
 121 }
 
 You can use collect(toList())
>>> ==> OK collect used. In addition, filter first then sort, tryWithResource 
>>> for 4 Files stream.
>>> 
 In general the contract for Archive.entries probably has to say the stream 
 needs to be closed after use since it might cover lazy I/O based 
 resources, so callers will need to use a try-with-resources block.
>>> ==> Added a note in javadoc, implemented explicit close for non lazy 
>>> streams, added missing tryWithResource. Added a comment on what should be 
>>> done in ModuleArchive to keep laziness.
 Paul.
>>> Thanks.
>>> 
> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-hotspot 
> 
> http://cr.openjdk.java.net/~jlaskey/hs-rt-jimage/webrev-langtools 
> 
> 
> 
> Details:
> 
> - jrt-fs provides access, via the nio FileSystem API, to the classes in a 
> .jimage file, organized by module or by package.
> - Shared code for jimage support converted to native.  Currently residing 
> in hotspot, but will migrate to it’s own