Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

[Mandy Chung]

> On Jun 17, 2016, at 3:29 PM, Naoto Sato  wrote:
> 
> Decided to fix this separately from the other include locales issues. Here is 
> the bug and the proposed fix:
> 
> https://bugs.openjdk.java.net/browse/JDK-8159781
> http://cr.openjdk.java.net/~naoto/8159781/webrev.00/

The change looks okay.   This can be converted to use 
ResourceFilter::includeFilter(List patterns) rather than building a 
comma-separated patterns string.  That means META_FILES and 
INCLUDE_LOCALE_FILES can be made as List.  You have an option to 
prepend “regex:” when constructing the patterns to pass to ResourceFilter.  I 
think that’s a good clean up to do.

Mandy

[9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

[Naoto Sato]

Decided to fix this separately from the other include locales issues. 
Here is the bug and the proposed fix:


https://bugs.openjdk.java.net/browse/JDK-8159781
http://cr.openjdk.java.net/~naoto/8159781/webrev.00/

The change is to explicitly specify "regex" path matching along with the 
pattern modifications. This is needed to cope with the fix to 8158402.


Please review.

Naoto

On 17/06/2016 09:09, Naoto Sato wrote:

I will take care of that along with other include locales issues.

Naoto

On 17/06/2016 01:14, Masayoshi Okutsu wrote:

I've been waiting for JDK-8159206 to be fixed. But this test still fails
after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and
pushed this test fix with the following ProblemList.txt change:

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -387,7 +387,7 @@

 # core_tools

-tools/jlink/plugins/IncludeLocalesPluginTest.java   8158272
generic-all
+tools/jlink/plugins/IncludeLocalesPluginTest.java   8159781
generic-all

 tools/jlink/JLinkOptimTest.java 8159264
generic-all


This test passes with b122  which has the CLDR upgrade.

Masayoshi

On 6/14/2016 5:18 AM, Alan Bateman wrote:

On 13/06/2016 16:02, Mandy Chung wrote:



I see.  I’m fine with what you have.  We should enhance the jlink
testlibrary to run java from a run-time image created for a test to
run.


I'm okay with it too.

-Alan

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

[Naoto Sato]

I will take care of that along with other include locales issues.

Naoto

On 17/06/2016 01:14, Masayoshi Okutsu wrote:

I've been waiting for JDK-8159206 to be fixed. But this test still fails
after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and
pushed this test fix with the following ProblemList.txt change:

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -387,7 +387,7 @@

 # core_tools

-tools/jlink/plugins/IncludeLocalesPluginTest.java   8158272
generic-all
+tools/jlink/plugins/IncludeLocalesPluginTest.java   8159781
generic-all

 tools/jlink/JLinkOptimTest.java 8159264
generic-all


This test passes with b122  which has the CLDR upgrade.

Masayoshi

On 6/14/2016 5:18 AM, Alan Bateman wrote:

On 13/06/2016 16:02, Mandy Chung wrote:



I see.  I’m fine with what you have.  We should enhance the jlink
testlibrary to run java from a run-time image created for a test to run.


I'm okay with it too.

-Alan

Re: RFR of JDK-8159762: Some minor test bugs in java/lang/module/ModuleDescriptorTest.java

[Hamlin Li]

On 2016/6/17 21:30, Alan Bateman wrote:



On 17/06/2016 04:22, Hamlin Li wrote:

Would you please review the following patch for some minor test bug?

bug: https://bugs.openjdk.java.net/browse/JDK-8159762
webrev: http://cr.openjdk.java.net/~mli/8159762/webrev.00/

This looks okay. If you then then you could expand coverage with 
testRequiresCompareWithSameModifiers too.

Thank you Alan,
Would you please check the new webrev which add 
testRequiresCompareWithSameModifiers? 
http://cr.openjdk.java.net/~mli/8159762/webrev.01/


Thank you
-Hamlin


-Alan

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

[Jan Lahoda]

Hi,

I've updated the patches, reflecting the feedback so far.

The langtools change is now split into two parts, one is only adding the 
new lint key (but no checks are actually performed):

http://cr.openjdk.java.net/~jlahoda/8153362/langtools.01-phase1/

And the second part is adding the checks:
http://cr.openjdk.java.net/~jlahoda/8153362/langtools.01-phase2/

We could push the first part first, and the second one together with 
other changes later, so that the repositories don't have to be updated 
in a lockstep.


In addition to the langtools changes, only the top-level repository 
needs to be changed now, to disable the checks in some modules:

http://cr.openjdk.java.net/~jlahoda/8153362/top-level.01/

Any feedback is welcome!

Thanks,
Jan

On 14.6.2016 14:29, Jan Lahoda wrote:

Hi Alan,

On 14.6.2016 12:57, Alan Bateman wrote:

On 13/06/2016 17:12, Jan Lahoda wrote:


Hello,

There is:
https://bugs.openjdk.java.net/browse/JDK-8153362

which is about a new warning that should be produced by javac when
exported API refers to types not exported/accessible to the API clients.

I've put my current javac change here:
http://cr.openjdk.java.net/~jlahoda/8153362/langtools.00/

Did you have a short list of names for the lint option before deciding
on "unexportedinapi"? If time has already been put into this and this is


I had a few (e.g. "publishingunexported"), but none of them particularly
nice.


the best of a bad bunch then ignore my mail. I bring it up because it
feels more like a "potentiallynotaccessible" or "notaccessible" or
"leaksnotaccessible". For the cases where we have ended up with


I like "leaksnotaccessible". Unless there would be better ideas or
objections, I'd go with that. Thanks for the ideas!


protected fields in public classes but the field type is package-private
then the field is never accessible. For the JSObject.getWindow case then
consumers will need to require java.desktop to use this method.

Related is the description:

javac.opt.Xlint.desc.unexportedinapi=\
 Warn about use of types not visible to clients in exported API

Shouldn't get say something about the type potentially not accessible
rather than visible?


Yes, it should. I'll fix that. Thanks for catching that.

Jan



-Alan

PS: You asked about the JVMCI classes in the hotspot repo. While this
might look strange then it is intentional. The "framework" uses the
reflective APIs to export the otherwise internal packages to the JVMCI
implementation when it is located and loaded.

Re: RFR of JDK-8159762: Some minor test bugs in java/lang/module/ModuleDescriptorTest.java

[Alan Bateman]

On 17/06/2016 04:22, Hamlin Li wrote:

Would you please review the following patch for some minor test bug?

bug: https://bugs.openjdk.java.net/browse/JDK-8159762
webrev: http://cr.openjdk.java.net/~mli/8159762/webrev.00/

This looks okay. If you then then you could expand coverage with 
testRequiresCompareWithSameModifiers too.


-Alan

hg: jigsaw/jake/jdk: 43 new changesets

[alan . bateman]

Changeset: 02285945f508
Author:darcy
Date:  2016-06-06 16:46 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/02285945f508

8158870: Temporarily problem list DGCDeadLock.java on Mac
Reviewed-by: smarks

! test/ProblemList.txt

Changeset: cb8524f24115
Author:weijun
Date:  2016-06-07 10:10 +0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cb8524f24115

8157308: Make AbstractDrbg non-Serializable
Reviewed-by: mullan

! src/java.base/share/classes/sun/security/provider/AbstractDrbg.java
! src/java.base/share/classes/sun/security/provider/AbstractHashDrbg.java
! src/java.base/share/classes/sun/security/provider/CtrDrbg.java
! src/java.base/share/classes/sun/security/provider/DRBG.java
! src/java.base/share/classes/sun/security/provider/HashDrbg.java
! src/java.base/share/classes/sun/security/provider/HmacDrbg.java
! src/java.base/share/classes/sun/security/provider/MoreDrbgParameters.java
+ test/sun/security/provider/SecureRandom/AbstractDrbg/SpecTest.java
+ 
test/sun/security/provider/SecureRandom/AbstractDrbg/java.base/sun/security/provider/S.java
- test/sun/security/provider/SecureRandom/AbstractDrbgSpec.java
+ test/sun/security/provider/SecureRandom/DRBGS11n.java

Changeset: c9ae01b75d87
Author:weijun
Date:  2016-06-07 10:11 +0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/c9ae01b75d87

8158442: SecureRandomParameters missing "@since 9"
Reviewed-by: mullan, wetmore

! src/java.base/share/classes/java/security/SecureRandomParameters.java

Changeset: 27a845baacec
Author:weijun
Date:  2016-06-07 10:33 +0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/27a845baacec

8151836: keytool -importkeystore -help does not list option -destprotected
Reviewed-by: xuelei

! src/java.base/share/classes/sun/security/tools/keytool/Main.java

Changeset: 85c2453a8020
Author:prappo
Date:  2016-06-07 12:29 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/85c2453a8020

8156650: Simplify Text message support in WebSocket API
Reviewed-by: rriggs

! src/java.httpclient/share/classes/java/net/http/WS.java
- src/java.httpclient/share/classes/java/net/http/WSDisposableText.java
! src/java.httpclient/share/classes/java/net/http/WSFrameConsumer.java
! src/java.httpclient/share/classes/java/net/http/WSMessageConsumer.java
! src/java.httpclient/share/classes/java/net/http/WSReceiver.java
! src/java.httpclient/share/classes/java/net/http/WebSocket.java

Changeset: fdc7891782ef
Author:akolarkunnu
Date:  2016-06-07 11:43 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/fdc7891782ef

8073611: javax.script.ScriptEngineFactory: formatting error in javadoc of 
getParameter
Reviewed-by: sundar

! src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java

Changeset: bf910aef39d4
Author:akosarev
Date:  2016-06-07 08:54 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/bf910aef39d4

8157603: TestCipher.java doesn't check one of the decrypted message as expected
Reviewed-by: valeriep

! test/com/sun/crypto/provider/Cipher/TestCipher.java

Changeset: 4f8e07921d19
Author:ssahoo
Date:  2016-06-07 09:00 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4f8e07921d19

8157896: TestDSAGenParameterSpec.java test fails with timeout
8157898: SupportedDSAParamGen.java failed with timeout
Reviewed-by: xuelei

! test/sun/security/provider/DSA/SupportedDSAParamGen.java
! test/sun/security/provider/NSASuiteB/TestDSAGenParameterSpec.java

Changeset: 95bf0932aa78
Author:nishjain
Date:  2016-06-08 12:54 +0900
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/95bf0932aa78

8047780: [Doc] Locale.LanguageRange() throws an undocumented IAE when range is 
ill-formed.
Reviewed-by: okutsu, peytoia

! src/java.base/share/classes/java/util/Locale.java

Changeset: ea35f7971115
Author:shade
Date:  2016-06-08 11:14 +0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ea35f7971115

8158851: MH.publicLookup() init circularity, triggered by custom 
SecurityManager with String concat and -limitmods java.base
Reviewed-by: alanb, redestad, jlaskey

! src/java.base/share/classes/java/lang/System.java
! src/java.base/share/classes/java/lang/invoke/MethodHandles.java
! test/java/lang/String/concat/WithSecurityManager.java

Changeset: 4f717d517d9e
Author:amlu
Date:  2016-06-08 16:25 +0800
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4f717d517d9e

8159012: Problem list sun/net/www/http/ChunkedOutputStream/checkError.java
Reviewed-by: chegar

! test/ProblemList.txt

Changeset: 24c643add3fb
Author:hannesw
Date:  2016-06-08 15:50 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/24c643add3fb

8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist
Reviewed-by: sundar, mhaupt

! src/jdk.internal.le/share/classes/jdk/internal/jline/extra/EditingHistory.java

Changeset: e80525b7d07d
Author:prappo
Date:  

hg: jigsaw/jake/jaxws: 2 new changesets

[alan . bateman]

Changeset: 1600da1665cd
Author:lana
Date:  2016-06-16 19:07 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/1600da1665cd

Added tag jdk-9+123 for changeset c42decd28bbf

! .hgtags

Changeset: 34b647f33612
Author:alanb
Date:  2016-06-17 11:33 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/34b647f33612

Merge

hg: jigsaw/jake/langtools: 14 new changesets

[alan . bateman]

Changeset: bcebe24cd346
Author:rfield
Date:  2016-06-08 00:32 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/bcebe24cd346

8139829: JShell API: No use of fields to return information from public types
Reviewed-by: vromero

! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/ConsoleIOContext.java
! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
! src/jdk.jshell/share/classes/jdk/jshell/Diag.java
! src/jdk.jshell/share/classes/jdk/jshell/Eval.java
! src/jdk.jshell/share/classes/jdk/jshell/ImportSnippet.java
! src/jdk.jshell/share/classes/jdk/jshell/JShell.java
! src/jdk.jshell/share/classes/jdk/jshell/Snippet.java
! src/jdk.jshell/share/classes/jdk/jshell/SnippetEvent.java
! src/jdk.jshell/share/classes/jdk/jshell/SnippetMaps.java
! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysis.java
! src/jdk.jshell/share/classes/jdk/jshell/SourceCodeAnalysisImpl.java
! src/jdk.jshell/share/classes/jdk/jshell/Unit.java
! test/jdk/jshell/ClassMembersTest.java
! test/jdk/jshell/CompletenessStressTest.java
! test/jdk/jshell/KullaTesting.java
! test/jdk/jshell/ReplToolTesting.java
! test/jdk/jshell/SnippetTest.java

Changeset: 110c3750f1ff
Author:jlahoda
Date:  2016-06-09 14:20 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/110c3750f1ff

8158174: jshell tool: leaks threads waiting on StopDetectingInputStream
Summary: Shutdown StopDetectingInputStream when closing the ConsoleIOContext.
Reviewed-by: rfield

! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/ConsoleIOContext.java
! 
src/jdk.jshell/share/classes/jdk/internal/jshell/tool/StopDetectingInputStream.java

Changeset: b94f9c167fba
Author:lana
Date:  2016-06-09 19:06 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/b94f9c167fba

Merge


Changeset: 8d765a5c7ba5
Author:bpatel
Date:  2016-06-09 23:24 -0700
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8d765a5c7ba5

8156077: Support javadoc tags in module documentation
Reviewed-by: jjg

! src/jdk.javadoc/share/classes/jdk/javadoc/doclet/taglet/Taglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/ModuleSummaryWriter.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclet.xml
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/BaseExecutableMemberTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/BasePropertyTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/BaseTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/InheritDocTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/SimpleTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/Taglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/UserTaglet.java
! 
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ValueTaglet.java
! test/jdk/javadoc/doclet/testModules/TestModules.java
+ test/jdk/javadoc/doclet/testModules/moduletags/module-info.java
+ 
test/jdk/javadoc/doclet/testModules/moduletags/testpkgmdltags/TestClassInModuleTags.java

Changeset: 544eda2e9f08
Author:ntv
Date:  2016-06-10 11:11 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/544eda2e9f08

8155581: jshell tool: replace use of Option.get()
Reviewed-by: rfield

! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java

Changeset: 0bf0d57dfdfa
Author:dlsmith
Date:  2016-06-10 15:08 -0600
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/0bf0d57dfdfa

8144767: Fix handling of capture variables in most-specific test
Reviewed-by: vromero

! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java
! test/tools/javac/lambda/MostSpecific28.java
! test/tools/javac/lambda/MostSpecific28.out
+ test/tools/javac/lambda/MostSpecific29.java
+ test/tools/javac/lambda/MostSpecific30.java
+ test/tools/javac/lambda/MostSpecific30.out
+ test/tools/javac/lambda/MostSpecific31.java
+ test/tools/javac/lambda/MostSpecific31.out
+ test/tools/javac/lambda/MostSpecific32.java
+ test/tools/javac/lambda/MostSpecific32.out

Changeset: cd884e553cd6
Author:dlsmith
Date:  2016-06-10 16:43 -0600
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/cd884e553cd6

8037804: Implement specified test for related functional interface types
Reviewed-by: vromero

! 

hg: jigsaw/jake: 8 new changesets

[alan . bateman]

Changeset: 89769a2f1511
Author:erikj
Date:  2016-06-07 15:42 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/89769a2f1511

8158535: Configure script uses basic tools directly in many places
Reviewed-by: dholmes

! common/autoconf/basics.m4
! common/autoconf/basics_windows.m4
! common/autoconf/boot-jdk.m4
! common/autoconf/build-performance.m4
! common/autoconf/flags.m4
! common/autoconf/generated-configure.sh
! common/autoconf/jdk-options.m4
! common/autoconf/libraries.m4
! common/autoconf/toolchain.m4

Changeset: 55b73f768d17
Author:erikj
Date:  2016-06-09 10:40 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/55b73f768d17

8159047: Disable redundant build steps when creating buildjdk
Reviewed-by: tbell, dholmes

! make/Main.gmk

Changeset: b3e99e35f148
Author:jlaskey
Date:  2016-06-09 11:12 -0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/b3e99e35f148

8158402: jlink: should use regex for all pattern operations (--order-resources 
or --exclude-resources)
Reviewed-by: sundar

! make/Images.gmk

Changeset: 55cca6be7838
Author:lana
Date:  2016-06-09 19:06 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/55cca6be7838

Merge


Changeset: 15b843f12c30
Author:erikj
Date:  2016-06-10 16:56 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/15b843f12c30

8055735: JDK_FILTER is broken
Reviewed-by: redestad, alanb, tbell

! make/CompileJavaModules.gmk
! make/common/JavaCompilation.gmk

Changeset: 405d811c0d7b
Author:erikj
Date:  2016-06-10 16:59 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/405d811c0d7b

8144911: Consider having modifications to jdk.jlink trigger recreation of all 
jmods
Reviewed-by: tbell

! make/CreateJmods.gmk

Changeset: 5244c79bbc9a
Author:lana
Date:  2016-06-16 19:07 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/5244c79bbc9a

Added tag jdk-9+123 for changeset 405d811c0d7b

! .hgtags

Changeset: 1d9cd7104d46
Author:alanb
Date:  2016-06-17 11:31 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/rev/1d9cd7104d46

Merge

! common/autoconf/basics.m4
! common/autoconf/boot-jdk.m4
! common/autoconf/flags.m4
! common/autoconf/generated-configure.sh
! common/autoconf/jdk-options.m4
! common/autoconf/toolchain.m4
! make/CompileJavaModules.gmk
! make/CreateJmods.gmk
! make/Images.gmk
! make/Main.gmk
! make/common/JavaCompilation.gmk

hg: jigsaw/jake/corba: 2 new changesets

[alan . bateman]

Changeset: 35d52de48e19
Author:lana
Date:  2016-06-16 19:07 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/35d52de48e19

Added tag jdk-9+123 for changeset e33a34cc5519

! .hgtags

Changeset: 523e842079ed
Author:alanb
Date:  2016-06-17 11:32 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/corba/rev/523e842079ed

Merge

hg: jigsaw/jake/nashorn: 7 new changesets

[alan . bateman]

Changeset: 64f922ff84bb
Author:sundar
Date:  2016-06-07 19:13 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/64f922ff84bb

8158922: jjs tab completion of Java classes shows package-private, "hidden" 
classes too
Reviewed-by: hannesw, mhaupt

! src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/Main.java
! 
src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/PackagesHelper.java
! 
src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/PropertiesHelper.java

Changeset: 6db58b7709f3
Author:hannesw
Date:  2016-06-08 15:53 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/6db58b7709f3

8159031: jjs throws NoSuchFileException if ~/.jjs.history does not exist
Reviewed-by: sundar, mhaupt

! 
src/jdk.scripting.nashorn.shell/share/classes/jdk/nashorn/tools/jjs/Console.java

Changeset: b30f5b333179
Author:sundar
Date:  2016-06-08 20:35 +0530
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/b30f5b333179

8159034: 4 nashorn ant tests fail with latest jdk9-dev build with 
IncompatibleClassChangeError
Reviewed-by: hannesw, jlaskey

! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java

Changeset: 773965f670aa
Author:lana
Date:  2016-06-09 19:07 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/773965f670aa

Merge


Changeset: 9ed859b4faaf
Author:hannesw
Date:  2016-06-13 12:39 +0200
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/9ed859b4faaf

8159220: Preserve position info in module import and export entries
Reviewed-by: sundar, lagergren

! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/ir/Module.java
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/parser/Parser.java
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/parser/ParserContextModuleNode.java

Changeset: 851801e6ba92
Author:lana
Date:  2016-06-16 19:07 +
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/851801e6ba92

Added tag jdk-9+123 for changeset 9ed859b4faaf

! .hgtags

Changeset: 464e22331451
Author:alanb
Date:  2016-06-17 11:32 +0100
URL:   http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/464e22331451

Merge

! .hgtags
! 
src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java

Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

[Alan Bateman]

On 17/06/2016 03:28, Jonathan Gibbons wrote:

Please review this simple fix for two related aspects of the same 
problem:


Export the "standard doclet" used by javadoc, such that it is possible 
to derive alternative doclets, either by delegation or subtyping.


In JDK 9, javadoc has a "new" standard doclet (JEP 221), but the old 
one remains for compatibility, for the time being. Both should be 
exported.



Jigsaw folk:
Please review the changes to jdk.javadoc module-info.

Build folk:
The javadoc documentation is extended to include the documentation 
for the package containing the new StandardDoclet.
(The API for the old StandardDoclet was never published in this 
manner; it is only included in the javadoc tool guide, which remains 
unchanged, for now.)


javadoc folk:
The top level class for the new StandardDoclet is moved, without 
any functional change, from an internal package to the new exported 
package.


JBS: https://bugs.openjdk.java.net/browse/JDK-8154399
https://bugs.openjdk.java.net/browse/JDK-8159096
Webrev: http://cr.openjdk.java.net/~jjg/8154399/webrev.00
This looks okay to me, I just wonder if StandardDoclet should be final - 
do you remember want that to be extended?


-Alan

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

[Masayoshi Okutsu]

I've been waiting for JDK-8159206 to be fixed. But this test still fails 
after the JDK-8159206 fix. I've filed JDK-8159781 for the failure and 
pushed this test fix with the following ProblemList.txt change:


diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -387,7 +387,7 @@
 
 # core_tools
 
-tools/jlink/plugins/IncludeLocalesPluginTest.java   8158272 generic-all

+tools/jlink/plugins/IncludeLocalesPluginTest.java   8159781 
generic-all
 
 tools/jlink/JLinkOptimTest.java 8159264 generic-all
 


This test passes with b122  which has the CLDR upgrade.

Masayoshi

On 6/14/2016 5:18 AM, Alan Bateman wrote:

On 13/06/2016 16:02, Mandy Chung wrote:



I see.  I’m fine with what you have.  We should enhance the jlink 
testlibrary to run java from a run-time image created for a test to run.



I'm okay with it too.

-Alan