hg: jigsaw/jake/hotspot: Small clarification to JVM TI AddModuleExports/AddModuleOpens
Changeset: f2dcbf337bc4 Author:alanb Date: 2016-11-03 07:27 + URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/f2dcbf337bc4 Small clarification to JVM TI AddModuleExports/AddModuleOpens ! src/share/vm/prims/jvmti.xml
[9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options
Hi, I've done some rework accordingly to Alan's and Shura's comments: 1) removed overlapped tests from JImageToolTest.java; 2) added new tests JImageVerifyTest.java for jimage verify; 3) reorganized jtreg's tags; The new WEBREV can be found here: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.01/ Thank you, Denis. On 06.10.2016 19:37, Denis Kononenko wrote: Hi, Could someone please review these new tests for jimage utility. There're 5 new files containing tests to cover use cases for 'info', 'list', 'extract' and other options. No new tests for 'verify'. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240 WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/ Thank you, Denis.
Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options
Nice work. +1 > On Nov 3, 2016, at 10:29 AM, Denis Kononenko > wrote: > > Hi, > > I've done some rework accordingly to Alan's and Shura's comments: > > 1) removed overlapped tests from JImageToolTest.java; > > 2) added new tests JImageVerifyTest.java for jimage verify; > > 3) reorganized jtreg's tags; > > The new WEBREV can be found here: > http://cr.openjdk.java.net/~dkononenko/8167240/webrev.01/ > > Thank you, > Denis. > > On 06.10.2016 19:37, Denis Kononenko wrote: >> Hi, >> >> Could someone please review these new tests for jimage utility. >> >> There're 5 new files containing tests to cover use cases for 'info', 'list', >> 'extract' and other options. No new tests for 'verify'. >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240 >> WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/ >> >> >> Thank you, >> Denis. >
Re: [9] RFR: 8167240: Write new tests to cover functionality of existing 'jimage' options
Denis, I can see that you have switched to the top level test library with this change. With that you are getting more module dependencies than just java.base. First of all, it would probably make sense to build only the classes you needed (which would be jdk.test.lib.process.ProcessTools, I assume), but even if you only build that, jdk.test.lib.process.ProcessTools has dependencies outside java.base module. You either have to declare @modules in your test or go back to the jdk/test/lib/testlibrary. Then, of course, unneeded module dependencies are questionable. Shura > On Nov 3, 2016, at 6:29 AM, Denis Kononenko > wrote: > > Hi, > > I've done some rework accordingly to Alan's and Shura's comments: > > 1) removed overlapped tests from JImageToolTest.java; > > 2) added new tests JImageVerifyTest.java for jimage verify; > > 3) reorganized jtreg's tags; > > The new WEBREV can be found here: > http://cr.openjdk.java.net/~dkononenko/8167240/webrev.01/ > > Thank you, > Denis. > > On 06.10.2016 19:37, Denis Kononenko wrote: >> Hi, >> >> Could someone please review these new tests for jimage utility. >> >> There're 5 new files containing tests to cover use cases for 'info', 'list', >> 'extract' and other options. No new tests for 'verify'. >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8167240 >> WEBREV: http://cr.openjdk.java.net/~dkononenko/8167240/webrev.00/ >> >> >> Thank you, >> Denis. >
hg: jigsaw/jake/langtools: 3 new changesets
Changeset: 3286b60836a5 Author:jjg Date: 2016-11-03 13:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/3286b60836a5 temporary fix to merge multiple provides for a service ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java Changeset: 03cece156818 Author:jjg Date: 2016-11-03 13:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/03cece156818 update remaining tests to use :open as needed ! test/jdk/jshell/HistoryTest.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/modules/PatchModulesTest.java ! test/tools/javac/platform/PlatformProviderTest.java ! test/tools/javac/processing/model/TestSymtabItems.java ! test/tools/javac/scope/DupUnsharedTest.java ! test/tools/javac/scope/HashCollisionTest.java ! test/tools/javac/types/ScopeListenerTest.java Changeset: 8f326cd2eac5 Author:jjg Date: 2016-11-03 13:37 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/8f326cd2eac5 Merge
hg: jigsaw/jake/langtools: javadoc should change "requires public" to "requires transitive"
Changeset: 2b552c8cff2b Author:jjg Date: 2016-11-03 18:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/2b552c8cff2b javadoc should change "requires public" to "requires transitive" ! src/jdk.javadoc/share/classes/jdk/javadoc/doclet/package-info.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolOption.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties ! test/jdk/javadoc/tool/modules/Modules.java
