RFR (XS): 8220409: [TESTBUG] jdk jtreg test jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java - testOverlapWithBaseModule tests the wrong thing
Hi, please review this small test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8220409 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8220409.0/ The test uses a wrong option "-add-modules" instead of "--add-modules" in one place. Thanks Christoph
Re: RFR (XS): 8220409: [TESTBUG] jdk jtreg test jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java - testOverlapWithBaseModule tests the wrong thing
On 11/03/2019 08:50, Langer, Christoph wrote: Hi, please review this small test fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8220409 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8220409.0/ The test uses a wrong option "-add-modules" instead of "--add-modules" in one place. The change to testOverlapWithBaseModule looks okay, the changes to the imports are not needed but okay too. -Alan
RE: RFR (XS): 8220409: [TESTBUG] jdk jtreg test jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java - testOverlapWithBaseModule tests the wrong thing
Thanks for the review, Alan. I pushed it. > -Original Message- > From: Alan Bateman > Sent: Montag, 11. März 2019 10:04 > To: Langer, Christoph ; Java Core Libs d...@openjdk.java.net>; jigsaw-dev > Subject: Re: RFR (XS): 8220409: [TESTBUG] jdk jtreg test > jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java > - testOverlapWithBaseModule tests the wrong thing > > On 11/03/2019 08:50, Langer, Christoph wrote: > > Hi, > > > > please review this small test fix. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8220409 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8220409.0/ > > > > The test uses a wrong option "-add-modules" instead of "--add-modules" > in one place. > > > The change to testOverlapWithBaseModule looks okay, the changes to the > imports are not needed but okay too. > > -Alan >
