Re: Should ClassLoader::getResouces return the same resource twice?

[James Laskey]

As an aside, creating a FileSystem is not an onerous task. 

https://stackoverflow.com/questions/22966176/creating-a-custom-filesystem-implementation-in-java

Cheers,

— Jim



> On Jan 2, 2021, at 8:59 AM, Thiago Henrique Hupner  wrote:
> 
> I guess a little context can make more things clear:
> The servlet spec requires that all jars from WEB-INF/lib
> be available to the same classloader.
> The resource, in particular, is "META-INF/web-fragment.xml"
> Each jar can contain its own. So, using getResources make sense
> in order of parsing each. However, what is happening is if I have two JARs
> each with its own META-INF/web-fragment.xml, using the ModuleReader
> it is returning four resources, so it parses more than it should and it
> fails
> to parse the same resource twice.
> 
> I'll have a try only exposing the ".class" files in the ModuleReader,
> so the Loader will be able to create the classes and it will read the
> resources
> from the classloader.
> 
> I'm using my own implementations of the ModuleReader, ModuleFinder
> and ModuleDescriptor because all of our resources are in memory I wasn't
> able to
> use the ModuleFinder.of() because it requires a filesystem.
> 
>> Em sáb., 2 de jan. de 2021 às 04:07, Alan Bateman 
>> escreveu:
>> 
>>> On 02/01/2021 03:21, Thiago Henrique Hupner wrote:
>>> :
>>> 
>>> I've created a simple example of what is occurring [1].
>>> I know there are behavior specific for getting a class if it is in a
>> module,
>>> but I don't know if this may be a bug in the resource loading mechanism.
>>> In the example, the returned values are different to illustrate, but in
>> my
>>> case, it
>>> returns two exact URLs for the same resource as the source for the module
>>> reader
>>> and the classloader is the same.
>> The behavior you observe with the example is correct.
>> ClassLoader.getResources locates the resource by searching the lass
>> loader delegation chain and in the example there are two "foo"
>> resources. The resource in module fake.module is located because it is
>> an automatic module that opens all its packages unconditionally. The
>> second resource is located by searching the parent class loader, a
>> URLClassLoader in the example that also locates "foo".  Which "foo" did
>> you expect to locate? If code in fake.module just wants to locate the
>> resource in its own module then it should use getResource rather than
>> getResources.
>> 
>> -Alan.
>> 

Re: RFR 8246034: Remove java.base/share/classes/jdk/internal/jrtfs/jrtfsviewer.js and java.base/share/classes/jdk/internal/jrtfs/jrtls.js

[James Laskey]

+1



> On May 28, 2020, at 3:16 AM, sundararajan.athijegannat...@oracle.com wrote:
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8246034
> 
> Webrev: http://cr.openjdk.java.net/~sundar/8246034/webrev.00/
> 
> Thanks
> 
> -Sundar
> 

Re: RFR 8222100: tools/jimage/JImageTest.java time out

[James Laskey]

+1

On the road.

> On Jan 13, 2020, at 10:25 AM, sundararajan.athijegannat...@oracle.com wrote:
> 
> Bumping the default timeout (other tests in the same dir have similar 
> timeout settings).
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222100
> 
> Webrev: http://cr.openjdk.java.net/~sundar/8222100/webrev.00/
> 
> Thanks,
> 
> -Sundar
> 

Re: Nashorn on the module-path

[James Laskey]

Christian, I can’t see the rest of the thread so I don’t have a context.  

Sent from my iPhone

On May 26, 2019, at 6:17 AM, Christian Stein  wrote:

>> Have you brought this up on nashorn-dev...
> 
> No, but cc-ed that list now.
> 
>> ...as this might require digging into the dynalink linker
>> and how method handles are used.
> 
> Do you think it's still worth the effort in regard of Nashorn
> being deprecated for removal? Perhaps the underlying
> reason may show up on/in a different module, soon.
> 
> Said that, the JUnit 5 team decided to remove "script-
> based conditions" from Jupiter. So, "we" won't be affected
> by this issue in the near future anymore.
> 
> [1] https://github.com/junit-team/junit5/issues/1882
> 
> 
> 
> On Sun, May 26, 2019 at 10:35 AM Alan Bateman 
> wrote:
> 
>> On 16/05/2019 15:02, Christian Stein wrote:
>> 
>> :
>> 
>> It didn't emit any new line. Is there another debug switch I can enable?
>> 
>> Have you brought this up on nashorn-dev as this might require digging into
>> the dynalink linker and how method handles are used.
>> 
>> -Alan
>> 

Re: RFR(S): 8219142: Make libjimage strncpy uses GCC 8.x friendly

[James Laskey]

The only user IIRC is the native class loader. It’s possible, due to the 
evolution of the API, that this entry is no longer used. Kill and verify. 

Sent from my iPhone

> On Feb 15, 2019, at 6:31 PM, Mikael Vidstedt  
> wrote:
> 
> 
> This is interesting. I agree that the code should handle an overflow in a 
> better way, throwing an exception seems like the reasonable thing to do. I 
> started looking at doing exactly that.
> 
> However, that also made me have a look at how this code is actually used, 
> and..
> 
> It’s not obvious that it actually is..
> 
> AFAICT, ImageFileReader::location_path is only used from JIMAGE_ResourcePath 
> (in jimage.cpp). The only “user” I can find of that function in the JDK is in 
> hotspot:
> 
> src/hotspot/share/classfile/classLoader.cpp:static JImage_ResourcePath_t  
>  JImageResourcePath = NULL;
> src/hotspot/share/classfile/classLoader.cpp:  JImageResourcePath = 
> CAST_TO_FN_PTR(JImage_ResourcePath_t, os::dll_lookup(handle, 
> "JIMAGE_ResourcePath"));
> src/hotspot/share/classfile/classLoader.cpp:  guarantee(JImageResourcePath != 
> NULL, "function JIMAGE_ResourcePath not found”);
> 
> That’s the declaration of a variable, the initialization of it, and the check 
> to make sure the lookup actually succeeded. However, the variable isn’t 
> actually used anywhere after that.
> 
> Is this dead code which should just be removed instead? Or is 
> JIMAGE_ResourcePath considered exported? Can (non-JDK) native code expect to 
> find and use it?
> 
> Cheers,
> Mikael
> 
>> On Feb 15, 2019, at 1:58 PM, James Laskey  wrote:
>> 
>> I wonder if you should flag overflow so no attempt is made to search with a 
>> bogus path. It’s not necessary but prevent future misunderstandings. 
>> 
>> Sent from my iPhone
>> 
>>> On Feb 15, 2019, at 5:24 PM, Mikael Vidstedt  
>>> wrote:
>>> 
>>> 
>>> Please review this change which addresses some warnings generated by GCC 
>>> 8.2 related to the uses of strncpy in libjimage/imageFile.cpp.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219142
>>> Webrev: 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/ 
>>> <http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/>
>>> 
>>> 
>>> In addition to feedback on the change itself, I’m taking suggestions on 
>>> what tests to run. An earlier version of the change passed the typical 
>>> tier1 testing. I’m going to run tier1 on this version as well, but let me 
>>> know if there are additional tests I should run.
>>> 
>>> Cheers,
>>> Mikael
>>> 
>> 
> 

Re: RFR(S): 8219142: Make libjimage strncpy uses GCC 8.x friendly

[James Laskey]

I wonder if you should flag overflow so no attempt is made to search with a 
bogus path. It’s not necessary but prevent future misunderstandings. 

Sent from my iPhone

> On Feb 15, 2019, at 5:24 PM, Mikael Vidstedt  
> wrote:
> 
> 
> Please review this change which addresses some warnings generated by GCC 8.2 
> related to the uses of strncpy in libjimage/imageFile.cpp.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8219142
> Webrev: 
> http://cr.openjdk.java.net/~mikael/webrevs/8219142/webrev.00/open/webrev/ 
> 
> 
> 
> In addition to feedback on the change itself, I’m taking suggestions on what 
> tests to run. An earlier version of the change passed the typical tier1 
> testing. I’m going to run tier1 on this version as well, but let me know if 
> there are additional tests I should run.
> 
> Cheers,
> Mikael
> 

Re: RFR 8212137: Remove JrtFileSystem finalize method

[James Laskey]

+1

Sent from my iPhone

> On Dec 7, 2018, at 4:47 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212137
> Webrev: https://cr.openjdk.java.net/~sundar/8212137/webrev.00/
> 
> Thanks,
> -Sundar

Re: RFR: 8202810: Remove class-for-name test

[James Laskey]

+1

Sent from my iPhone

> On May 8, 2018, at 5:45 PM, Claes Redestad  wrote:
> 
> Hi,
> 
> please review the removal of this test that explicitly attempts to run the 
> now removed jlink --class-for-name plugin:
> 
> diff -r 7f05a1e6a02a test/jdk/tools/jlink/JLinkPluginsTest.java
> --- a/test/jdk/tools/jlink/JLinkPluginsTest.javaTue May 08 15:42:19 2018 
> +0200
> +++ b/test/jdk/tools/jlink/JLinkPluginsTest.javaTue May 08 22:46:14 2018 
> +0200
> @@ -77,14 +77,6 @@
>  helper.checkImage(imageDir, moduleName, res, null);
>  }
>  {
> -// Optimize Class.forName
> -String[] userOptions = {"--class-for-name"};
> -String moduleName = "classforname";
> -helper.generateDefaultJModule(moduleName, "composite2");
> -Path imageDir = helper.generateDefaultImage(userOptions, 
> moduleName).assertSuccess();
> -helper.checkImage(imageDir, moduleName, null, null);
> -}
> -{
>  // disable generate jli classes - JDK-8160063
>  String[] userOptions = {"--disable-plugin", 
> "generate-jli-classes"};
>  String moduleName = "jlidisabled";
> 
> /Claes

Re: RFR: JDK-8158407 - jimage: verify should do more extensive test

[James Laskey]

I had frame verification code. Since removed (required class loading). Will 
fix. 

Sent from my iPhone

> On Jul 20, 2016, at 3:15 PM, Alan Bateman  wrote:
> 
> 
> 
>> On 20/07/2016 18:19, Jim Laskey (Oracle) wrote:
>> http://cr.openjdk.java.net/~jlaskey/8158407/webrev/index.html
>> https://bugs.openjdk.java.net/browse/JDK-8158407
> Looks okay, just wondering about EXPAND_FRAMES as I assume that isn't needed 
> (0 will do).
> 
> -Alan

Re: RFR: JDK-8161067 - jlink: Enable plugins to use the module pool for class lookup

[James Laskey]

Sent from my iPhone

> On Jul 11, 2016, at 11:09 AM, Paul Sandoz  wrote:
> 
> 
>> On 11 Jul 2016, at 14:17, Jim Laskey (Oracle)  
>> wrote:
>> 
>> I’m not sure if we can determine supplied classes vs others unless we 
>> provide a flag or the set of supplied modules.  At any rate, the rules for 
>> cross module optimization would still be complex.
> 
> Ok.
> 
> 
>> ModuleEntry.findEntry: I was half thinking the same once I realized the 
>> limits of the lookup.  The complication is that a ModuleEntry may exist in 
>> several pools (direct copy).  So, though we have to create new LinkModules 
>> each pass, we would also be forced to create new ModuleEntrys for each pass. 
>>  In practice, I’m not sure findEntry will be used frequently in relation to 
>> the #plugins x #classes.
> 
> Ah, i see, so the rule being: go back to the pool to query for stuff.
> 
> How about the following helper method on ModulePool:
> 
>   Optional findModule(ModuleEntry me);
> 
> then the intent in code might be a littler clearer on the context.
> 

Ok

> 
> ImagePluginStack
> 
> 407 return res.isPresent()? 
> Optional.of(getUncompressed(res.get())) : Optional.empty();
> 
> You could do:
> 
>  return res.map(this::getUncompressed);
> 

Good


> 
> ClassForNamePLugin
> 
> 148 .filter(resource -> resource != null)
> 
> Can a resource ever be null?

I don't think it can. Just cloning JFs code. Might have true at some point. 
Will drop and see what falls out. 

> 
> Paul.

Re: Having problem building jdk9-dev

[James Laskey]

Wonder if we should have a configuration warning when an inappropriate version 
is used. 

Sent from my iPhone

> On May 11, 2016, at 8:35 AM, Aleksey Shipilev  
> wrote:
> 
>> On 05/11/2016 02:28 PM, Alan Bateman wrote:
>>> On 11/05/2016 12:14, Aleksey Shipilev wrote:
>>> Got the same today, and figured it only fails with JDK 9 as the boot
>>> JDK. Builds fine with JDK 8 as boot JDK. Filed:
>>>   https://bugs.openjdk.java.net/browse/JDK-8156740
>> You can never guarantee that the JDK N in development will build with a
>> older build of JDK N, there is just too much churn. Boot cycles builds
>> should be fine of course, meaning a JDK build should be able to build
>> itself (make bootcycle-images).
> 
> No problem with that. Let's close the bug with WNF and this description
> then, so the next person facing this particular issue knows the
> corrective action immediately.
> 
> Thanks,
> -Aleksey
> 
> 

Fwd: RFR: JDK-8151806 - JImage decompress code needs to be revised to be more effective

[James Laskey]

Sent from my iPhone

Begin forwarded message:

> From: "Jim Laskey (Oracle)" 
> Date: April 1, 2016 at 4:15:50 PM ADT
> To: jdk9-dev 
> Subject: RFR: JDK-8151806 - JImage decompress code needs to be revised to be 
> more effective
> 
> https://bugs.openjdk.java.net/browse/JDK-8151806 
> 
> http://cr.openjdk.java.net/~jlaskey/8151806/webrev/index.html 
> 
> 
> Clean up some sloppy code.
> 
> 

hg: jigsaw/jake/jdk: M3 jdk8-dev review changes.

[james . laskey]

Changeset: 3067409f5ab9
Author:jlaskey
Date:  2016-03-14 16:53 -0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3067409f5ab9

M3 jdk8-dev review changes.

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageBufferCache.java
! src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageLocation.java
- src/java.base/share/classes/jdk/internal/jimage/ImageLocationBase.java
- src/java.base/share/classes/jdk/internal/jimage/ImageModuleData.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStream.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStrings.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStringsReader.java
! src/java.base/share/classes/jdk/internal/jimage/NativeImageBuffer.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressIndexes.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressedResourceHeader.java
! src/java.base/share/classes/jdk/internal/jimage/decompressor/Decompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressorFactory.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressorRepository.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/SignatureParser.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/StringSharingDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/StringSharingDecompressorFactory.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressorFactory.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageLocationWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java

hg: jigsaw/jake/hotspot: 8146560: Rename modules/bootmodules.jimage to modules

[james . laskey]

Changeset: 782d00823652
Author:jlaskey
Date:  2016-01-29 10:35 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/782d00823652

8146560: Rename modules/bootmodules.jimage to modules
Reviewed-by: alanb

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/classLoader.hpp
! src/share/vm/classfile/jimage.hpp
! src/share/vm/classfile/modules.cpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/memory/filemap.cpp
! src/share/vm/memory/filemap.hpp
! src/share/vm/runtime/os.cpp
! test/runtime/BootClassAppendProp/BootClassPathAppendProp.java
! test/runtime/modules/Visibility/XbootcpNoVisibility.java
! test/runtime/modules/Xpatch/XpatchTraceCL.java

hg: jigsaw/jake/langtools: 8146560: Rename modules/bootmodules.jimage to modules

[james . laskey]

Changeset: d760db7daa2a
Author:jlaskey
Date:  2016-01-29 10:35 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/d760db7daa2a

8146560: Rename modules/bootmodules.jimage to modules
Reviewed-by: alanb

! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java
! test/tools/javac/diags/CheckResourceKeys.java

hg: jigsaw/jake/jdk: 8146560: Rename modules/bootmodules.jimage to modules

[james . laskey]

Changeset: 884ea77a8508
Author:jlaskey
Date:  2016-01-29 10:35 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/884ea77a8508

8146560: Rename modules/bootmodules.jimage to modules
Reviewed-by: alanb

! src/java.base/share/classes/java/lang/module/ModuleFinder.java
! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtExplodedFileSystem.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java
! src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java
! src/java.base/share/classes/jdk/internal/jrtfs/SystemImages.java
! src/java.base/share/native/libjimage/jimage.cpp
! src/java.base/share/native/libjimage/jimage.hpp
! src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/BasicImageWriter.java
! test/jdk/internal/jimage/JImageReadTest.java
! test/jdk/jigsaw/tools/jimage/JImageTest.java
! test/jdk/jigsaw/tools/jimage/JImageToolTest.java
! test/jdk/jigsaw/tools/jimage/VerifyJimage.java
! test/jdk/jigsaw/tools/jlink/IntegrationTest.java
! test/jdk/jigsaw/tools/lib/tests/JImageValidator.java
! test/sun/net/www/protocol/jrt/WithSecurityManager.java
! test/tools/pack200/ModuleAttributes.java
! test/tools/pack200/Utils.java

hg: jigsaw/jake/jdk: Remove use of RandomAccessFile from jimage.

[james . laskey]

Changeset: f50598618cbd
Author:jlaskey
Date:  2016-01-07 13:09 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f50598618cbd

Remove use of RandomAccessFile from jimage.

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java

hg: jigsaw/jake/jdk: Reenable java/nio/Buffer/LimitDirectMemory.sh test

[james . laskey]

Changeset: e8ac40b87434
Author:jlaskey
Date:  2016-01-06 12:47 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e8ac40b87434

Reenable java/nio/Buffer/LimitDirectMemory.sh test

! test/ProblemList.jake.txt

hg: jigsaw/jake/jdk: 8146243: jimage usage of direct buffers eats into MaxDirectMemorySize

[james . laskey]

Changeset: 111b11842e71
Author:jlaskey
Date:  2016-01-06 12:33 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/111b11842e71

8146243: jimage usage of direct buffers eats into MaxDirectMemorySize

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageBufferCache.java

hg: jigsaw/jake/jdk: Fix build break

[james . laskey]

Changeset: f3ff987e1b91
Author:jlaskey
Date:  2016-01-06 15:20 -0400
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f3ff987e1b91

Fix build break

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java

hg: jigsaw/jake/jdk: Backed out changeset 0d09d76b56d5 missing file moves

[james . laskey]

Changeset: 756fc7006809
Author:jlaskey
Date:  2015-09-18 10:33 -0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/756fc7006809

Backed out changeset 0d09d76b56d5 missing file moves

+ src/java.base/share/classes/jdk/internal/jimage/Archive.java
+ src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java
+ src/java.base/share/classes/jdk/internal/jimage/ExternalFilesWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageLocationBase.java
+ src/java.base/share/classes/jdk/internal/jimage/ImageLocationWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageModuleData.java
+ src/java.base/share/classes/jdk/internal/jimage/ImageModuleDataWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
+ src/java.base/share/classes/jdk/internal/jimage/ImageResourcesTree.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStream.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStrings.java
+ src/java.base/share/classes/jdk/internal/jimage/ImageStringsWriter.java
+ src/java.base/share/classes/jdk/internal/jimage/PerfectHashBuilder.java
! src/java.base/share/classes/jdk/internal/jimage/UTF8String.java
! src/java.base/share/native/libjimage/imageFile.cpp
! src/java.base/share/native/libjimage/imageFile.hpp
! src/jdk.jlink/share/classes/jdk/tools/jimage/ExtractedImage.java
! src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/JlinkTask.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/DirArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ExternalFilesWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JarArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JmodArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModularJarArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
! test/jdk/jigsaw/tools/jimage/JImageTest.java
! test/jdk/jigsaw/tools/jlink/ImageFileCreatorTest.java
! test/jdk/jigsaw/tools/lib/tests/JImageValidator.java

hg: jigsaw/jake/jdk: find bugs review

[james . laskey]

Changeset: 74be7c7a8257
Author:jfdenise
Date:  2015-09-18 13:11 -0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/74be7c7a8257

find bugs review

! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressIndexes.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressedResourceHeader.java
! src/java.base/share/classes/jdk/internal/jimage/decompressor/Decompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/StringSharingDecompressor.java
! 
src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressor.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/CommandLine.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/JlinkTask.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/TaskHelper.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Archive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/BasicImageWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/DirArchive.java
- src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ExternalFilesWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageLocationWriter.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginConfiguration.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JarArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JmodArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JvmHandler.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModularJarArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/FileCopierProvider.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/OptimizationPlugin.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ResourceFilter.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SortResourcesPlugin.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StringSharingPlugin.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/asm/AsmPoolImpl.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/asm/AsmPools.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/optim/ControlFlow.java
! 
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/optim/ForNameFolding.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/CmdPluginProvider.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/Jlink.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/ResourcePool.java
! test/jdk/jigsaw/tools/jlink/ImageFileCreatorTest.java

hg: jigsaw/jake/jdk: Remove last uses of jdata

[james . laskey]

Changeset: 2f4b40659bd1
Author:jfdenise
Date:  2015-09-18 12:17 -0300
URL:   http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/2f4b40659bd1

Remove last uses of jdata

- src/java.base/share/classes/jdk/internal/jimage/ExternalFilesWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageLocationBase.java
- src/java.base/share/classes/jdk/internal/jimage/ImageLocationWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageModuleData.java
- src/java.base/share/classes/jdk/internal/jimage/ImageModuleDataWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStream.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStrings.java
- src/java.base/share/classes/jdk/internal/jimage/ImageStringsWriter.java
- src/java.base/share/classes/jdk/internal/jimage/PerfectHashBuilder.java
! src/java.base/share/classes/jdk/internal/jimage/UTF8String.java
! src/java.base/share/native/libjimage/imageFile.cpp
! src/java.base/share/native/libjimage/imageFile.hpp
! src/jdk.jlink/share/classes/jdk/tools/jimage/ExtractedImage.java
! src/jdk.jlink/share/classes/jdk/tools/jimage/JImageTask.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/JlinkTask.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Archive.java < 
src/java.base/share/classes/jdk/internal/jimage/Archive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/BasicImageWriter.java < 
src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/DirArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ExternalFilesWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java
+ src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageLocationWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java 
< src/java.base/share/classes/jdk/internal/jimage/ImageResourcesTree.java
+ src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageStringsWriter.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JarArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JmodArchive.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ModularJarArchive.java
+ src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java
! src/jdk.jlink/share/classes/jdk/tools/jlink/plugins/DefaultImageBuilder.java
! test/jdk/jigsaw/tools/jimage/JImageTest.java
! test/jdk/jigsaw/tools/jlink/ImageFileCreatorTest.java
! test/jdk/jigsaw/tools/lib/tests/JImageValidator.java

Re: CFV: New jigsaw Committer: Jean-Francois Denise

[James Laskey]

Vote: yes

Sent from my iPhone

> On Sep 13, 2015, at 11:33 AM, Alan Bateman  wrote:
> 
> 
> I hereby nominate Jean-Francois Denise to jigsaw Committer.
> 
> Jean-Francois is a jdk9 Committer and has been contributing to the ongoing 
> development of the jimage container format. He has also been focused recently 
> on the link phase and jlink tool cited in JEP 261 [0]. He has more than 40 
> change-sets/contributions in the jigsaw/jake forest.
> 
> Votes are due by September 26, 2015 8:00 PDT.
> 
> Only current jigsaw Committers [1] are eligible to vote on this nomination. 
> Votes must be cast in the open by replying to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> -Alan.
> 
> [0] http://openjdk.java.net/jeps/261
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#committer-vote

hg: jigsaw/m2/hotspot: JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in appmodules.jimage

[james . laskey]

Changeset: b044703883d2
Author:jlaskey
Date:  2014-11-17 18:47 -0400
URL:   http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/b044703883d2

JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in 
appmodules.jimage

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/imageFile.cpp
! src/share/vm/classfile/imageFile.hpp

hg: jigsaw/m2/jdk: JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in appmodules.jimage

[james . laskey]

Changeset: da0b366ca4fb
Author:jlaskey
Date:  2014-11-17 18:48 -0400
URL:   http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/da0b366ca4fb

JDK-8062812 BasicImageReader.getResource fails with NPE when no modules in 
appmodules.jimage

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageFile.java
! src/java.base/share/classes/jdk/internal/jimage/ImageModules.java
! src/java.base/share/classes/jdk/internal/jimage/ImageStream.java
! src/java.base/share/classes/jdk/internal/jimage/PackageModuleMap.java
! src/java.base/share/classes/jdk/internal/jimage/UTF8String.java

hg: jigsaw/m2/hotspot: Clean up to follow hotspot coding quidelines

[james . laskey]

Changeset: 47de10c47b48
Author:jlaskey
Date:  2014-11-13 10:24 -0400
URL:   http://hg.openjdk.java.net/jigsaw/m2/hotspot/rev/47de10c47b48

Clean up to follow hotspot coding quidelines

! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/imageFile.cpp
! src/share/vm/classfile/imageFile.hpp

hg: jigsaw/m2/jdk: JDK-8061825 - jimage expand jimage create doesn't create usable jimage

[james . laskey]

Changeset: 5a241599213d
Author:jlaskey
Date:  2014-11-13 12:15 -0400
URL:   http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/5a241599213d

JDK-8061825 - jimage expand  jimage create doesn't create usable jimage

! src/demo/share/applets/GraphicsTest/AppletFrame.java
! src/demo/share/java2d/J2DBench/src/j2dbench/tests/text/TextTests.java
! src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java
! src/java.base/share/classes/com/sun/java/util/jar/pack/FixedList.java
! src/java.base/share/classes/java/util/stream/FindOps.java
! src/java.base/share/classes/java/util/stream/MatchOps.java
! src/java.base/share/classes/java/util/stream/SpinedBuffer.java
! src/java.base/share/classes/java/util/stream/StreamSpliterators.java
! src/java.base/share/classes/javax/net/ssl/SNIServerName.java
! src/java.base/share/classes/javax/net/ssl/SSLParameters.java
! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java
! src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
! src/java.base/share/classes/jdk/internal/jimage/PReader.java
! src/java.base/share/classes/jdk/internal/jimage/PackageModuleMap.java
! src/java.base/share/classes/jdk/internal/jimage/Resource.java
! src/java.base/share/classes/sun/invoke/WrapperInstance.java
! src/java.base/share/classes/sun/misc/CEFormatException.java
! src/java.base/share/classes/sun/misc/CEStreamExhausted.java
! src/java.base/share/classes/sun/misc/JavaNetHttpCookieAccess.java
! src/java.base/share/classes/sun/misc/JavaUtilZipFileAccess.java
! src/java.base/share/classes/sun/net/util/URLUtil.java
! src/java.base/share/classes/sun/net/www/protocol/http/AuthScheme.java
! src/java.base/share/classes/sun/net/www/protocol/http/BasicAuthentication.java
! src/java.base/share/classes/sun/net/www/protocol/http/Negotiator.java
! 
src/java.base/share/classes/sun/net/www/protocol/http/ntlm/NTLMAuthenticationCallback.java
! src/java.base/share/classes/sun/net/www/protocol/jrt/Handler.java
! 
src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java
! 
src/java.base/share/classes/sun/security/provider/certpath/UntrustedChecker.java
! src/java.base/share/classes/sun/security/ssl/MAC.java
! src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java
! src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java
! src/java.base/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java
! src/java.base/share/classes/sun/security/tools/keytool/Main.java
! 
src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java
! src/java.base/share/classes/sun/security/util/ECParameters.java
! src/java.base/share/classes/sun/security/util/KeyUtil.java
! src/java.base/share/classes/sun/security/util/Resources.java
! src/java.base/share/classes/sun/security/util/Resources_de.java
! src/java.base/share/classes/sun/security/util/Resources_es.java
! src/java.base/share/classes/sun/security/util/Resources_fr.java
! src/java.base/share/classes/sun/security/util/Resources_it.java
! src/java.base/share/classes/sun/security/util/Resources_ja.java
! src/java.base/share/classes/sun/security/util/Resources_ko.java
! src/java.base/share/classes/sun/security/util/Resources_pt_BR.java
! src/java.base/share/classes/sun/security/util/Resources_sv.java
! src/java.base/share/classes/sun/security/util/Resources_zh_CN.java
! src/java.base/share/classes/sun/security/util/Resources_zh_TW.java
! src/java.base/share/classes/sun/text/normalizer/UnicodeSet.java
! 
src/java.base/unix/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java
! 
src/java.base/windows/classes/sun/net/www/protocol/http/ntlm/NTLMAuthSequence.java
! src/java.desktop/macosx/classes/com/apple/eawt/_OpenAppHandler.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java
! src/java.desktop/macosx/classes/com/apple/laf/AquaUtils.java
! 
src/java.desktop/macosx/classes/sun/java2d/opengl/CGLVolatileSurfaceManager.java
! src/java.desktop/macosx/classes/sun/lwawt/LWMouseInfoPeer.java
! src/java.desktop/macosx/classes/sun/lwawt/macosx/CDataTransferer.java
! src/java.desktop/macosx/classes/sun/lwawt/macosx/CTrayIcon.java
! src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java
! src/java.desktop/share/classes/com/sun/awt/AWTUtilities.java
! src/java.desktop/share/classes/com/sun/awt/SecurityWarning.java
! src/java.desktop/share/classes/com/sun/media/sound/SoftReverb.java
! src/java.desktop/share/classes/javax/swing/plaf/nimbus/LoweredBorder.java
! src/java.desktop/share/classes/sun/awt/TimedWindowEvent.java
! src/java.desktop/share/classes/sun/awt/image/MultiResolutionCachedImage.java
! src/java.desktop/share/classes/sun/java2d/pisces/Curve.java
! src/java.desktop/share/classes/sun/java2d/pisces/Dasher.java
! src/java.desktop/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java
! 

hg: jigsaw/m2/jdk: When cloning ByteBuffers in jimage, endian was not copied.

[james . laskey]

Changeset: dea510f71a0a
Author:jlaskey
Date:  2014-11-13 12:35 -0400
URL:   http://hg.openjdk.java.net/jigsaw/m2/jdk/rev/dea510f71a0a

When cloning ByteBuffers in jimage, endian was not copied.

! src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java