Re: 8152650: ModuleFinder.compose should accept varargs

2016-05-21 Thread Chris Hegarty 

> On 21 May 2016, at 00:13, Mandy Chung  wrote:
> 
> 
>> On May 20, 2016, at 1:57 PM, Alan Bateman  wrote:
>> 
>> 
>> There are several patches that didn't go in with the last update, the change 
>> to ModuleFinder.compose to use varargs was one of them. The other part to 
>> this is removing the empty() method as it is redundant. The changes are 
>> straight-forward:
>> http://cr.openjdk.java.net/~alanb/8152650/webrev/
> 
> This looks good to me.

+1

-Chris.

Re: 8152650: ModuleFinder.compose should accept varargs

2016-05-20 Thread Mandy Chung 

> On May 20, 2016, at 1:57 PM, Alan Bateman  wrote:
> 
> 
> There are several patches that didn't go in with the last update, the change 
> to ModuleFinder.compose to use varargs was one of them. The other part to 
> this is removing the empty() method as it is redundant. The changes are 
> straight-forward:
>  http://cr.openjdk.java.net/~alanb/8152650/webrev/

This looks good to me.

Mandy

8152650: ModuleFinder.compose should accept varargs

2016-05-20 Thread Alan Bateman 


There are several patches that didn't go in with the last update, the 
change to ModuleFinder.compose to use varargs was one of them. The other 
part to this is removing the empty() method as it is redundant. The 
changes are straight-forward:

  http://cr.openjdk.java.net/~alanb/8152650/webrev/

I dropped the changes to the langtools repo as Jon/Vicente have a patch 
in flight that drops empty(). Also the last round of jdeps updates 
removed the use of empty().


-Alan.