Re: RFR [9] 8172982: tools/jlink/ResourceDuplicateCheckTest.java requires jdk.tools.jlink.plugin to be exported

2017-01-18 Thread Sundararajan Athijegannathan 

+1

-Sundar

On 18/01/17, 10:35 PM, Chris Hegarty wrote:

Since the jlink plugin package is no longer exported this test should
add the appropriate @modules tag.

diff -r 5b75946223fb test/tools/jlink/ResourceDuplicateCheckTest.java
--- a/test/tools/jlink/ResourceDuplicateCheckTest.java  Wed Jan 18 13:56:50 
2017 +
+++ b/test/tools/jlink/ResourceDuplicateCheckTest.java  Wed Jan 18 17:05:11 
2017 +
@@ -27,6 +27,7 @@
   * @summary Detect duplicated resources in packaged modules
   * @modules jdk.jlink/jdk.tools.jlink.builder
   *  jdk.jlink/jdk.tools.jlink.internal
+ *  jdk.jlink/jdk.tools.jlink.plugin
   * @run build ResourceDuplicateCheckTest
   * @run main ResourceDuplicateCheckTest
   */

-Chris.

Re: RFR [9] 8172982: tools/jlink/ResourceDuplicateCheckTest.java requires jdk.tools.jlink.plugin to be exported

2017-01-18 Thread Mandy Chung 
+1

Mandy

> On Jan 18, 2017, at 9:05 AM, Chris Hegarty  wrote:
> 
> Since the jlink plugin package is no longer exported this test should
> add the appropriate @modules tag.
> 
> diff -r 5b75946223fb test/tools/jlink/ResourceDuplicateCheckTest.java
> --- a/test/tools/jlink/ResourceDuplicateCheckTest.javaWed Jan 18 
> 13:56:50 2017 +
> +++ b/test/tools/jlink/ResourceDuplicateCheckTest.javaWed Jan 18 
> 17:05:11 2017 +
> @@ -27,6 +27,7 @@
>  * @summary Detect duplicated resources in packaged modules
>  * @modules jdk.jlink/jdk.tools.jlink.builder
>  *  jdk.jlink/jdk.tools.jlink.internal
> + *  jdk.jlink/jdk.tools.jlink.plugin
>  * @run build ResourceDuplicateCheckTest
>  * @run main ResourceDuplicateCheckTest
>  */
> 
> -Chris.

RFR [9] 8172982: tools/jlink/ResourceDuplicateCheckTest.java requires jdk.tools.jlink.plugin to be exported

2017-01-18 Thread Chris Hegarty 
Since the jlink plugin package is no longer exported this test should
add the appropriate @modules tag.

diff -r 5b75946223fb test/tools/jlink/ResourceDuplicateCheckTest.java
--- a/test/tools/jlink/ResourceDuplicateCheckTest.java  Wed Jan 18 13:56:50 
2017 +
+++ b/test/tools/jlink/ResourceDuplicateCheckTest.java  Wed Jan 18 17:05:11 
2017 +
@@ -27,6 +27,7 @@
  * @summary Detect duplicated resources in packaged modules
  * @modules jdk.jlink/jdk.tools.jlink.builder
  *  jdk.jlink/jdk.tools.jlink.internal
+ *  jdk.jlink/jdk.tools.jlink.plugin
  * @run build ResourceDuplicateCheckTest
  * @run main ResourceDuplicateCheckTest
  */

-Chris.