Re: RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

2016-11-16 Thread Mandy Chung
Looks okay.

Mandy

> On Nov 16, 2016, at 12:30 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8153038
> 
> PS. Pre-existing IntegrationTest.java test already checks the Jlink API code 
> path [so, no new test added].
> 
> Thanks,
> -Sundar



Re: RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

2016-11-16 Thread Jim Laskey (Oracle)
+1

> On Nov 16, 2016, at 4:30 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for 
> https://bugs.openjdk.java.net/browse/JDK-8153038
> 
> PS. Pre-existing IntegrationTest.java test already checks the Jlink API code 
> path [so, no new test added].
> 
> Thanks,
> -Sundar



RFR 8153038: The set of jlink plugins enabled by default should be the same via CLI or jlink API

2016-11-16 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8153038/webrev.00/ for 
https://bugs.openjdk.java.net/browse/JDK-8153038


PS. Pre-existing IntegrationTest.java test already checks the Jlink API 
code path [so, no new test added].


Thanks,
-Sundar