Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

2016-08-29 Thread Alan Bateman 

On 29/08/2016 14:28, Sundararajan Athijegannathan wrote:


Updated: http://cr.openjdk.java.net/~sundar/8159004/webrev.02/

-Sundar



This looks okay to me.

-Alan

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

2016-08-29 Thread Sundararajan Athijegannathan 
Updated: http://cr.openjdk.java.net/~sundar/8159004/webrev.02/

-Sundar


On 8/29/2016 5:52 PM, Alan Bateman wrote:
> On 29/08/2016 13:00, Sundararajan Athijegannathan wrote:
>
>> Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/
>> for https://bugs.openjdk.java.net/browse/JDK-8159004
>>
>> Piggybacking couple of cleanups suggested (but missed) in this thread
>> ->
>> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009186.html
> In storeFiles then you could move "Path bin = ..." to the enclosing
> scope and avoid a bit of duplications, otherwise looks good.
>
> -Alan

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

2016-08-29 Thread Alan Bateman 

On 29/08/2016 13:00, Sundararajan Athijegannathan wrote:

Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ 
for https://bugs.openjdk.java.net/browse/JDK-8159004


Piggybacking couple of cleanups suggested (but missed) in this thread 
-> 
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009186.html
In storeFiles then you could move "Path bin = ..." to the enclosing 
scope and avoid a bit of duplications, otherwise looks good.


-Alan

Re: RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

2016-08-29 Thread Jim Laskey (Oracle) 
+1

> On Aug 29, 2016, at 9:00 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for 
> https://bugs.openjdk.java.net/browse/JDK-8159004
> 
> Piggybacking couple of cleanups suggested (but missed) in this thread -> 
> http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009186.html
> 
> 
> Thanks,
> -Sundar

RFR 8159004: jlink attempts to create launcher scripts when root/bin dir does not exist

2016-08-29 Thread Sundararajan Athijegannathan 
Please review http://cr.openjdk.java.net/~sundar/8159004/webrev.01/ for 
https://bugs.openjdk.java.net/browse/JDK-8159004


Piggybacking couple of cleanups suggested (but missed) in this thread -> 
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-August/009186.html



Thanks,
-Sundar